Build fails on macOS when enable BUILD_TESTS

[xumingming]

Problem description

In file included from /tmp/gluten/cpp/velox/tests/Substrait2VeloxPlanConversionTest.cc:18:
/tmp/gluten/cpp/velox/tests/JsonToProtoConverter.h:20:10: fatal error: 'google/protobuf/util/json_util.h' file not found
#include <google/protobuf/util/json_util.h>
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[  5%] Building CXX object _deps/gbenchmark-build/src/CMakeFiles/benchmark.dir/benchmark_register.cc.o
In file included from /tmp/gluten/cpp/velox/tests/VeloxColumnarToRowTest.cc:18:
/tmp/gluten/cpp/velox/memory/VeloxColumnarBatch.h:20:10: fatal error: 'memory/ColumnarBatch.h' file not found
#include "memory/ColumnarBatch.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~
[  6%] Building CXX object _deps/gbenchmark-build/src/CMakeFiles/benchmark.dir/benchmark_runner.cc.o
/tmp/gluten/cpp/velox/tests/SparkFunctionTest.cc:21:10: fatal error: 'velox/functions/sparksql/tests/SparkFunctionBaseTest.h' file not found
#include "velox/functions/sparksql/tests/SparkFunctionBaseTest.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
make[2]: *** [velox/tests/CMakeFiles/spark_functions_test.dir/SparkFunctionTest.cc.o] Error 1
make[1]: *** [velox/tests/CMakeFiles/spark_functions_test.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
1 error generated.
make[2]: *** [velox/tests/CMakeFiles/velox_plan_conversion_test.dir/Substrait2VeloxPlanConversionTest.cc.o] Error 1
make[2]: *** Waiting for unfinished jobs....
/tmp/gluten/cpp/velox/tests/VeloxShuffleWriterTest.cc:21:10: fatal error: 'shuffle/LocalPartitionWriter.h' file not found
#include "shuffle/LocalPartitionWriter.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[  7%] Building CXX object velox/tests/CMakeFiles/velox_plan_conversion_test.dir/Substrait2VeloxPlanValidatorTest.cc.o
[  7%] Building CXX object velox/tests/CMakeFiles/velox_shuffle_writer_test.dir/JsonToProtoConverter.cc.o
1 error generated.
make[2]: *** [velox/tests/CMakeFiles/velox_operators_test.dir/VeloxColumnarToRowTest.cc.o] Error 1
make[1]: *** [velox/tests/CMakeFiles/velox_operators_test.dir/all] Error 2
1 error generated.
make[2]: *** [velox/tests/CMakeFiles/velox_shuffle_writer_test.dir/VeloxShuffleWriterTest.cc.o] Error 1
make[2]: *** Waiting for unfinished jobs....
[  8%] Building CXX object _deps/gbenchmark-build/src/CMakeFiles/benchmark.dir/colorprint.cc.o
[  8%] Building CXX object _deps/gbenchmark-build/src/CMakeFiles/benchmark.dir/commandlineflags.cc.o
[  9%] Building CXX object _deps/gbenchmark-build/src/CMakeFiles/benchmark.dir/complexity.cc.o
[ 10%] Building CXX object _deps/gbenchmark-build/src/CMakeFiles/benchmark.dir/console_reporter.cc.o
[ 10%] Building CXX object _deps/gbenchmark-build/src/CMakeFiles/benchmark.dir/counter.cc.o
[ 10%] Built target jni_proto
/tmp/gluten/cpp/velox/tests/JsonToProtoConverter.cc:18:10: fatal error: 'velox/substrait/tests/JsonToProtoConverter.h' file not found
#include "velox/substrait/tests/JsonToProtoConverter.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[ 11%] Building CXX object _deps/gbenchmark-build/src/CMakeFiles/benchmark.dir/csv_reporter.cc.o
[ 12%] Building CXX object _deps/gbenchmark-build/src/CMakeFiles/benchmark.dir/json_reporter.cc.o
[ 12%] Building CXX object _deps/gbenchmark-build/src/CMakeFiles/benchmark.dir/perf_counters.cc.o
[ 13%] Building CXX object _deps/gbenchmark-build/src/CMakeFiles/benchmark.dir/reporter.cc.o
[ 14%] Building CXX object _deps/gbenchmark-build/src/CMakeFiles/benchmark.dir/sleep.cc.o
[ 14%] Building CXX object _deps/gbenchmark-build/src/CMakeFiles/benchmark.dir/statistics.cc.o
In file included from /tmp/gluten/cpp/velox/tests/Substrait2VeloxPlanValidatorTest.cc:19:
/tmp/gluten/cpp/velox/tests/JsonToProtoConverter.h:20:10: fatal error: 'google/protobuf/util/json_util.h' file not found
#include <google/protobuf/util/json_util.h>
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[ 15%] Building CXX object _deps/gbenchmark-build/src/CMakeFiles/benchmark.dir/string_util.cc.o
1 error generated.
make[2]: *** [velox/tests/CMakeFiles/velox_plan_conversion_test.dir/Substrait2VeloxPlanValidatorTest.cc.o] Error 1
make[1]: *** [velox/tests/CMakeFiles/velox_plan_conversion_test.dir/all] Error 2
1 error generated.
make[2]: *** [velox/tests/CMakeFiles/velox_shuffle_writer_test.dir/JsonToProtoConverter.cc.o] Error 1
make[1]: *** [velox/tests/CMakeFiles/velox_shuffle_writer_test.dir/all] Error 2
[ 16%] Building CXX object _deps/gbenchmark-build/src/CMakeFiles/benchmark.dir/sysinfo.cc.o
[ 16%] Building CXX object _deps/gbenchmark-build/src/CMakeFiles/benchmark.dir/timers.cc.o
[ 17%] Linking CXX static library libbenchmark.a
[ 17%] Built target benchmark
make: *** [all] Error 2

System information

Velox System Info v0.0.2
Commit: f044f3b
CMake Version: 3.29.6
System: Darwin-23.3.0
Arch: arm64
CPU Name:
C++ Compiler: /Library/Developer/CommandLineTools/usr/bin/c++
C++ Compiler Version: 15.0.0.15000309
C Compiler: /Library/Developer/CommandLineTools/usr/bin/cc
C Compiler Version: 15.0.0.15000309
CMake Prefix Path: /Library/Developer/CommandLineTools/SDKs/MacOSX14.4.sdk/usr;/opt/homebrew;/usr/local;/usr;/;/opt/homebrew/Cellar/cmake/3.29.6;/usr/local;/usr/X11R6;/usr/pkg;/opt;/sw;/opt/local

CMake log

No response

[xumingming]

In file included from /tmp/gluten/cpp/velox/tests/MemoryManagerTest.cc:18:
/tmp/gluten/cpp/velox/benchmarks/common/BenchmarkUtils.h:28:10: fatal error: 'benchmark/benchmark.h' file not found
#include "benchmark/benchmark.h"
         ^~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
make[2]: *** [velox/tests/CMakeFiles/velox_memory_test.dir/MemoryManagerTest.cc.o] Error 1
make[1]: *** [velox/tests/CMakeFiles/velox_memory_test.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 79%] Building CXX object velox/tests/CMakeFiles/spark_functions_test.dir/FunctionTest.cc.o
[ 80%] Building CXX object velox/tests/CMakeFiles/spark_functions_test.dir/JsonToProtoConverter.cc.o
[ 81%] Building CXX object velox/tests/CMakeFiles/velox_operators_test.dir/VeloxRowToColumnarTest.cc.o
[ 81%] Building CXX object velox/tests/CMakeFiles/execution_ctx_test.dir/JsonToProtoConverter.cc.o
[ 82%] Building CXX object velox/tests/CMakeFiles/execution_ctx_test.dir/FilePathGenerator.cc.o
[ 82%] Building CXX object velox/tests/CMakeFiles/velox_shuffle_writer_test.dir/JsonToProtoConverter.cc.o
[ 83%] Building CXX object velox/tests/CMakeFiles/velox_shuffle_writer_test.dir/FilePathGenerator.cc.o
[ 84%] Building CXX object velox/tests/CMakeFiles/velox_plan_conversion_test.dir/Substrait2VeloxPlanValidatorTest.cc.o
[ 85%] Linking CXX executable velox_shuffle_writer_test
[ 86%] Linking CXX executable execution_ctx_test
ld: warning: ignoring duplicate libraries: '/tmp/gluten/ep/build-velox/build/velox_ep/_build/debug/velox/dwio/common/tests/utils/libvelox_dwio_common_test_utils.a', '/opt/homebrew/Cellar/duckdb/1.0.0/lib/libautocomplete_extension.a', '/opt/homebrew/Cellar/duckdb/1.0.0/lib/libduckdb_static.a', '/opt/homebrew/Cellar/duckdb/1.0.0/lib/libicu_extension.a', '/opt/homebrew/Cellar/duckdb/1.0.0/lib/libjson_extension.a', '/opt/homebrew/Cellar/duckdb/1.0.0/lib/libparquet_extension.a', '/usr/local/lib/libgtest.a'
ld: warning: ignoring duplicate libraries: '/tmp/gluten/ep/build-velox/build/velox_ep/_build/debug/velox/dwio/common/tests/utils/libvelox_dwio_common_test_utils.a', '/opt/homebrew/Cellar/duckdb/1.0.0/lib/libautocomplete_extension.a', '/opt/homebrew/Cellar/duckdb/1.0.0/lib/libduckdb_static.a', '/opt/homebrew/Cellar/duckdb/1.0.0/lib/libicu_extension.a', '/opt/homebrew/Cellar/duckdb/1.0.0/lib/libjson_extension.a', '/opt/homebrew/Cellar/duckdb/1.0.0/lib/libparquet_extension.a', '/usr/local/lib/libgtest.a'
ld: library 'velox_benchmark_common' not found
ld: library 'velox_benchmark_common' not found
clang: error: linker command failed with exit code 1 (use -v to see invocation)
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [velox/tests/execution_ctx_test] Error 1
make[1]: *** [velox/tests/CMakeFiles/execution_ctx_test.dir/all] Error 2
make[2]: *** [velox/tests/velox_shuffle_writer_test] Error 1
make[1]: *** [velox/tests/CMakeFiles/velox_shuffle_writer_test.dir/all] Error 2
[ 87%] Building CXX object velox/tests/CMakeFiles/velox_operators_test.dir/VeloxColumnarBatchSerializerTest.cc.o
[ 87%] Building CXX object velox/tests/CMakeFiles/velox_operators_test.dir/VeloxColumnarBatchTest.cc.o
/tmp/gluten/cpp/velox/tests/FunctionTest.cc:75:31: error: object backing the pointer will be destroyed at the end of the full-expression [-Werror,-Wdangling-gsl]
  std::string_view funcName = SubstraitParser::getNameBeforeDelimiter(functionSpec);
                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
make[2]: *** [velox/tests/CMakeFiles/spark_functions_test.dir/FunctionTest.cc.o] Error 1
make[1]: *** [velox/tests/CMakeFiles/spark_functions_test.dir/all] Error 2
[ 87%] Building CXX object velox/tests/CMakeFiles/velox_plan_conversion_test.dir/Substrait2VeloxValuesNodeConversionTest.cc.o
/tmp/gluten/cpp/velox/tests/VeloxRowToColumnarTest.cc:54:56: error: cannot initialize a parameter of type 'int64_t *' (aka 'long long *') with an lvalue of type 'long[lengthVec.size()]'
    auto cb = rowToColumnarConverter->convert(numRows, lengthArr, address);
                                                       ^~~~~~~~~
/tmp/gluten/cpp/velox/operators/serializer//VeloxRowToColumnarConverter.h:34:68: note: passing argument to parameter 'rowLength' here
  std::shared_ptr<ColumnarBatch> convert(int64_t numRows, int64_t* rowLength, uint8_t* memoryAddress);
                                                                   ^
1 error generated.