Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Remove explicit use of utility methods ensureLoaded() and ensureOffloaded() #540

Open
zhztheplayer opened this issue Nov 10, 2022 · 0 comments
Labels
enhancement New feature or request stale stale velox backend works for Velox backend

Comments

@zhztheplayer
Copy link
Member

zhztheplayer commented Nov 10, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

A couple of developers might discover that it's not that easy to decide when to use ensureLoaded to load native data to JVM as well as ensureOffloaded. The existing of the methods were to implement lazy load/offload on data to reduce the overall JNI overhead running queires.

Describe the solution you'd like
Spark 3.3 made class ColumnarBatch inheritable. We can implement the class by (e.g.) GlutenLoadedColumnarBatch and GlutenOffloadedColumnarBatch, then we don't need developers to explicitly use ensureLoaded and ensureOffloaded.

This is a placeholder issue since we are now still on Spark 3.2 and ColumnarBatch is still not allowed to be extended.

@zhztheplayer zhztheplayer added the enhancement New feature or request label Nov 10, 2022
@zhztheplayer zhztheplayer changed the title Remove explicit use of utility methods ensureLoaded() and ensureOffloaded Remove explicit use of utility methods ensureLoaded() and ensureOffloaded() Nov 10, 2022
@weiting-chen weiting-chen added the velox backend works for Velox backend label Mar 1, 2023
@zhztheplayer zhztheplayer changed the title Remove explicit use of utility methods ensureLoaded() and ensureOffloaded() [VL] Remove explicit use of utility methods ensureLoaded() and ensureOffloaded() Apr 4, 2023
@github-actions github-actions bot added the stale stale label Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale stale velox backend works for Velox backend
Projects
None yet
Development

No branches or pull requests

2 participants