Update release scripts to support publishing Spark 3.2 with Scala 2.13 support to Maven #4167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbendick
commented
Feb 18, 2022
rdblue
reviewed
Feb 20, 2022
rdblue
reviewed
Feb 20, 2022
rdblue
reviewed
Feb 20, 2022
kbendick
force-pushed
the
patch-3
branch
2 times, most recently
from
f52d7e1
to
7744eed
Compare
kbendick
changed the title
|
Any updates on what exactly this PR is waiting for? I see this branch has conflicts with master, but anything else? |
|
Looks like it needs to fix the conflicts. After that I can take another look. |
rdblue
approved these changes
May 13, 2022
|
I can pick this up over the weekend if @kbendick doesn't get to it before then. |
|
I can fix the conflicts now. Thank you though @fqaiser94. And thank you for drawing attention to this PR again. I was out of town for a wedding and didn't see these comments as I've been catching up So we'll get this in right away. |
Noticed we added support for Scala 2.13 with Spark 3.2 recently, but the build scripts have not been updated to reflect that. This came up as a result of this discussion: apache#4157 (comment). There's possibly more work to do
kbendick
commented
May 17, 2022
rdblue
approved these changes
May 18, 2022
|
Thanks, @kbendick! And thanks for making sure this went in, @fqaiser94! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed we added support for Scala 2.13 with Spark 3.2 recently, but the release scripts have not been updated to reflect that. The nightly release workflow has been updated to publish Scala 2.13 artifacts: #4009
This came up as a result of this discussion: #4157 (comment). There's probably more work to do, and I can covert this to an issue if somebody else wants to take over.