Part 2: Integrate Scan Planning to Core #13400
Draft
+3,321
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Rahil <rchertara@gmail.com> Co-authored-by: Prashant <singhpk010696@gmaill.com>
singhpk234
commented
Jun 27, 2025
Comment on lines
+157
to
+160
| // else { | ||
| // | ||
| // assertThat(request.headers().entries()).containsAll(contextHeaders.entries()); | ||
| // } |
There was a problem hiding this comment.
To be removed, need to remodel the tests correctly, but presently the E2E machinery works with scan planning and with context aware parsers !
singhpk234
force-pushed
the
feature/part-2-core-integ
branch
from
3624aee to
c55e0e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥞 Stacked PR
Please use this link for viewing incremental changes.
Current Stack status:
* Add Rest Model and Parsers
About the change
[1] Add routes for the scan Planning API
[2] Adds RestTable and RestTableScan which can call the scan endpoint
[3] ScanIterable which uses ParallelIterable to fetch scan tasks
Testing
Added unit testing for the E2E req response loop