Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add apache amoro(incubating) with iceberg (#11965) #11966

Merged
merged 3 commits into from
Feb 19, 2025

Conversation

czy006
Copy link
Contributor

@czy006 czy006 commented Jan 14, 2025

add apache amoro(incubating) describe with iceberg (#11965)

@github-actions github-actions bot added the docs label Jan 14, 2025
@ebyhr
Copy link
Contributor

ebyhr commented Jan 15, 2025

add apache amoro(incubating) describe with iceberg (#11965)

You could use Fixes #11965 comment in the PR description so we can automatically close the issue.
https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

@zhoujinsong
Copy link

Thanks for bringing this up. @czy006

Apache Amoro(incubating) is a Lakehouse management system and entered the Apache incubator in 2024.
It indeed helps some Iceberg users automatically optimize their Iceberg tables, making it easier for them to use Iceberg effectively.

I am glad to see that we are trying to add some information about Amoro to the Iceberg site so that more Iceberg users can see it.

However, from my perspective, is adding a link good enough? Amoro should provide information on how to deal with Iceberg on its own documentation site and continuously update and optimize it.

@czy006
Copy link
Contributor Author

czy006 commented Jan 19, 2025

Thanks for bringing this up. @czy006

Apache Amoro(incubating) is a Lakehouse management system and entered the Apache incubator in 2024. It indeed helps some Iceberg users automatically optimize their Iceberg tables, making it easier for them to use Iceberg effectively.

I am glad to see that we are trying to add some information about Amoro to the Iceberg site so that more Iceberg users can see it.

However, from my perspective, is adding a link good enough? Amoro should provide information on how to deal with Iceberg on its own documentation site and continuously update and optimize it.

Thank you for raising your doubts. We can add some brief introductions about the integration of Iceberg and Amoro, likes projects Spark, Flink, and Hive docs. Specific usage requires users to visit Apache Amoro web site for self understanding

@czy006 czy006 force-pushed the issues/iceberg-11965 branch 2 times, most recently from ece2f92 to fd8a9de Compare January 19, 2025 15:28
@czy006
Copy link
Contributor Author

czy006 commented Jan 19, 2025

plat,thanks cc @nastra @ebyhr

@czy006 czy006 requested review from ebyhr, nastra and XBaith January 20, 2025 13:56
@czy006 czy006 requested a review from nastra January 22, 2025 07:39
@czy006 czy006 force-pushed the issues/iceberg-11965 branch from f45b691 to df67d03 Compare January 23, 2025 05:29
@czy006 czy006 requested a review from XBaith January 23, 2025 05:31
@czy006 czy006 requested a review from nastra January 29, 2025 04:12
@nastra nastra requested review from Fokko and removed request for ebyhr and XBaith January 29, 2025 14:44
@czy006
Copy link
Contributor Author

czy006 commented Feb 7, 2025

Hi @Fokko @jbonofre , can help look amoro project description with iceberg?

@czy006 czy006 requested review from ebyhr, nastra and XBaith February 7, 2025 08:00
@czy006 czy006 force-pushed the issues/iceberg-11965 branch from b3cc019 to c81f1ac Compare February 7, 2025 08:45
@manuzhang
Copy link
Collaborator

@czy006 IMHO, the doc looks too verbose, and it might be better linking to the detailed description on the Amoro website while only keeping a brief introduction here for each feature.

@czy006
Copy link
Contributor Author

czy006 commented Feb 18, 2025

@czy006 IMHO, the doc looks too verbose, and it might be better linking to the detailed description on the Amoro website while only keeping a brief introduction here for each feature.

I will adjust some doc descriptions to make them look more concise

@czy006 czy006 force-pushed the issues/iceberg-11965 branch from fff70d6 to 37aa2c7 Compare February 18, 2025 08:33
@czy006 czy006 requested a review from manuzhang February 18, 2025 08:34
@czy006
Copy link
Contributor Author

czy006 commented Feb 18, 2025

I have now corrected the format and removed some descriptions, and link some feature to amoro website cc @manuzhang

@czy006 czy006 requested a review from manuzhang February 19, 2025 06:51
@nastra nastra merged commit 1bf55b4 into apache:main Feb 19, 2025
2 checks passed
@czy006
Copy link
Contributor Author

czy006 commented Feb 19, 2025

Thanks for review. I will fix some image reference issues in the next PR. cc @nastra @manuzhang

ankurbansal-tradedoubler added a commit to ankurbansal-tradedoubler/iceberg that referenced this pull request Feb 19, 2025
* Site: Learn More to point to Spark QuickStart Doc (apache#12272)

* Build: Bump datamodel-code-generator from 0.27.2 to 0.28.1 (apache#12290)

* Spark 3.5: Fix job description of RewriteTablePathSparkAction (apache#12282)

* Build: Bump io.netty:netty-buffer from 4.1.117.Final to 4.1.118.Final (apache#12287)

Bumps [io.netty:netty-buffer](https://github.com/netty/netty) from 4.1.117.Final to 4.1.118.Final.
- [Commits](netty/netty@netty-4.1.117.Final...netty-4.1.118.Final)

---
updated-dependencies:
- dependency-name: io.netty:netty-buffer
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Build: Bump software.amazon.awssdk:bom from 2.30.16 to 2.30.21 (apache#12286)

Bumps software.amazon.awssdk:bom from 2.30.16 to 2.30.21.

---
updated-dependencies:
- dependency-name: software.amazon.awssdk:bom
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* OpenAPI: Add overwrite option when registering a table (apache#12239)

* OpenAPI: Add optional overwrite when registering table

* simplify to overwrite

* Add the article to the description

Co-authored-by: Eduard Tudenhoefner <etudenhoefner@gmail.com>

* Update generated python as well

Signed-off-by: Hongyue Zhang <steveiszhy@gmail.com>

* Fix import order

---------

Signed-off-by: Hongyue Zhang <steveiszhy@gmail.com>
Co-authored-by: Eduard Tudenhoefner <etudenhoefner@gmail.com>

* Build: Bump mkdocs-material from 9.6.3 to 9.6.4 (apache#12284)

Bumps [mkdocs-material](https://github.com/squidfunk/mkdocs-material) from 9.6.3 to 9.6.4.
- [Release notes](https://github.com/squidfunk/mkdocs-material/releases)
- [Changelog](https://github.com/squidfunk/mkdocs-material/blob/master/CHANGELOG)
- [Commits](squidfunk/mkdocs-material@9.6.3...9.6.4)

---
updated-dependencies:
- dependency-name: mkdocs-material
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Core: Fix Enabling row-lineage during Create Table (apache#12307)

* API: Reject unknown type for required fields and validate defaults (apache#12302)

* API: Fix TestInclusiveMetricsEvaluator notStartsWith tests. (apache#12303)

* Core: Add variant type support to utils and visitors (apache#11831)

* Core: Fix CI: Update tests with UnknownType from required to optional (apache#12316)

* Docs: Refactor site navigation bar (apache#12289)

* Parquet: Implement Variant readers (apache#12139)

* Docs: Add rewrite_table_path Spark Procedure (apache#12115)

* Parquet: Fix errorprone warning (apache#12324)

* Docs: Add Apache Amoro docs (apache#11966)

* Parquet: Fix performance regression in reader init (apache#12305)

* Core: Fallback to GET requests for namespace/table/view exists checks (apache#12314)

Co-authored-by: Daniel Weeks <dweeks@apache.org>

* Docs: Fix refs in Apache Amoro docs (apache#12332)

* Revert "Core: Serialize `null` when there is no current snapshot (apache#11560)" (apache#12312)

This reverts commit bf8d25f.

* Parquet: Fix performance regression in reader init (apache#12305) (apache#12329)

Co-authored-by: Bryan Keller <bryanck@gmail.com>

* Checkstyle: Apply the same generic type naming rules to interfaces and classes (apache#12333)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Hongyue Zhang <steveiszhy@gmail.com>
Co-authored-by: Danica Fine <danica.fine@gmail.com>
Co-authored-by: Manu Zhang <OwenZhang1990@gmail.com>
Co-authored-by: Yuya Ebihara <ebyhry@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Hongyue/Steve Zhang <steveiszhy@gmail.com>
Co-authored-by: Eduard Tudenhoefner <etudenhoefner@gmail.com>
Co-authored-by: Tom Tanaka <43331405+tomtongue@users.noreply.github.com>
Co-authored-by: Ryan Blue <blue@apache.org>
Co-authored-by: Aihua Xu <aihuaxu@gmail.com>
Co-authored-by: Fokko Driesprong <fokko@apache.org>
Co-authored-by: ConradJam <jam.gzczy@gmail.com>
Co-authored-by: Bryan Keller <bryanck@gmail.com>
Co-authored-by: Daniel Weeks <dweeks@apache.org>
Co-authored-by: pvary <peter.vary.apache@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants