Core: Support DVs in DeleteFileIndex #11467
Merged
+121
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
reviewed
Nov 5, 2024
| @@ -84,4 +85,17 @@ public static String referencedDataFileLocation(DeleteFile deleteFile) { | |||
| CharSequence location = referencedDataFile(deleteFile); | |||
| return location != null ? location.toString() : null; | |||
| } | |||
|
|
|||
| public static boolean isDV(DeleteFile deleteFile) { | |||
There was a problem hiding this comment.
same as I mentioned on the other PR. This isn't probably needed anymore, since it exists in ScanTaskUtil
There was a problem hiding this comment.
This is actually intentional. I originally wanted to move ContentFileUtil to api but then we decided against that, as it required moving more classes and increasing the API surface. Therefore, we added a simple utility for what was needed in api. I do want ContentFileUtil to contain all the logic for content files, it is just a matter of one duplicate method. I made that method in ScanTaskUtil private on purpose.
|
Thanks for reviewing, @nastra! |
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds supports for DVs in
DeleteFileIndex.This work is part of #11122.