Core, Data, Flink, Spark: Improve tableDir initialization for tests #11460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
force-pushed
the
test-improvements
branch
3 times, most recently
from
51bdb39 to
b85c7ae
Compare
manuzhang
approved these changes
Nov 5, 2024
Fokko
reviewed
Nov 5, 2024
| @@ -73,6 +72,7 @@ public static List<Object> parameters() { | |||
| } | |||
|
|
|||
| @TempDir public Path temp; | |||
There was a problem hiding this comment.
Unrelated nit
Suggested change
| @TempDir public Path temp; | |
| @TempDir private Path temp; |
There was a problem hiding this comment.
can't make it private unfortunately, but protected would work, since it's being used in subclasses
Fokko
approved these changes
Nov 5, 2024
nastra
force-pushed
the
test-improvements
branch
from
b85c7ae to
79b122e
Compare
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typically initialization of a table dir is either already handled in a super class or we can make use of
@TempDir, thus not requiring manual re-initialization