Remove spring-boot dependency #11291
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuzhang
reviewed
Oct 10, 2024
| @@ -121,8 +116,9 @@ void deleteBucket(String bucketName) throws IOException { | |||
|
|
|||
| File dir = new File(root, bucket.getName()); | |||
| if (Files.walk(dir.toPath()).anyMatch(p -> p.toFile().isFile())) { | |||
| throw new AliyunOSSMockLocalController.OssException( | |||
| 409, OSSErrorCode.BUCKET_NOT_EMPTY, "The bucket you tried to delete is not empty. "); | |||
| // throw new OSSException(409, OSSErrorCode.BUCKET_NOT_EMPTY, "The bucket you tried to delete | |||
There was a problem hiding this comment.
why do we keep this commented line?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the spring-boot dependency from Iceberg and implement Aliyun OSS Mock using the JDK HTTP server.