REST: Docker file for Rest catalog adapter image #11283
Conversation
ajantha-bhat
force-pushed
the
docker_rest
branch
from
ed2ba10
to
56ee5ee
Compare
| COPY --from=builder --chown=iceberg:iceberg /app/iceberg-open-api-test-fixtures-runtime-*.jar /usr/lib/iceberg-rest/iceberg-rest-adapter.jar | ||
|
|
||
| ENV CATALOG_CATALOG__IMPL=org.apache.iceberg.jdbc.JdbcCatalog | ||
| ENV CATALOG_URI=jdbc:sqlite:file:/tmp/iceberg_rest_mode=memory |
There was a problem hiding this comment.
FYI this does not create an in-memory database, it ends up creating the file /tmp/iceberg_rest_mode=memory instead
There was a problem hiding this comment.
I followed these configs from https://github.com/tabular-io/iceberg-rest-image/blob/master/Dockerfile
There was a problem hiding this comment.
tabular-io/iceberg-rest-image#68 for more context
| ENV CATALOG_URI=jdbc:sqlite:file:/tmp/iceberg_rest_mode=memory | ||
| ENV CATALOG_JDBC_USER=user | ||
| ENV CATALOG_JDBC_PASSWORD=password | ||
| ENV REST_PORT=8181 |
There was a problem hiding this comment.
are these ENV variables acting as default values that are meant to be overridden?
There was a problem hiding this comment.
same as #11283 (comment)
| cd ../../ | ||
|
|
||
| # Build the project | ||
| ./gradlew build -x test -x integrationTest |
There was a problem hiding this comment.
can we just build the iceberg-open-api project? i know it depends on other projects in the repo, so maybe it'll just end up building everything anyways...
There was a problem hiding this comment.
Since it is a manual process, user can choose if they want to build only open api module.
I prefer clean build as most of the things are needed for this module.
Co-authored-by: Marc Cenac <547446+mrcnc@users.noreply.github.com>
depends on #11279