remove unnecessary .previousFiles(..) calls

Author: nastra

core/src/main/java/org/apache/iceberg/TableMetadata.java

@@ -410,7 +410,6 @@ public TableMetadata withUUID() {
       return ImmutableTableMetadata.builder()
           .from(this)
           .uuid(UUID.randomUUID().toString())
-          .previousFiles(addPreviousFile(metadataFileLocation(), lastUpdatedMillis()))
           .build();
     }
   }
@@ -441,7 +440,6 @@ public TableMetadata updateSchema(Schema newSchema, int newLastColumnId) {
         .schemas(builder.build())
         .specs(updatedSpecs)
         .sortOrders(updatedSortOrders)
-        .previousFiles(addPreviousFile(metadataFileLocation(), lastUpdatedMillis()))
         .build();
   }
 
@@ -482,7 +480,6 @@ public TableMetadata updatePartitionSpec(PartitionSpec newPartitionSpec) {
         .defaultSpecId(newDefaultSpecId)
         .specs(builder.build())
         .lastAssignedPartitionId(Math.max(lastAssignedPartitionId(), newPartitionSpec.lastAssignedFieldId()))
-        .previousFiles(addPreviousFile(metadataFileLocation(), lastUpdatedMillis()))
         .build();
   }
 
@@ -523,7 +520,6 @@ public TableMetadata replaceSortOrder(SortOrder newOrder) {
         .lastUpdatedMillis(System.currentTimeMillis())
         .defaultSortOrderId(newOrderId)
         .sortOrders(builder.build())
-        .previousFiles(addPreviousFile(metadataFileLocation(), lastUpdatedMillis()))
         .build();
   }
 
@@ -542,7 +538,6 @@ public TableMetadata addStagedSnapshot(Snapshot snapshot) {
         .lastSequenceNumber(snapshot.sequenceNumber())
         .lastUpdatedMillis(snapshot.timestampMillis())
         .snapshots(newSnapshots)
-        .previousFiles(addPreviousFile(metadataFileLocation(), lastUpdatedMillis()))
         .build();
   }
 
@@ -573,7 +568,6 @@ public TableMetadata replaceCurrentSnapshot(Snapshot snapshot) {
         .currentSnapshotId(snapshot.snapshotId())
         .snapshots(newSnapshots)
         .snapshotLog(newSnapshotLog)
-        .previousFiles(addPreviousFile(metadataFileLocation(), lastUpdatedMillis()))
         .build();
   }
 
@@ -608,7 +602,6 @@ public TableMetadata removeSnapshotsIf(Predicate<Snapshot> removeIf) {
         .lastUpdatedMillis(System.currentTimeMillis())
         .snapshots(filtered)
         .snapshotLog(newSnapshotLog)
-        .previousFiles(addPreviousFile(metadataFileLocation(), lastUpdatedMillis()))
         .build();
   }
 
@@ -634,7 +627,6 @@ private TableMetadata setCurrentSnapshotTo(Snapshot snapshot) {
         .lastUpdatedMillis(nowMillis)
         .currentSnapshotId(snapshot.snapshotId())
         .snapshotLog(newSnapshotLog)
-        .previousFiles(addPreviousFile(metadataFileLocation(), lastUpdatedMillis()))
         .build();
   }
 
@@ -673,7 +665,6 @@ public TableMetadata removeSnapshotLogEntries(Set<Long> snapshotIds) {
         .from(this)
         .lastUpdatedMillis(System.currentTimeMillis())
         .snapshotLog(newSnapshotLog)
-        .previousFiles(addPreviousFile(metadataFileLocation(), lastUpdatedMillis()))
         .build();
   }
 
@@ -829,7 +820,6 @@ public TableMetadata updateLocation(String newLocation) {
         .from(this)
         .location(newLocation)
         .lastUpdatedMillis(System.currentTimeMillis())
-        .previousFiles(addPreviousFile(metadataFileLocation(), lastUpdatedMillis()))
         .build();
   }
 
@@ -847,14 +837,9 @@ public TableMetadata upgradeToFormatVersion(int newFormatVersion) {
         .from(this)
         .formatVersion(newFormatVersion)
         .lastUpdatedMillis(System.currentTimeMillis())
-        .previousFiles(addPreviousFile(metadataFileLocation(), lastUpdatedMillis()))
         .build();
   }
 
-  private List<MetadataLogEntry> addPreviousFile(String previousFile, long timestampMillis) {
-    return addPreviousFile(previousFile, timestampMillis, properties());
-  }
-
   private List<MetadataLogEntry> addPreviousFile(String previousFile, long timestampMillis,
                                                  Map<String, String> updatedProperties) {
     if (previousFile == null) {

core/src/test/java/org/apache/iceberg/TestTableMetadata.java

@@ -122,7 +122,6 @@ public void testJsonConversion() throws Exception {
         .currentSnapshotId(currentSnapshotId)
         .snapshots(Arrays.asList(previousSnapshot, currentSnapshot))
         .snapshotLog(snapshotLog)
-        .previousFiles(ImmutableList.of())
         .build();
 
     String asJson = TableMetadataParser.toJson(expected);