Skip to content

feat(memory): Implement update_table for MemoryCatalog #1381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

hsingh574
Copy link

My initial motivation was to work on #1322, but for that the MemoryCatalog needs to support update_table, so this is that implementation, verified with a few basic tests.

There's more tests to add to actually complete #1322, but I wanted to add those in a separate PR. There's also some missing categories of tests (e.g. failed and successful requirements, concurrent updates, etc) that can be added on top of this.

This is my first PR in the project (and Rust as well) so looking forward to pointers.

cc: @jonathanc-n @liurenjie1024 @Xuanwo @CTTY I think you all have context.

@liurenjie1024
Copy link
Contributor

Hi, @hsingh574 Thanks for contributing. I've created #1382 to add initial support for write, which also include a framework for transaction to execute. I think it should be part of #1382

@hsingh574
Copy link
Author

Hi, @liurenjie1024 thanks for taking a look. Regarding the commit path functionality mentioned in #1382 , do you think there's anything blocking this PR? I'm also unsure about the method in TableCommit to apply changes to TableMetadata to create a new TableMetadata, seems to me the existing methods are sufficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants