Merged
Conversation
Contributor
|
@ms32035 Thank you for raising this. Can you also run |
kevinjqliu
reviewed
Feb 27, 2025
Contributor
kevinjqliu
left a comment
kevinjqliu
left a comment
There was a problem hiding this comment.
is there a way to add a unit test for this code?
Contributor
Author
Contributor
|
This is the equivalent code on the Java side of things: https://github.com/apache/iceberg/blob/a50ec923f3d928f67e2a4a361c0d1162341aa084/azure/src/main/java/org/apache/iceberg/azure/AzureProperties.java#L49C39-L49C59 We could pull out the credential parsing and test that in isolation, or mock the |
kevinjqliu
approved these changes
Mar 4, 2025
Contributor
kevinjqliu
left a comment
kevinjqliu
left a comment
There was a problem hiding this comment.
LGTM
matches the java implementation
it would be nice to mock AzureBlobFileSystem and test, but not a blocker
Fokko
pushed a commit
that referenced
this pull request
Apr 25, 2025
We observed that the property with token returned by Polaris is `adls.sas-token.<account name>` and the extra condition causes is to be ignored
gabeiglio
pushed a commit
to Netflix/iceberg-python
that referenced
this pull request
Aug 13, 2025
We observed that the property with token returned by Polaris is `adls.sas-token.<account name>` and the extra condition causes is to be ignored
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We observed that the property with token returned by Polaris is
adls.sas-token.<account name>and the extra condition causes is to be ignored