Merged
Conversation
Contributor
Author
|
I think this might be the first time we're removing deprecated functions/parameters from the library. |
Fokko
reviewed
Oct 30, 2024
Fokko
reviewed
Oct 30, 2024
kevinjqliu
force-pushed
the
kevinjqliu/deprecate-0.8.0
branch
from
bca6afe to
6e7a8d3
Compare
kevinjqliu
force-pushed
the
kevinjqliu/deprecate-0.8.0
branch
from
6e7a8d3 to
5cdba31
Compare
Fokko
approved these changes
Oct 30, 2024
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
This looks good, thanks @kevinjqliu for cleaning this up.
In a separate PR, we might want to see if we want to expose the session, as mentioned in #1104
HonahX
reviewed
Oct 31, 2024
Contributor
HonahX
left a comment
HonahX
left a comment
There was a problem hiding this comment.
@kevinjqliu Thanks for cleaning up deprecated stuff for 0.8.0! LGTM, just have one comment regarding the deprecation message in the doc.
HonahX
approved these changes
Oct 31, 2024
sungwy
pushed a commit
to sungwy/iceberg-python
that referenced
this pull request
Dec 7, 2024
* remove deprecated functions * remove deprecated properties * fix tests based on deprecated properties * update readme * get_first_property_value * deprecate properties
sungwy
pushed a commit
to sungwy/iceberg-python
that referenced
this pull request
Dec 7, 2024
* remove deprecated functions * remove deprecated properties * fix tests based on deprecated properties * update readme * get_first_property_value * deprecate properties
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Searching for `removed_in="0.8.0":
https://github.com/search?q=repo%3Aapache%2Ficeberg-python+removed_in%3D%220.8&type=code
Removed items:
DEPRECATED_PROPERTY_NAMESto_requested_schemainpyiceberg/io/pyarrow.pyadd_snapshotandset_ref_snapshotinpyiceberg/table/__init__.py