Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove old, incorrect docstring #1166

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

dataders
Copy link
Contributor

resolves: #1163

remove this line. no additions necessary as other Catalog method's don't have additional context in the docstring beyond docmenting the signature

@dataders
Copy link
Contributor Author

@sungwy couldn't find any CONTRIBUTING.md or other guidance for contributions so let me know if I'm missing anything like a changelog entry

@sungwy
Copy link
Collaborator

sungwy commented Sep 12, 2024

Hi @dataders thank you very much for identifying this issue and putting up this PR!

For future information, the Contributing guidelines can be found here: https://py.iceberg.apache.org/contributing/

For the purpose of this Issue, I think this PR looks great 👍

I'll approve it once the CI runs successfully.

@sungwy sungwy merged commit d8d509f into apache:main Sep 12, 2024
8 checks passed
@sungwy
Copy link
Collaborator

sungwy commented Sep 12, 2024

Thanks again for your contribution! @dataders

sungwy pushed a commit to sungwy/iceberg-python that referenced this pull request Dec 7, 2024
sungwy pushed a commit to sungwy/iceberg-python that referenced this pull request Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Catalog.list_tables() inconsistency between docstring and signature
2 participants