Allow setting write.parquet.page-row-limit#1017
Merged
Fokko merged 3 commits intoapache:mainfrom Aug 9, 2024
Merged
Conversation
It is being passed down to PyArrow here: https://github.com/apache/iceberg-python/blob/8aeab4951080fa196c0d29c72cba1cbba824ffc4/pyiceberg/io/pyarrow.py#L2374-L2377
…-setting-page-size
Collaborator
|
WDYT about add a test verifying that the configuration from |
Contributor
Author
|
I tried coming up with a test in two ways:
|
sungwy
approved these changes
Aug 8, 2024
sungwy
pushed a commit
that referenced
this pull request
Aug 9, 2024
* Allow setting `write.parquet.page-row-limit` It is being passed down to PyArrow here: https://github.com/apache/iceberg-python/blob/8aeab4951080fa196c0d29c72cba1cbba824ffc4/pyiceberg/io/pyarrow.py#L2374-L2377 * Update test
sungwy
pushed a commit
that referenced
this pull request
Aug 9, 2024
* Allow setting `write.parquet.page-row-limit` It is being passed down to PyArrow here: https://github.com/apache/iceberg-python/blob/8aeab4951080fa196c0d29c72cba1cbba824ffc4/pyiceberg/io/pyarrow.py#L2374-L2377 * Update test
sungwy
pushed a commit
to sungwy/iceberg-python
that referenced
this pull request
Dec 7, 2024
* Allow setting `write.parquet.page-row-limit` It is being passed down to PyArrow here: https://github.com/apache/iceberg-python/blob/8aeab4951080fa196c0d29c72cba1cbba824ffc4/pyiceberg/io/pyarrow.py#L2374-L2377 * Update test
sungwy
pushed a commit
to sungwy/iceberg-python
that referenced
this pull request
Dec 7, 2024
* Allow setting `write.parquet.page-row-limit` It is being passed down to PyArrow here: https://github.com/apache/iceberg-python/blob/8aeab4951080fa196c0d29c72cba1cbba824ffc4/pyiceberg/io/pyarrow.py#L2374-L2377 * Update test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed this when working on #1016
It is being passed down to PyArrow here:
iceberg-python/pyiceberg/io/pyarrow.py
Lines 2374 to 2377 in 8aeab49