Skip to content

Commit 8ba8693

Browse files
kevinjqliukevinjqliu
committed
ignore some rules
1 parent 230a747 commit 8ba8693

File tree

3 files changed

+24
-24
lines changed

3 files changed

+24
-24
lines changed

‎pyiceberg/expressions/visitors.py‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1228,7 +1228,7 @@ def visit_less_than(self, term: BoundTerm[L], literal: Literal[L]) -> bool:
12281228
# NaN indicates unreliable bounds. See the InclusiveMetricsEvaluator docs for more.
12291229
return ROWS_MIGHT_MATCH
12301230

1231-
if lower_bound >= literal.value:
1231+
if lower_bound >= literal.value: # type: ignore[operator]
12321232
return ROWS_CANNOT_MATCH
12331233

12341234
return ROWS_MIGHT_MATCH
@@ -1249,7 +1249,7 @@ def visit_less_than_or_equal(self, term: BoundTerm[L], literal: Literal[L]) -> b
12491249
# NaN indicates unreliable bounds. See the InclusiveMetricsEvaluator docs for more.
12501250
return ROWS_MIGHT_MATCH
12511251

1252-
if lower_bound > literal.value:
1252+
if lower_bound > literal.value: # type: ignore[operator]
12531253
return ROWS_CANNOT_MATCH
12541254

12551255
return ROWS_MIGHT_MATCH
@@ -1266,7 +1266,7 @@ def visit_greater_than(self, term: BoundTerm[L], literal: Literal[L]) -> bool:
12661266

12671267
if upper_bound_bytes := self.upper_bounds.get(field_id):
12681268
upper_bound = from_bytes(field.field_type, upper_bound_bytes)
1269-
if upper_bound <= literal.value:
1269+
if upper_bound <= literal.value: # type: ignore[operator]
12701270
if self._is_nan(upper_bound):
12711271
# NaN indicates unreliable bounds. See the InclusiveMetricsEvaluator docs for more.
12721272
return ROWS_MIGHT_MATCH
@@ -1287,7 +1287,7 @@ def visit_greater_than_or_equal(self, term: BoundTerm[L], literal: Literal[L]) -
12871287

12881288
if upper_bound_bytes := self.upper_bounds.get(field_id):
12891289
upper_bound = from_bytes(field.field_type, upper_bound_bytes)
1290-
if upper_bound < literal.value:
1290+
if upper_bound < literal.value: # type: ignore[operator]
12911291
if self._is_nan(upper_bound):
12921292
# NaN indicates unreliable bounds. See the InclusiveMetricsEvaluator docs for more.
12931293
return ROWS_MIGHT_MATCH
@@ -1312,7 +1312,7 @@ def visit_equal(self, term: BoundTerm[L], literal: Literal[L]) -> bool:
13121312
# NaN indicates unreliable bounds. See the InclusiveMetricsEvaluator docs for more.
13131313
return ROWS_MIGHT_MATCH
13141314

1315-
if lower_bound > literal.value:
1315+
if lower_bound > literal.value: # type: ignore[operator]
13161316
return ROWS_CANNOT_MATCH
13171317

13181318
if upper_bound_bytes := self.upper_bounds.get(field_id):
@@ -1321,7 +1321,7 @@ def visit_equal(self, term: BoundTerm[L], literal: Literal[L]) -> bool:
13211321
# NaN indicates unreliable bounds. See the InclusiveMetricsEvaluator docs for more.
13221322
return ROWS_MIGHT_MATCH
13231323

1324-
if upper_bound < literal.value:
1324+
if upper_bound < literal.value: # type: ignore[operator]
13251325
return ROWS_CANNOT_MATCH
13261326

13271327
return ROWS_MIGHT_MATCH
@@ -1349,7 +1349,7 @@ def visit_in(self, term: BoundTerm[L], literals: Set[L]) -> bool:
13491349
# NaN indicates unreliable bounds. See the InclusiveMetricsEvaluator docs for more.
13501350
return ROWS_MIGHT_MATCH
13511351

1352-
literals = {lit for lit in literals if lower_bound <= lit}
1352+
literals = {lit for lit in literals if lower_bound <= lit} # type: ignore[operator]
13531353
if len(literals) == 0:
13541354
return ROWS_CANNOT_MATCH
13551355

@@ -1359,7 +1359,7 @@ def visit_in(self, term: BoundTerm[L], literals: Set[L]) -> bool:
13591359
if self._is_nan(upper_bound):
13601360
return ROWS_MIGHT_MATCH
13611361

1362-
literals = {lit for lit in literals if upper_bound >= lit}
1362+
literals = {lit for lit in literals if upper_bound >= lit} # type: ignore[operator]
13631363
if len(literals) == 0:
13641364
return ROWS_CANNOT_MATCH
13651365

‎ruff.toml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ select = [
5858
"I", # isort
5959
"UP", # pyupgrade
6060
]
61-
ignore = ["E501","E203","B024","B028","UP037"]
61+
ignore = ["E501","E203","B024","B028","UP037", "UP035", "UP006"]
6262

6363
# Allow autofix for all enabled rules (when `--fix`) is provided.
6464
fixable = ["ALL"]

‎tests/expressions/test_evaluator.py‎

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -681,25 +681,25 @@ def data_file_nan() -> DataFile:
681681

682682
def test_inclusive_metrics_evaluator_less_than_and_less_than_equal(schema_data_file_nan: Schema, data_file_nan: DataFile) -> None:
683683
for operator in [LessThan, LessThanOrEqual]:
684-
should_read = _InclusiveMetricsEvaluator(schema_data_file_nan, operator("all_nan", 1)).eval(data_file_nan)
684+
should_read = _InclusiveMetricsEvaluator(schema_data_file_nan, operator("all_nan", 1)).eval(data_file_nan) # type: ignore[arg-type]
685685
assert not should_read, "Should not match: all nan column doesn't contain number"
686686

687-
should_read = _InclusiveMetricsEvaluator(schema_data_file_nan, operator("max_nan", 1)).eval(data_file_nan)
687+
should_read = _InclusiveMetricsEvaluator(schema_data_file_nan, operator("max_nan", 1)).eval(data_file_nan) # type: ignore[arg-type]
688688
assert not should_read, "Should not match: 1 is smaller than lower bound"
689689

690-
should_read = _InclusiveMetricsEvaluator(schema_data_file_nan, operator("max_nan", 10)).eval(data_file_nan)
690+
should_read = _InclusiveMetricsEvaluator(schema_data_file_nan, operator("max_nan", 10)).eval(data_file_nan) # type: ignore[arg-type]
691691
assert should_read, "Should match: 10 is larger than lower bound"
692692

693-
should_read = _InclusiveMetricsEvaluator(schema_data_file_nan, operator("min_max_nan", 1)).eval(data_file_nan)
693+
should_read = _InclusiveMetricsEvaluator(schema_data_file_nan, operator("min_max_nan", 1)).eval(data_file_nan) # type: ignore[arg-type]
694694
assert should_read, "Should match: no visibility"
695695

696-
should_read = _InclusiveMetricsEvaluator(schema_data_file_nan, operator("all_nan_null_bounds", 1)).eval(data_file_nan)
696+
should_read = _InclusiveMetricsEvaluator(schema_data_file_nan, operator("all_nan_null_bounds", 1)).eval(data_file_nan) # type: ignore[arg-type]
697697
assert not should_read, "Should not match: all nan column doesn't contain number"
698698

699-
should_read = _InclusiveMetricsEvaluator(schema_data_file_nan, operator("some_nan_correct_bounds", 1)).eval(data_file_nan)
699+
should_read = _InclusiveMetricsEvaluator(schema_data_file_nan, operator("some_nan_correct_bounds", 1)).eval(data_file_nan) # type: ignore[arg-type]
700700
assert not should_read, "Should not match: 1 is smaller than lower bound"
701701

702-
should_read = _InclusiveMetricsEvaluator(schema_data_file_nan, operator("some_nan_correct_bounds", 10)).eval(
702+
should_read = _InclusiveMetricsEvaluator(schema_data_file_nan, operator("some_nan_correct_bounds", 10)).eval( # type: ignore[arg-type]
703703
data_file_nan
704704
)
705705
assert should_read, "Should match: 10 larger than lower bound"
@@ -709,30 +709,30 @@ def test_inclusive_metrics_evaluator_greater_than_and_greater_than_equal(
709709
schema_data_file_nan: Schema, data_file_nan: DataFile
710710
) -> None:
711711
for operator in [GreaterThan, GreaterThanOrEqual]:
712-
should_read = _InclusiveMetricsEvaluator(schema_data_file_nan, operator("all_nan", 1)).eval(data_file_nan)
712+
should_read = _InclusiveMetricsEvaluator(schema_data_file_nan, operator("all_nan", 1)).eval(data_file_nan) # type: ignore[arg-type]
713713
assert not should_read, "Should not match: all nan column doesn't contain number"
714714

715-
should_read = _InclusiveMetricsEvaluator(schema_data_file_nan, operator("max_nan", 1)).eval(data_file_nan)
715+
should_read = _InclusiveMetricsEvaluator(schema_data_file_nan, operator("max_nan", 1)).eval(data_file_nan) # type: ignore[arg-type]
716716
assert should_read, "Should match: upper bound is larger than 1"
717717

718-
should_read = _InclusiveMetricsEvaluator(schema_data_file_nan, operator("max_nan", 10)).eval(data_file_nan)
718+
should_read = _InclusiveMetricsEvaluator(schema_data_file_nan, operator("max_nan", 10)).eval(data_file_nan) # type: ignore[arg-type]
719719
assert should_read, "Should match: upper bound is larger than 10"
720720

721-
should_read = _InclusiveMetricsEvaluator(schema_data_file_nan, operator("min_max_nan", 1)).eval(data_file_nan)
721+
should_read = _InclusiveMetricsEvaluator(schema_data_file_nan, operator("min_max_nan", 1)).eval(data_file_nan) # type: ignore[arg-type]
722722
assert should_read, "Should match: no visibility"
723723

724-
should_read = _InclusiveMetricsEvaluator(schema_data_file_nan, operator("all_nan_null_bounds", 1)).eval(data_file_nan)
724+
should_read = _InclusiveMetricsEvaluator(schema_data_file_nan, operator("all_nan_null_bounds", 1)).eval(data_file_nan) # type: ignore[arg-type]
725725
assert not should_read, "Should not match: all nan column doesn't contain number"
726726

727-
should_read = _InclusiveMetricsEvaluator(schema_data_file_nan, operator("some_nan_correct_bounds", 1)).eval(data_file_nan)
727+
should_read = _InclusiveMetricsEvaluator(schema_data_file_nan, operator("some_nan_correct_bounds", 1)).eval(data_file_nan) # type: ignore[arg-type]
728728
assert should_read, "Should match: 1 is smaller than upper bound"
729729

730-
should_read = _InclusiveMetricsEvaluator(schema_data_file_nan, operator("some_nan_correct_bounds", 10)).eval(
730+
should_read = _InclusiveMetricsEvaluator(schema_data_file_nan, operator("some_nan_correct_bounds", 10)).eval( # type: ignore[arg-type]
731731
data_file_nan
732732
)
733733
assert should_read, "Should match: 10 is smaller than upper bound"
734734

735-
should_read = _InclusiveMetricsEvaluator(schema_data_file_nan, operator("all_nan", 30)).eval(data_file_nan)
735+
should_read = _InclusiveMetricsEvaluator(schema_data_file_nan, operator("all_nan", 30)).eval(data_file_nan) # type: ignore[arg-type]
736736
assert not should_read, "Should not match: 30 is greater than upper bound"
737737

738738

0 commit comments

Comments
 (0)