test error for none

Author: kevinjqliu

tests/integration/test_reads.py

@@ -24,6 +24,7 @@
 import pytest
 from hive_metastore.ttypes import LockRequest, LockResponse, LockState, UnlockRequest
 from pyarrow.fs import S3FileSystem
+from pydantic_core import ValidationError
 
 from pyiceberg.catalog import Catalog, load_catalog
 from pyiceberg.catalog.hive import HiveCatalog, _HiveClient
@@ -122,6 +123,10 @@ def test_table_properties(catalog: Catalog) -> None:
     table = table.transaction().set_properties(abc=123).commit_transaction()
     assert table.properties == dict(abc="123", **DEFAULT_PROPERTIES)
 
+    with pytest.raises(ValidationError) as exc_info:
+        table.transaction().set_properties(property_name=None).commit_transaction()
+    assert "None type is not a supported value in properties: property_name" in str(exc_info.value)
+
 
 @pytest.mark.integration
 @pytest.mark.parametrize('catalog', [pytest.lazy_fixture('catalog_hive'), pytest.lazy_fixture('catalog_rest')])
@@ -147,6 +152,10 @@ def test_table_properties_dict(catalog: Catalog) -> None:
     table = table.transaction().set_properties({"abc": 123}).commit_transaction()
     assert table.properties == dict({"abc": "123"}, **DEFAULT_PROPERTIES)
 
+    with pytest.raises(ValidationError) as exc_info:
+        table.transaction().set_properties({"property_name": None}).commit_transaction()
+    assert "None type is not a supported value in properties: property_name" in str(exc_info.value)
+
 
 @pytest.mark.integration
 @pytest.mark.parametrize('catalog', [pytest.lazy_fixture('catalog_hive'), pytest.lazy_fixture('catalog_rest')])