Skip to content

Commit 59cdf33

Browse files
authored
fix: Add Cython build step to Makefile (#2869)
# Rationale for this change Currently, uv sync is building the Cython extensions on first install. After running `make clean` (which deletes .so files), subsequent uv sync does not rebuild them, causing: ``` ModuleNotFoundError: No module named 'pyiceberg.avro.decoder_fast' ``` This seems to be related to some known uv behavior: astral-sh/uv#12399. The `--reinstall` flag forces uv to rebuild the package and its extensions. > Note: CI works because it always starts fresh. Local dev breaks after make clean. ## Are these changes tested? `make clean && make test` ## Are there any user-facing changes? new make target
1 parent b0a7878 commit 59cdf33

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ setup-venv: ## Create virtual environment
7070
uv venv $(PYTHON_ARG)
7171

7272
install-dependencies: setup-venv ## Install all dependencies including extras
73-
uv sync $(PYTHON_ARG) --all-extras
73+
uv sync $(PYTHON_ARG) --all-extras --reinstall
7474

7575
install: install-uv install-dependencies ## Install uv and dependencies
7676

0 commit comments

Comments
 (0)