Skip to content

Commit 242f414

Browse files
Redesign replace_table catalog-behavior tests to mirror iceberg-java
Audited the previous 18 narrow tests against Java's CatalogTests.java and rewrote as 13 denser tests that cover what was missing — snapshot identity preservation (not just count), snapshot_log carry-forward, schemas/specs/sort-orders history accumulation, time-travel reads of pre-replace data — and fold orthogonal one-liners into parametrized or composed tests where the original split was incidental. Net: -207 lines / +184 lines / -5 tests. Parametrized to 169 cases. Highlights of the new layout: - test_replace_transaction (base case + time-travel) - test_complete_replace_transaction (all six args + RTAS + property merge) - test_replace_table_identifier_field_ids (parametrized preserve/drop) - test_replace_table_partition_field_carry_forward (parametrized v1/v2) - test_replace_table_location (parametrized inherit/explicit/slash) - test_concurrent_replace_transaction_schema_conflict + ..._partition_spec_conflict Names follow Java's testReplaceTransaction* naming where applicable, PEP-8 cased. No cross-impl references in the test file itself.
1 parent 80c3c65 commit 242f414

1 file changed

Lines changed: 184 additions & 207 deletions

File tree

0 commit comments

Comments
 (0)