Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integration test support env filter #811

Merged
merged 2 commits into from
Apr 7, 2023

Conversation

jiacai2050
Copy link
Contributor

Which issue does this PR close?

Closes #

Rationale for this change

Run all tests in local env is time-consuming, so add this filter.

What changes are included in this PR?

  • Add env_filter in integration tests.

Are there any user-facing changes?

No

How does this change test

Manually

Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about add a target called run-local in the integration tests Makefile?

@jiacai2050
Copy link
Contributor Author

done

Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiKaiWi ShiKaiWi added this pull request to the merge queue Apr 7, 2023
Merged via the queue into apache:main with commit 65131eb Apr 7, 2023
@jiacai2050 jiacai2050 deleted the feat-env-filter branch April 7, 2023 11:26
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
* feat: integration test support env filter

* fix CR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants