Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: define remote table engine trait #502

Merged
merged 1 commit into from
Dec 22, 2022

Conversation

Rachelint
Copy link
Contributor

Which issue does this PR close?

Closes #
Part of #492

Rationale for this change

See #492.
We need to read/write the remote table engine.

What changes are included in this PR?

  • define the remote table engine trait

Are there any user-facing changes?

None.

How does this change test

Not need now.

@Rachelint Rachelint force-pushed the remote-engine branch 2 times, most recently from aa209ee to ecc5335 Compare December 21, 2022 15:36
@Rachelint Rachelint marked this pull request as ready for review December 21, 2022 15:40
@Rachelint Rachelint changed the title feat: remote table engine feat: define remote table engine trait Dec 21, 2022
remote_engine/Cargo.toml Outdated Show resolved Hide resolved
remote_engine/src/mock_impl.rs Outdated Show resolved Hide resolved
remote_engine/src/model.rs Outdated Show resolved Hide resolved
Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunshao90 chunshao90 merged commit 61f9250 into apache:main Dec 22, 2022
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
@Rachelint Rachelint deleted the remote-engine branch May 27, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants