Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue: streaming building/reading SST #735

Closed
2 tasks done
ShiKaiWi opened this issue Mar 15, 2023 · 4 comments · Fixed by #759
Closed
2 tasks done

Tracking issue: streaming building/reading SST #735

ShiKaiWi opened this issue Mar 15, 2023 · 4 comments · Fixed by #759
Assignees
Labels
feature New feature or request

Comments

@ShiKaiWi
Copy link
Member

ShiKaiWi commented Mar 15, 2023

Describe This Problem

Current building/reading SST is not in a streaming way, that is to say, all the content will be buffered in the memory before dumping into the underlying storage for building procedure and all the content will be fetched into memory before feeding to the upside merge iterators. Such way to bulid/read sst may lead to high memory consumption.

Proposal

Additional Context

@ShiKaiWi ShiKaiWi added the feature New feature or request label Mar 15, 2023
@ShiKaiWi ShiKaiWi self-assigned this Mar 15, 2023
@jiacai2050
Copy link
Contributor

Write is duplicated with #486

@jiacai2050
Copy link
Contributor

The hard part of this new procedure is partial failure, how will you record partial failed tasks to avoid leave temp files?

@ShiKaiWi
Copy link
Member Author

Write is duplicated with #486

Ok. #486 has been linked to this tracking issue as one sub task issue.

@ShiKaiWi ShiKaiWi changed the title Support streaming building/reading SST Tracking issue: streaming building/reading SST Mar 15, 2023
@ShiKaiWi
Copy link
Member Author

The hard part of this new procedure is partial failure, how will you record partial failed tasks to avoid leave temp files?

Do clearing jobs, e.g. removing temp files or abort multipart upload, in the drop method. As for the leaked temp files, I guess we can just let it go for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants