From d940b72affc3c1e62050f8c4b5917f16f329ca5f Mon Sep 17 00:00:00 2001 From: "chunshao.rcs" Date: Tue, 7 Feb 2023 15:00:57 +0800 Subject: [PATCH] refactor code --- common_types/src/schema.rs | 1 - interpreters/src/insert.rs | 24 ++---------------------- 2 files changed, 2 insertions(+), 23 deletions(-) diff --git a/common_types/src/schema.rs b/common_types/src/schema.rs index 9a524a8613..c86790ebaa 100644 --- a/common_types/src/schema.rs +++ b/common_types/src/schema.rs @@ -478,7 +478,6 @@ impl TryFrom for RecordSchema { fn try_from(arrow_schema: ArrowSchemaRef) -> Result { let fields = arrow_schema.fields(); - println!("fields {:?}", fields); let mut columns = Vec::with_capacity(fields.len()); for field in fields { diff --git a/interpreters/src/insert.rs b/interpreters/src/insert.rs index 7e69b5f8b1..a1ae020653 100644 --- a/interpreters/src/insert.rs +++ b/interpreters/src/insert.rs @@ -26,8 +26,8 @@ use datafusion::{ create_physical_expr, execution_props::ExecutionProps, expressions::TryCastExpr, }, }; -use datafusion_expr::{expr::Expr as DfLogicalExpr, Expr}; -use datafusion_optimizer::simplify_expressions::{ExprSimplifier, SimplifyContext, SimplifyInfo}; +use datafusion_expr::{expr::Expr as DfLogicalExpr}; +use datafusion_optimizer::simplify_expressions::{ExprSimplifier, SimplifyContext}; use df_operator::visitor::find_columns_by_expr; use snafu::{OptionExt, ResultExt, Snafu}; use sql::plan::InsertPlan; @@ -198,26 +198,6 @@ impl<'a> TsidBuilder<'a> { } } -// Copy from https://github.com/apache/arrow-datafusion/blob/125a8580c19c78c99fbbe3a6afe373de2538b205/datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs#L78. -#[derive(Default)] -struct Info { - execution_props: ExecutionProps, -} - -impl SimplifyInfo for Info { - fn is_boolean_type(&self, _expr: &Expr) -> datafusion::common::Result { - Ok(false) - } - - fn nullable(&self, _expr: &Expr) -> datafusion::common::Result { - Ok(true) - } - - fn execution_props(&self) -> &ExecutionProps { - &self.execution_props - } -} - /// Fill missing columns which can be calculated via default value expr. fn fill_default_values( table: TableRef,