Skip to content

HBASE-29377 ChaosService support for custom ports in zookeeper quorum #7072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2025

Conversation

macmaster
Copy link
Contributor

Full description of bug can be found in https://issues.apache.org/jira/browse/HBASE-29377

Switches the ChaosService to rely on the ZKConfig convention used elsewhere and deprecates the unnecessary ChaosUtils class.

@macmaster macmaster marked this pull request as draft June 4, 2025 22:35
@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

Copy link
Contributor

@lokiore lokiore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks

@macmaster macmaster marked this pull request as ready for review June 9, 2025 15:45
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 39s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 4m 14s master passed
+1 💚 compile 0m 33s master passed
+1 💚 javadoc 0m 19s master passed
+1 💚 shadedjars 7m 20s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 4m 7s the patch passed
+1 💚 compile 0m 24s the patch passed
+1 💚 javac 0m 24s the patch passed
+1 💚 javadoc 0m 14s the patch passed
+1 💚 shadedjars 7m 29s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 0m 55s hbase-it in the patch passed.
27m 16s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7072/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #7072
Optional Tests javac javadoc unit compile shadedjars
uname Linux a52310eaf59e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 7873eb2
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7072/2/testReport/
Max. process+thread count 629 (vs. ulimit of 30000)
modules C: hbase-it U: hbase-it
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7072/2/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 27s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+1 💚 mvninstall 3m 20s master passed
+1 💚 compile 0m 32s master passed
+1 💚 checkstyle 0m 11s master passed
+1 💚 spotbugs 0m 23s master passed
+1 💚 spotless 0m 50s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 1s the patch passed
+1 💚 compile 0m 30s the patch passed
-0 ⚠️ javac 0m 30s /results-compile-javac-hbase-it.txt hbase-it generated 1 new + 96 unchanged - 1 fixed = 97 total (was 97)
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 10s hbase-it: The patch generated 0 new + 2 unchanged - 1 fixed = 2 total (was 3)
+1 💚 spotbugs 0m 30s the patch passed
+1 💚 hadoopcheck 12m 8s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚 spotless 0m 45s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 10s The patch does not generate ASF License warnings.
30m 27s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7072/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #7072
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 50d71a978873 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 7873eb2
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 86 (vs. ulimit of 30000)
modules C: hbase-it U: hbase-it
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7072/2/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@mnpoonia mnpoonia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks. Aligned with original approach

Copy link
Contributor

@taklwu taklwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taklwu taklwu merged commit e1d8279 into apache:master Jun 10, 2025
1 check passed
macmaster added a commit to macmaster/hbase that referenced this pull request Jun 12, 2025
…apache#7072)

Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>
Reviewed-by: Aman Poonia <aman.poonia.29@gmail.com>
Reviewed-by: Lokesh Khurana <khuranalokesh07@gmail.com>
Co-authored-by: rmacmaster <rmacmaster@bloomberg.net>
macmaster added a commit to macmaster/hbase that referenced this pull request Jun 12, 2025
…apache#7072)

Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>
Reviewed-by: Aman Poonia <aman.poonia.29@gmail.com>
Reviewed-by: Lokesh Khurana <khuranalokesh07@gmail.com>
Co-authored-by: rmacmaster <rmacmaster@bloomberg.net>
taklwu pushed a commit that referenced this pull request Jun 13, 2025
…#7072) (#7097)

Reviewed-by: Aman Poonia <aman.poonia.29@gmail.com>
Reviewed-by: Lokesh Khurana <khuranalokesh07@gmail.com>

Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>
Co-authored-by: rmacmaster <rmacmaster@bloomberg.net>
taklwu pushed a commit that referenced this pull request Jun 13, 2025
…#7072) (#7098)

Reviewed-by: Aman Poonia <aman.poonia.29@gmail.com>
Reviewed-by: Lokesh Khurana <khuranalokesh07@gmail.com>

Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>
Co-authored-by: rmacmaster <rmacmaster@bloomberg.net>
taklwu pushed a commit that referenced this pull request Jun 13, 2025
…#7072) (#7099)

Reviewed-by: Aman Poonia <aman.poonia.29@gmail.com>
Reviewed-by: Lokesh Khurana <khuranalokesh07@gmail.com>

Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>
Co-authored-by: rmacmaster <rmacmaster@bloomberg.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants