-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-29377 ChaosService support for custom ports in zookeeper quorum #7072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks. Aligned with original approach
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…apache#7072) Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org> Reviewed-by: Aman Poonia <aman.poonia.29@gmail.com> Reviewed-by: Lokesh Khurana <khuranalokesh07@gmail.com> Co-authored-by: rmacmaster <rmacmaster@bloomberg.net>
…apache#7072) Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org> Reviewed-by: Aman Poonia <aman.poonia.29@gmail.com> Reviewed-by: Lokesh Khurana <khuranalokesh07@gmail.com> Co-authored-by: rmacmaster <rmacmaster@bloomberg.net>
Full description of bug can be found in https://issues.apache.org/jira/browse/HBASE-29377
Switches the ChaosService to rely on the ZKConfig convention used elsewhere and deprecates the unnecessary ChaosUtils class.