Skip to content

HBASE-28900: Avoid resetting the bucket cache during recovery from persistence. (#6360) #6365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2024
Merged

HBASE-28900: Avoid resetting the bucket cache during recovery from persistence. (#6360) #6365

merged 1 commit into from
Oct 15, 2024

Conversation

jhungund
Copy link
Contributor

Backport the fix of HBASE-28900 to branch-2.

@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@jhungund
HBASE-28900: Avoid resetting the bucket cache during recovery from pe…
968aa56 
…rsistence. (apache#6360)

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Change-Id: If7e7a76723cf7d2d6e8c9e2ce0aeccfdba81c0bb
@jhungund jhungund force-pushed the branch-2-for-HBASE-28900 branch from 2f750ad to 968aa56 Compare October 15, 2024 03:13
@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 0s Docker mode activated.
-1 ❌ docker 0m 6s Docker failed to build run-specific yetus/hbase:tp-6445}.
Subsystem Report/Notes
GITHUB PR #6365
JIRA Issue HBASE-28900
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6365/2/console
versions git=2.25.1
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 25s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ branch-2 Compile Tests _
+1 💚 mvninstall 4m 34s branch-2 passed
+1 💚 compile 4m 0s branch-2 passed
+1 💚 checkstyle 0m 42s branch-2 passed
+1 💚 spotbugs 1m 56s branch-2 passed
+1 💚 spotless 0m 53s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚 mvninstall 4m 22s the patch passed
+1 💚 compile 3m 46s the patch passed
+1 💚 javac 3m 46s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 45s hbase-server: The patch generated 0 new + 25 unchanged - 1 fixed = 25 total (was 26)
+1 💚 spotbugs 2m 0s the patch passed
+1 💚 hadoopcheck 23m 50s Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.
+1 💚 spotless 0m 55s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 12s The patch does not generate ASF License warnings.
50m 12s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6365/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #6365
JIRA Issue HBASE-28900
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux e2ee75349da3 5.4.0-192-generic #212-Ubuntu SMP Fri Jul 5 09:47:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 968aa56
Default Java Eclipse Adoptium-11.0.23+9
Max. process+thread count 79 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6365/2/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 25s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚 mvninstall 4m 36s branch-2 passed
+1 💚 compile 1m 19s branch-2 passed
+1 💚 javadoc 0m 35s branch-2 passed
+1 💚 shadedjars 6m 47s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 4m 22s the patch passed
+1 💚 compile 1m 11s the patch passed
+1 💚 javac 1m 11s the patch passed
-0 ⚠️ javadoc 0m 33s /results-javadoc-javadoc-hbase-server.txt hbase-server generated 7 new + 44 unchanged - 0 fixed = 51 total (was 44)
+1 💚 shadedjars 6m 33s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 214m 53s hbase-server in the patch passed.
245m 57s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6365/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #6365
JIRA Issue HBASE-28900
Optional Tests javac javadoc unit compile shadedjars
uname Linux b2f63a019c06 5.4.0-192-generic #212-Ubuntu SMP Fri Jul 5 09:47:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 968aa56
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6365/2/testReport/
Max. process+thread count 4954 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6365/2/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 41s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚 mvninstall 2m 39s branch-2 passed
+1 💚 compile 0m 41s branch-2 passed
+1 💚 javadoc 0m 26s branch-2 passed
+1 💚 shadedjars 5m 15s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 2m 26s the patch passed
+1 💚 compile 0m 41s the patch passed
+1 💚 javac 0m 41s the patch passed
-0 ⚠️ javadoc 0m 23s /results-javadoc-javadoc-hbase-server.txt hbase-server generated 4 new + 21 unchanged - 0 fixed = 25 total (was 21)
+1 💚 shadedjars 5m 13s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌ unit 233m 3s /patch-unit-hbase-server.txt hbase-server in the patch failed.
255m 57s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6365/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #6365
JIRA Issue HBASE-28900
Optional Tests javac javadoc unit compile shadedjars
uname Linux 03c4dbb51064 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 968aa56
Default Java Temurin-1.8.0_412-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6365/2/testReport/
Max. process+thread count 4294 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6365/2/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@wchevreuil wchevreuil merged commit 47536f4 into apache:branch-2 Oct 15, 2024
1 check failed
wchevreuil pushed a commit that referenced this pull request Oct 15, 2024
@jhungund @wchevreuil
HBASE-28900: Avoid resetting the bucket cache during recovery from pe…
15e4705 
…rsistence. (#6360) (#6365)

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wchevreuil wchevreuil wchevreuil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhungund @Apache-HBase @wchevreuil