HBASE-28842: Fix TestRequestAttributes test to fail when it should #6255

eab148 · 2024-09-16T22:46:18Z

The tests in the TestRequestAttributes class pass even when they should fail. Throw an IOException in the AttributesCoprocessor when the map of expected request attributes does not match the map of given request attributes.

HBASE-28842

I discovered this bug when backporting HBASE-28001 tobranch-2 #6246

eab148 · 2024-09-16T22:46:45Z

cc @ndimiduk

eab148 · 2024-09-17T03:52:42Z

It seems like the spotless check failed due to a transient error

[ERROR] An internal error occurred during: "Periodic workspace save.".
java.lang.IllegalStateException: Job manager has been shut down.
    at org.eclipse.core.internal.jobs.JobManager.schedule (JobManager.java:1295)
    at org.eclipse.core.internal.jobs.InternalJob.schedule (InternalJob.java:385)
    at org.eclipse.core.runtime.jobs.Job.schedule (Job.java:684)
    at org.eclipse.core.internal.events.AutoBuildJob.build (AutoBuildJob.java:110)
    at org.eclipse.core.internal.events.BuildManager.endTopLevel (BuildManager.java:604)
    at org.eclipse.core.internal.resources.Workspace.endOperation (Workspace.java:1518)
    at org.eclipse.core.internal.resources.SaveManager.save (SaveManager.java:1246)
    at org.eclipse.core.internal.resources.SaveManager.save (SaveManager.java:1143)
    at org.eclipse.core.internal.resources.DelayedSnapshotJob.run (DelayedSnapshotJob.java:55)
    at org.eclipse.core.internal.jobs.Worker.run (Worker.java:63)

ndimiduk

Oops. Good Catch.

ndimiduk · 2024-09-17T08:17:36Z

Prompting the buildbot to have another go.

Apache-HBase · 2024-09-17T08:51:21Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 35s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+1 💚	mvninstall	2m 59s		master passed
+1 💚	compile	3m 6s		master passed
+1 💚	checkstyle	0m 38s		master passed
+1 💚	spotbugs	1m 38s		master passed
+1 💚	spotless	0m 45s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 💚	mvninstall	2m 59s		the patch passed
+1 💚	compile	3m 3s		the patch passed
+1 💚	javac	3m 3s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 38s		the patch passed
+1 💚	spotbugs	1m 42s		the patch passed
+1 💚	hadoopcheck	10m 36s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚	spotless	0m 46s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 8s		The patch does not generate ASF License warnings.
		36m 19s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6255/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6255
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux 80bcb87f11d6 5.4.0-192-generic #212-Ubuntu SMP Fri Jul 5 09:47:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `6764e56`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	83 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6255/2/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-09-17T12:31:54Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	3m 38s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+1 💚	mvninstall	3m 11s		master passed
+1 💚	compile	0m 57s		master passed
+1 💚	javadoc	0m 30s		master passed
+1 💚	shadedjars	5m 23s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 0s		the patch passed
+1 💚	compile	0m 58s		the patch passed
+1 💚	javac	0m 58s		the patch passed
+1 💚	javadoc	0m 30s		the patch passed
+1 💚	shadedjars	5m 20s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	228m 52s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
		256m 57s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6255/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6255
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux d6605d6d45c1 5.4.0-192-generic #212-Ubuntu SMP Fri Jul 5 09:47:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `6764e56`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6255/2/testReport/
Max. process+thread count	6125 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6255/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

rmdmattingly

Nice catch. Seems like we hit one more unrelated test failure, so I've kicked off another build.

eab148 · 2024-09-17T13:53:50Z

Thanks @rmdmattingly!

Apache-HBase · 2024-09-17T14:10:23Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 36s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+1 💚	mvninstall	3m 9s		master passed
+1 💚	compile	3m 7s		master passed
+1 💚	checkstyle	0m 40s		master passed
+1 💚	spotbugs	1m 41s		master passed
+1 💚	spotless	0m 48s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 💚	mvninstall	4m 26s		the patch passed
+1 💚	compile	4m 6s		the patch passed
+1 💚	javac	4m 6s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 44s		the patch passed
+1 💚	spotbugs	2m 2s		the patch passed
+1 💚	hadoopcheck	14m 7s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚	spotless	0m 58s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 15s		The patch does not generate ASF License warnings.
		44m 15s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6255/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6255
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux 3297123056be 5.4.0-192-generic #212-Ubuntu SMP Fri Jul 5 09:47:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `6764e56`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	84 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6255/3/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-09-17T17:24:57Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 28s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+1 💚	mvninstall	3m 18s		master passed
+1 💚	compile	1m 2s		master passed
+1 💚	javadoc	0m 30s		master passed
+1 💚	shadedjars	5m 51s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 7s		the patch passed
+1 💚	compile	0m 59s		the patch passed
+1 💚	javac	0m 59s		the patch passed
+1 💚	javadoc	0m 28s		the patch passed
+1 💚	shadedjars	5m 49s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	213m 37s		hbase-server in the patch passed.
		238m 55s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6255/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6255
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux bb33370af064 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `6764e56`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6255/3/testReport/
Max. process+thread count	5048 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6255/3/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

This reverts commit b3f2f40. The commit message was improperly formatted, so I will be resubmitting the commit with correct messaging.

Co-authored-by: Evie Boland <eboland@hubspot.com> Signed-off-by: Ray Mattingly <rmattingly@apache.org> Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>

…6268) Signed-off-by: Ray Mattingly <rmattingly@apache.org> Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Co-authored-by: eab148 <54775485+eab148@users.noreply.github.com> Co-authored-by: Evie Boland <eboland@hubspot.com>

…6267) Signed-off-by: Ray Mattingly <rmattingly@apache.org> Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Co-authored-by: eab148 <54775485+eab148@users.noreply.github.com> Co-authored-by: Evie Boland <eboland@hubspot.com>

…6268) Signed-off-by: Ray Mattingly <rmattingly@apache.org> Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Co-authored-by: eab148 <54775485+eab148@users.noreply.github.com> Co-authored-by: Evie Boland <eboland@hubspot.com>

…6287) Signed-off-by: Ray Mattingly <rmattingly@apache.org> Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Co-authored-by: eab148 <54775485+eab148@users.noreply.github.com> Co-authored-by: Evie Boland <eboland@hubspot.com>

…expected (apache#6255) (apache#6287) Signed-off-by: Ray Mattingly <rmattingly@apache.org> Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Co-authored-by: eab148 <54775485+eab148@users.noreply.github.com> Co-authored-by: Evie Boland <eboland@hubspot.com>

…pache#6255) (apache#6287)" This reverts commit 6fda6b2.

…expected (apache#6255) (apache#6287) (#117) Signed-off-by: Ray Mattingly <rmattingly@apache.org> Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Co-authored-by: Ray Mattingly <rmattingly@apache.org> Co-authored-by: Evie Boland <eboland@hubspot.com>

…expected (apache#6255) (apache#6287) (#119) Signed-off-by: Ray Mattingly <rmattingly@apache.org> Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Co-authored-by: Ray Mattingly <rmattingly@apache.org> Co-authored-by: Evie Boland <eboland@hubspot.com>

Fix test so that it fails when it should

6764e56

This comment has been minimized.

Sign in to view

ndimiduk approved these changes Sep 17, 2024

View reviewed changes

rmdmattingly approved these changes Sep 17, 2024

View reviewed changes

rmdmattingly merged commit b3f2f40 into apache:master Sep 18, 2024
1 check passed

rmdmattingly deleted the HBASE-28842 branch September 18, 2024 19:43

rmdmattingly pushed a commit that referenced this pull request Sep 18, 2024

Revert "Fix test so that it fails when it should (#6255)"

b2e84d6

This reverts commit b3f2f40. The commit message was improperly formatted, so I will be resubmitting the commit with correct messaging.

ndimiduk added a commit to ndimiduk/hbase that referenced this pull request Oct 4, 2024

Revert "HBASE-28842 TestRequestAttributes should fail when expected (a…

12e4d4d

…pache#6255) (apache#6287)" This reverts commit 6fda6b2.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HBASE-28842: Fix TestRequestAttributes test to fail when it should #6255

HBASE-28842: Fix TestRequestAttributes test to fail when it should #6255

Uh oh!

eab148 commented Sep 16, 2024

Uh oh!

eab148 commented Sep 16, 2024

Uh oh!

This comment has been minimized.

This comment has been minimized.

eab148 commented Sep 17, 2024

Uh oh!

ndimiduk left a comment

Uh oh!

ndimiduk commented Sep 17, 2024

Uh oh!

Apache-HBase commented Sep 17, 2024

Uh oh!

Apache-HBase commented Sep 17, 2024

Uh oh!

rmdmattingly left a comment •

edited

Loading

Uh oh!

eab148 commented Sep 17, 2024

Uh oh!

Apache-HBase commented Sep 17, 2024

Uh oh!

Apache-HBase commented Sep 17, 2024

Uh oh!

Uh oh!

Uh oh!

HBASE-28842: Fix TestRequestAttributes test to fail when it should #6255

HBASE-28842: Fix TestRequestAttributes test to fail when it should #6255

Uh oh!

Conversation

eab148 commented Sep 16, 2024

Uh oh!

eab148 commented Sep 16, 2024

Uh oh!

This comment has been minimized.

This comment has been minimized.

eab148 commented Sep 17, 2024

Uh oh!

ndimiduk left a comment

Choose a reason for hiding this comment

Uh oh!

ndimiduk commented Sep 17, 2024

Uh oh!

Apache-HBase commented Sep 17, 2024

Uh oh!

Apache-HBase commented Sep 17, 2024

Uh oh!

rmdmattingly left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eab148 commented Sep 17, 2024

Uh oh!

Apache-HBase commented Sep 17, 2024

Uh oh!

Apache-HBase commented Sep 17, 2024

Uh oh!

Uh oh!

Uh oh!

rmdmattingly left a comment •

edited

Loading