Skip to content

HBASE-28754 verify the first argument passed to compaction_switch #6119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 26, 2025
Merged

HBASE-28754 verify the first argument passed to compaction_switch #6119

merged 5 commits into from
Mar 26, 2025

Conversation

ether1984
Copy link
Contributor

Sometimes, users may inadvertently attempt to use compaction_switch; therefore, it is advisable to implement a verification step for the first argument passed to this function, ensuring that incorrect inputs do not accidentally disable compaction.

@ether1984
Update admin.rb
1c649da 
Verify the first argument passed to compaction_switch to prevent incorrect inputs from accidentally disabling compaction.
@ether1984 ether1984 changed the title verify the first argument passed to compaction_switch HBASE-6028 verify the first argument passed to compaction_switch Jul 24, 2024
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache9
Copy link
Contributor

Apache9 commented Jul 27, 2024

Is this the correct jira issue number?

guluo2016
guluo2016 reviewed Jul 27, 2024
View reviewed changes
@ether1984 ether1984 changed the title HBASE-6028 verify the first argument passed to compaction_switch HBASE-28754 verify the first argument passed to compaction_switch Jul 27, 2024
@ether1984
Copy link
Contributor Author

Is this the correct jira issue number?
I made a mistake the correct jira issue is:
https://issues.apache.org/jira/browse/HBASE-28754

@ether1984
Update admin.rb
5e4289b 
change error message from compactionSwitch to compaction_switch
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache9
Copy link
Contributor

Apache9 commented Jul 30, 2024

Can we add a UT to verify the added code actually works?

Thanks.

@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@ether1984
Copy link
Contributor Author

Can we add a UT to verify the added code actually works?

Thanks.

@Apache9 UT has been added. The UT verifies both illegal and correct arguments, and returns the expected result.
Thanks for your review

@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache9
Copy link
Contributor

Apache9 commented Nov 21, 2024

Missed this one.

Let me kick the pre commit again.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 28s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 3m 3s master passed
+1 💚 spotless 0m 42s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚 mvninstall 2m 48s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ rubocop 0m 18s /results-rubocop.txt The patch generated 3 new + 750 unchanged - 0 fixed = 753 total (was 750)
+1 💚 spotless 0m 40s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 9s The patch does not generate ASF License warnings.
9m 24s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6119/7/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #6119
Optional Tests dupname asflicense javac codespell detsecrets rubocop spotless
uname Linux c9fd302d2812 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 107d5db
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 82 (vs. ulimit of 30000)
modules C: hbase-shell U: hbase-shell
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6119/7/console
versions git=2.34.1 maven=3.9.8 rubocop=1.37.1
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 35s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 3m 0s master passed
+1 💚 javadoc 0m 13s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 55s the patch passed
+1 💚 javadoc 0m 12s the patch passed
_ Other Tests _
+1 💚 unit 7m 1s hbase-shell in the patch passed.
14m 47s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6119/7/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #6119
Optional Tests javac javadoc unit
uname Linux baca0fbcf88c 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 107d5db
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6119/7/testReport/
Max. process+thread count 2040 (vs. ulimit of 30000)
modules C: hbase-shell U: hbase-shell
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6119/7/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@guluo2016
Copy link
Contributor

This PR seems to have been ready for a long time. @Apache9

@Apache9 Apache9 merged commit b625bda into apache:master Mar 26, 2025
1 check passed
Apache9 pushed a commit that referenced this pull request Mar 26, 2025
@ether1984 @Apache9
HBASE-28754 verify the first argument passed to compaction_switch (#6119
0b33724 
)

Co-authored-by: wangjue <ether1984@163.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Reviewed-by: guluo <lupeng_nwpu@qq.com>
Reviewed-by: Chandra Sekhar K <chandrasekhar188k@gmail.com>
(cherry picked from commit b625bda)
Apache9 pushed a commit that referenced this pull request Mar 26, 2025
@ether1984 @Apache9
HBASE-28754 verify the first argument passed to compaction_switch (#6119
b1d20d5 
)

Co-authored-by: wangjue <ether1984@163.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Reviewed-by: guluo <lupeng_nwpu@qq.com>
Reviewed-by: Chandra Sekhar K <chandrasekhar188k@gmail.com>
(cherry picked from commit b625bda)
Apache9 pushed a commit that referenced this pull request Mar 26, 2025
@ether1984 @Apache9
HBASE-28754 verify the first argument passed to compaction_switch (#6119
5f6b215 
)

Co-authored-by: wangjue <ether1984@163.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Reviewed-by: guluo <lupeng_nwpu@qq.com>
Reviewed-by: Chandra Sekhar K <chandrasekhar188k@gmail.com>
(cherry picked from commit b625bda)
Apache9 pushed a commit that referenced this pull request Mar 26, 2025
@ether1984 @Apache9
HBASE-28754 verify the first argument passed to compaction_switch (#6119
9331055 
)

Co-authored-by: wangjue <ether1984@163.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Reviewed-by: guluo <lupeng_nwpu@qq.com>
Reviewed-by: Chandra Sekhar K <chandrasekhar188k@gmail.com>
(cherry picked from commit b625bda)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Apache9 Apache9 Apache9 approved these changes

@guluo2016 guluo2016 guluo2016 approved these changes

@chandrasekhar-188k chandrasekhar-188k chandrasekhar-188k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ether1984 @Apache-HBase @Apache9 @guluo2016 @chandrasekhar-188k