HBASE-22965 RS Crash due to DBE reference to an reused ByteBuff #603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
anoopsjohn
reviewed
Sep 12, 2019
|
|
||
| public void beforeShipped() { | ||
| if (this.prevCell != null) { | ||
| this.prevCell = KeyValueUtil.copyToNewKeyValue(this.prevCell); |
There was a problem hiding this comment.
Seems we need both key and value from the prevCell in FastDiffDeltaEncoder and all. Just add a comment saying so. Normally we copy the key part alone in beforeShipped
anoopsjohn
reviewed
Sep 12, 2019
| return prevCell; | ||
| } | ||
|
|
||
| public void beforeShipped() { |
There was a problem hiding this comment.
Why not making it ShipperListener. That would be best
There was a problem hiding this comment.
If do so, we should move ShipperListener to hbase-common first
anoopsjohn
reviewed
Sep 12, 2019
| @@ -840,6 +841,16 @@ public boolean isSharedMem() { | |||
| /** Meta data that holds information about the hfileblock**/ | |||
| private HFileContext fileContext; | |||
|
|
|||
| void beforeShipped() { | |||
There was a problem hiding this comment.
Why not making it ShipperListener. That would be best
anoopsjohn
reviewed
Sep 12, 2019
| @@ -781,6 +783,11 @@ public Cell getLastCell() { | |||
| return lastCell; | |||
| } | |||
|
|
|||
| @VisibleForTesting | |||
There was a problem hiding this comment.
So many method exposes for the test-ability. Are we really testing the FT way? That a prevCell been passed and we pollute that cell's backing BB/byte[] after a shipped call? That would be the best and in that I dont think we need to expose these many method.
There was a problem hiding this comment.
replace the UT with TestHFile#testDBEShipped
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
Hi @anoopsjohn , do you think the PR is OK now? or do I need to make any adjustments? |
anoopsjohn
requested changes
Sep 27, 2019
| writer.beforeShipped(); | ||
|
|
||
| Cell cell = writer.blockWriter.getEncodingState().getLastCell(); | ||
| assertTrue(cell instanceof KeyValue); |
There was a problem hiding this comment.
The UT is not really doing a meaningful test. Write a cell first and then pollute its backing ByteBuffer by directly manipulating few bytes which comes at some KeyLen part or so. Then write another cell. Call the beforeShipped() before manipulating this 1st BB. With out the patch, we will end up in some issues. The patch should fix it.
Even we can remove all these new getters exposed in different classes for testing.
There was a problem hiding this comment.
thanks for the feedback
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
asfgit
pushed a commit
that referenced
this pull request
Sep 30, 2019
Signed-off-by: huzheng <openinx@gmail.com>
asfgit
pushed a commit
that referenced
this pull request
Sep 30, 2019
Signed-off-by: huzheng <openinx@gmail.com>
asfgit
pushed a commit
that referenced
this pull request
Sep 30, 2019
Signed-off-by: huzheng <openinx@gmail.com>
infraio
pushed a commit
to infraio/hbase
that referenced
this pull request
Aug 17, 2020
…he#603) Signed-off-by: huzheng <openinx@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.