Skip to content

HBASE-8458 Support for batch version of checkAndPut() and checkAndDelete() #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

HBASE-8458 Support for batch version of checkAndPut() and checkAndDelete() #594

wants to merge 1 commit into from

Conversation

guangxuCheng
Copy link
Member

batch checkAndxxx using existing batch method on Table.

detail see: https://issues.apache.org/jira/browse/HBASE-8458

@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
💙 reexec 0m 36s Docker mode activated.
_ Prechecks _
💚 dupname 0m 1s No case conflicting files found.
💙 prototool 0m 0s prototool was not available.
💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
💚 @author 0m 0s The patch does not contain any @author tags.
💚 test4tests 0m 0s The patch appears to include 2 new or modified test files.
_ branch-2 Compile Tests _
💙 mvndep 0m 15s Maven dependency ordering for branch
💚 mvninstall 5m 57s branch-2 passed
💚 compile 2m 1s branch-2 passed
💚 checkstyle 2m 18s branch-2 passed
💚 shadedjars 4m 11s branch has no errors when building our shaded downstream artifacts.
💚 javadoc 1m 17s branch-2 passed
💙 spotbugs 3m 9s Used deprecated FindBugs config; considering switching to SpotBugs.
💚 findbugs 6m 55s branch-2 passed
_ Patch Compile Tests _
💙 mvndep 0m 15s Maven dependency ordering for patch
💚 mvninstall 5m 0s the patch passed
💚 compile 2m 3s the patch passed
💚 cc 2m 3s the patch passed
💚 javac 2m 3s the patch passed
💚 checkstyle 2m 20s the patch passed
💚 whitespace 0m 0s The patch has no whitespace issues.
💚 shadedjars 4m 21s patch has no errors when building our shaded downstream artifacts.
💚 hadoopcheck 15m 47s Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚 hbaseprotoc 1m 55s the patch passed
💚 javadoc 1m 14s the patch passed
💚 findbugs 7m 45s the patch passed
_ Other Tests _
💚 unit 0m 41s hbase-protocol-shaded in the patch passed.
💚 unit 3m 39s hbase-client in the patch passed.
💔 unit 176m 44s hbase-server in the patch failed.
💚 asflicense 1m 30s The patch does not generate ASF License warnings.
253m 51s
Reason Tests
Failed junit tests hadoop.hbase.replication.regionserver.TestWALEntryStream
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-594/3/artifact/out/Dockerfile
GITHUB PR #594
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool
uname Linux ef30042b166f 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-594/out/precommit/personality/provided.sh
git revision branch-2 / 1568e05
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-594/3/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-594/3/testReport/
Max. process+thread count 4796 (vs. ulimit of 10000)
modules C: hbase-protocol-shaded hbase-client hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-594/3/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@saintstack
Copy link
Contributor

Oh. Rerunning tests but patch has conflicts. Mind fixing please @guangxuCheng ?

@guangxuCheng
Copy link
Member Author

Oh. Rerunning tests but patch has conflicts. Mind fixing please @guangxuCheng ?

@saintstack Thanks for review. Rebased to current branch-2, pending QA, Thanks

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
💙 reexec 0m 40s Docker mode activated.
_ Prechecks _
💚 dupname 0m 0s No case conflicting files found.
💙 prototool 0m 0s prototool was not available.
💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
💚 @author 0m 0s The patch does not contain any @author tags.
💚 test4tests 0m 0s The patch appears to include 2 new or modified test files.
_ branch-2 Compile Tests _
💙 mvndep 0m 30s Maven dependency ordering for branch
💚 mvninstall 5m 13s branch-2 passed
💚 compile 1m 59s branch-2 passed
💚 checkstyle 2m 16s branch-2 passed
💚 shadedjars 4m 12s branch has no errors when building our shaded downstream artifacts.
💚 javadoc 1m 15s branch-2 passed
💙 spotbugs 3m 21s Used deprecated FindBugs config; considering switching to SpotBugs.
💚 findbugs 6m 55s branch-2 passed
_ Patch Compile Tests _
💙 mvndep 0m 15s Maven dependency ordering for patch
💚 mvninstall 4m 46s the patch passed
💚 compile 1m 59s the patch passed
💚 cc 1m 59s the patch passed
💚 javac 1m 59s the patch passed
💚 checkstyle 2m 14s the patch passed
💚 whitespace 0m 0s The patch has no whitespace issues.
💚 shadedjars 4m 13s patch has no errors when building our shaded downstream artifacts.
💚 hadoopcheck 15m 15s Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚 hbaseprotoc 1m 51s the patch passed
💚 javadoc 1m 12s the patch passed
💚 findbugs 7m 22s the patch passed
_ Other Tests _
💚 unit 0m 42s hbase-protocol-shaded in the patch passed.
💚 unit 3m 38s hbase-client in the patch passed.
💚 unit 160m 42s hbase-server in the patch passed.
💚 asflicense 1m 35s The patch does not generate ASF License warnings.
235m 36s
Subsystem Report/Notes
Docker Client=19.03.3 Server=19.03.3 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-594/5/artifact/out/Dockerfile
GITHUB PR #594
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool
uname Linux 9b7e52fd7b96 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-594/out/precommit/personality/provided.sh
git revision branch-2 / 18ff188
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-594/5/testReport/
Max. process+thread count 4061 (vs. ulimit of 10000)
modules C: hbase-protocol-shaded hbase-client hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-594/5/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@guangxuCheng
Copy link
Member Author

@saintstack @Apache9 can you take a look? Thanks

@Apache9
Copy link
Contributor

Apache9 commented Oct 26, 2019

Could you please upload a patch against master?

@guangxuCheng
Copy link
Member Author

Thanks @Apache9 for review. Create a new PR for master. #765

@HorizonNet HorizonNet mentioned this pull request Dec 13, 2019
Closed
@brfrn169 brfrn169 closed this Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@guangxuCheng @Apache-HBase @saintstack @Apache9 @brfrn169