Skip to content

HBASE-22962 Fix typo in javadoc description #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2019

Conversation

KangZhiDong
Copy link
Contributor

No description provided.

@busbey
Copy link
Contributor

busbey commented Sep 1, 2019

Hi,

Thanks for this PR.

The HBase project mainly use The ASF JIRA for tracking issues, would you mind filing a jira and describing your problem there?

For how to contribute to HBase, please refer to Get involved for more details.

And feel free to email your questions or doubts to dev@hbase.apache.org for help.

@KangZhiDong KangZhiDong changed the title fix typo HBASE-22962 fix typo Sep 1, 2019
@KangZhiDong
Copy link
Contributor Author

Hi,

Thanks for this PR.

The HBase project mainly use The ASF JIRA for tracking issues, would you mind filing a jira and describing your problem there?

For how to contribute to HBase, please refer to Get involved for more details.

And feel free to email your questions or doubts to dev@hbase.apache.org for help.

https://issues.apache.org/jira/browse/HBASE-22962

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 55 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 6 new or modified test files.
_ master Compile Tests _
0 mvndep 39 Maven dependency ordering for branch
+1 mvninstall 388 master passed
+1 compile 218 master passed
+1 checkstyle 230 master passed
+1 shadedjars 319 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 160 master passed
0 spotbugs 108 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 617 master passed
_ Patch Compile Tests _
0 mvndep 18 Maven dependency ordering for patch
+1 mvninstall 398 the patch passed
+1 compile 230 the patch passed
+1 javac 230 the patch passed
+1 checkstyle 238 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 347 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1167 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 146 the patch passed
+1 findbugs 540 the patch passed
_ Other Tests _
+1 unit 185 hbase-common in the patch passed.
+1 unit 74 hbase-http in the patch passed.
+1 unit 9491 hbase-server in the patch passed.
+1 unit 222 hbase-thrift in the patch passed.
+1 unit 899 hbase-backup in the patch passed.
+1 unit 328 hbase-rest in the patch passed.
+1 asflicense 208 The patch does not generate ASF License warnings.
17017
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-569/1/artifact/out/Dockerfile
GITHUB PR #569
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux a6a031e38842 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-569/out/precommit/personality/provided.sh
git revision master / b642ee0
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-569/1/testReport/
Max. process+thread count 4605 (vs. ulimit of 10000)
modules C: hbase-common hbase-http hbase-server hbase-thrift hbase-backup hbase-rest U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-569/1/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@jojochuang
Copy link
Contributor

LGTM +1 (non binding)

@jojochuang
Copy link
Contributor

(I reviewed the patch, and then realized it's a HBase patch, not a Hadoop patch. Still, since I invested my time in this review, I thought to post a patch review to save other reviewers' time)

Copy link
Contributor

@Apache9 Apache9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Apache9 Apache9 changed the title HBASE-22962 fix typo HBASE-22962 Fix typo in javadoc description Sep 1, 2019
@Apache9 Apache9 merged commit 97fbaa6 into apache:master Sep 1, 2019
@Apache9
Copy link
Contributor

Apache9 commented Sep 1, 2019

Merged to master. Thanks @jojochuang for reviewing.

asfgit pushed a commit that referenced this pull request Sep 1, 2019
Signed-off-by: Duo Zhang <zhangduo@apache.org>
asfgit pushed a commit that referenced this pull request Sep 1, 2019
Signed-off-by: Duo Zhang <zhangduo@apache.org>
asfgit pushed a commit that referenced this pull request Sep 1, 2019
Signed-off-by: Duo Zhang <zhangduo@apache.org>
@busbey
Copy link
Contributor

busbey commented Sep 2, 2019

(I reviewed the patch, and then realized it's a HBase patch, not a Hadoop patch. Still, since I invested my time in this review, I thought to post a patch review to save other reviewers' time)

We love reviews from not-yet-committers. Please feel free to keep doing them. It definitely helps me if someone else has taken a look at a change request. 😸

infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020
Signed-off-by: Duo Zhang <zhangduo@apache.org>
symat pushed a commit to symat/hbase that referenced this pull request Feb 17, 2021
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 1f9d650)

Change-Id: I67e7751ab45611b8f49388424f16698a07eb4b97
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants