-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-28212 Do not need to maintain rollback step when root procedure… #5538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/ProcedureExecutor.java
Show resolved
Hide resolved
@@ -1577,15 +1677,6 @@ private LockState executeRollback(Procedure<TEnvironment> proc) { | |||
LOG.error(HBaseMarkers.FATAL, "CODE-BUG: Uncaught runtime exception for " + proc, e); | |||
} | |||
|
|||
// allows to kill the executor before something is stored to the wal. | |||
// useful to test the procedure recovery. | |||
if (testing != null && testing.shouldKillBeforeStoreUpdate()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have replaced shouldKillBeforeStoreUpdate
here with shouldKillBeforeStoreUpdateInRollback
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I split the condition for normal execution and rollback, so in some tests we need to set both, for example, in TestProcedureRecovery.
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🎊 +1 overall
This message was automatically generated. |
… does not support rollback
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
Will merge tomorrow if no other concerns~ Thanks @GeorryHuang for reviewing~ |
… does not support rollback (apache#5538) Signed-off-by: GeorryHuang <huangzhuoyue@apache.org> (cherry picked from commit 4b015e6) (cherry picked from commit 7d6de8b)
… does not support rollback (apache#5538) Signed-off-by: GeorryHuang <huangzhuoyue@apache.org>
… does not support rollback (apache#5538) (apache#5547) Signed-off-by: GeorryHuang <huangzhuoyue@apache.org> (cherry picked from commit 4b015e6) (cherry picked from commit b1bef8f) Change-Id: I6758e5ec7c06e38fc10e388b9cf295dc587733d2
… does not support rollback