Skip to content

Backport "HBASE-23102: Improper Usage of Map putIfAbsent (#828)" to branch-2.5 #5062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2023
Merged

Backport "HBASE-23102: Improper Usage of Map putIfAbsent (#828)" to branch-2.5 #5062

merged 1 commit into from
Mar 1, 2023

Conversation

ndimiduk
Copy link
Member

No description provided.

@ndimiduk @belugabehr
HBASE-23102: Improper Usage of Map putIfAbsent (apache#828)
fb4b858 
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Co-authored-by: belugabehr <12578579+belugabehr@users.noreply.github.com>
@ndimiduk ndimiduk added the backport This PR is a back port of some issue or issues already committed to master label Feb 27, 2023
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 11s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2.5 Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
+1 💚 mvninstall 3m 55s branch-2.5 passed
+1 💚 compile 3m 45s branch-2.5 passed
+1 💚 checkstyle 1m 0s branch-2.5 passed
+1 💚 spotless 0m 49s branch has no errors when running spotless:check.
+1 💚 spotbugs 2m 41s branch-2.5 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 4m 3s the patch passed
+1 💚 compile 3m 32s the patch passed
+1 💚 javac 3m 32s the patch passed
+1 💚 checkstyle 0m 10s The patch passed checkstyle in hbase-procedure
+1 💚 checkstyle 0m 38s hbase-server: The patch generated 0 new + 5 unchanged - 1 fixed = 5 total (was 6)
+1 💚 checkstyle 0m 8s The patch passed checkstyle in hbase-rsgroup
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 20m 26s Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.4.
+1 💚 spotless 0m 41s patch has no errors when running spotless:check.
+1 💚 spotbugs 3m 10s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 26s The patch does not generate ASF License warnings.
49m 20s
Subsystem Report/Notes
Docker ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5062/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5062
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname Linux bed4a1f50ba2 5.4.0-135-generic #152-Ubuntu SMP Wed Nov 23 20:19:22 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.5 / c29355e
Default Java Eclipse Adoptium-11.0.17+8
Max. process+thread count 85 (vs. ulimit of 30000)
modules C: hbase-procedure hbase-server hbase-rsgroup U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5062/1/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 4s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.5 Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for branch
+1 💚 mvninstall 5m 22s branch-2.5 passed
+1 💚 compile 1m 28s branch-2.5 passed
+1 💚 shadedjars 5m 21s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 20s branch-2.5 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 22s Maven dependency ordering for patch
+1 💚 mvninstall 5m 40s the patch passed
+1 💚 compile 2m 5s the patch passed
+1 💚 javac 2m 5s the patch passed
+1 💚 shadedjars 6m 32s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 3s the patch passed
_ Other Tests _
+1 💚 unit 1m 40s hbase-procedure in the patch passed.
-1 ❌ unit 255m 51s hbase-server in the patch failed.
+1 💚 unit 4m 43s hbase-rsgroup in the patch passed.
298m 5s
Subsystem Report/Notes
Docker ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5062/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #5062
Optional Tests javac javadoc unit shadedjars compile
uname Linux 7204cd13ce2d 5.4.0-1092-aws #100~18.04.2-Ubuntu SMP Tue Nov 29 08:39:52 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.5 / c29355e
Default Java Eclipse Adoptium-11.0.17+8
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5062/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5062/1/testReport/
Max. process+thread count 2429 (vs. ulimit of 30000)
modules C: hbase-procedure hbase-server hbase-rsgroup U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5062/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 0s Docker mode activated.
-0 ⚠️ yetus 0m 7s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.5 Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for branch
+1 💚 mvninstall 4m 23s branch-2.5 passed
+1 💚 compile 1m 18s branch-2.5 passed
+1 💚 shadedjars 6m 23s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 17s branch-2.5 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 3m 48s the patch passed
+1 💚 compile 1m 32s the patch passed
+1 💚 javac 1m 32s the patch passed
+1 💚 shadedjars 6m 14s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 1s the patch passed
_ Other Tests _
+1 💚 unit 1m 56s hbase-procedure in the patch passed.
-1 ❌ unit 261m 58s hbase-server in the patch failed.
+1 💚 unit 6m 47s hbase-rsgroup in the patch passed.
303m 47s
Subsystem Report/Notes
Docker ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5062/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #5062
Optional Tests javac javadoc unit shadedjars compile
uname Linux a581e6bceefd 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.5 / c29355e
Default Java Temurin-1.8.0_352-b08
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5062/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5062/1/testReport/
Max. process+thread count 2653 (vs. ulimit of 30000)
modules C: hbase-procedure hbase-server hbase-rsgroup U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5062/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ndimiduk
Copy link
Member Author

ndimiduk commented Mar 1, 2023

TestRegionRebalancing, TestMobCompactionWithDefaults, and TestSplitRegionWhileRSCrash all pass for me locally.

@ndimiduk ndimiduk merged commit a5d0f26 into apache:branch-2.5 Mar 1, 2023
@ndimiduk ndimiduk deleted the 23102-improper-use-of-map-putifabsent-branch-2.5 branch March 1, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport This PR is a back port of some issue or issues already committed to master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndimiduk @Apache-HBase