HBASE-22841 Add more factory functions to TimeRange #483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These functions make it easier to possible to use `org.apache.hadoop.hbase.client.Table.CheckAndMutateBuilder#timeRange` with more interesting ranges, without being forced to use the deprecated constructors.
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
HorizonNet
reviewed
Aug 13, 2019
| @@ -28,9 +28,6 @@ | |||
| * <p> | |||
| * Evaluated according to minStamp <= timestamp < maxStamp | |||
| * or [minStamp,maxStamp) in interval notation. | |||
| * <p> | |||
| * Can be returned and read by clients. Should not be directly created by clients. | |||
There was a problem hiding this comment.
I think that this comment is still valid until the deprecated constructors are removed.
There was a problem hiding this comment.
I've added this in the committed patch.
| @@ -4866,12 +4866,48 @@ public void testCheckAndMutateWithTimeRange() throws IOException { | |||
| .thenPut(put); | |||
| assertFalse(ok); | |||
|
|
|||
| ok = table.checkAndMutate(ROW, FAMILY).qualifier(QUALIFIER) | |||
There was a problem hiding this comment.
Could you please add a short comment for every test what the purpose is (or move them into separate, small test cases)?
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
openinx
reviewed
Aug 14, 2019
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
I think the patch is good enough now, plan to commit this patch to avoid the daily nosiy from hadoopQA :-) |
|
Oh, thanks. I was going to get to the feedback today. Should I open a follow-up pull request that addresses @HorizonNet's comment about the tests? |
|
@huonw no need. I've addressed that in the committed patch. Thanks for your contribution. |
|
Thank you for doing so! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These functions make it easier to possible to use
org.apache.hadoop.hbase.client.Table.CheckAndMutateBuilder#timeRangewith more interesting ranges, without being forced to use the
deprecated constructors.