-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-27152 Under compaction mark may leak #4725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎊 +1 overall
This message was automatically generated. |
@@ -145,15 +144,15 @@ private void createCompactionExecutors() { | |||
final String n = Thread.currentThread().getName(); | |||
|
|||
StealJobQueue<Runnable> stealJobQueue = new StealJobQueue<Runnable>(COMPARATOR); | |||
// Since the StealJobQueue is unbounded, we need not to set the RejectedExecutionHandler for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be done as a separated issue? And what is the disadvantage to set the rejection handler, seems no harm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually the max size of StealJobQueue is bouded by the VM limit of an array, and the OOM exception occurs before the rejection handler. So StealJobQueue is equivalent to be unbounded. I think the RejectionHandler may bring some confusions and make the codes a little puzzle.
I will seperate the removing the rejection handler here in another issue. Thanks.
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java
Show resolved
Hide resolved
🎊 +1 overall
This message was automatically generated. |
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
No description provided.