HBASE-22822 : Un/Re-schedule balancer chore with balance_switch #468

virajjasani · 2019-08-08T19:25:47Z

balance_switch turns on/off balancer. When it is turned off, we don't remove balancer chore from scheduled chores hence it keeps running only to eventually find out that it is not supposed to perform any action(if balancer was turned off). We can unschedule the chore to prevent the chore() execution and reschedule it when it is turned on by balance_switch.

This should also facilitate running balancer immediately after triggering balance_switch true(due to default initial delay: 0), and then chore would continue running as per duration provided in hbase.balancer.period.

Apache-HBase · 2019-08-08T22:48:54Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	39	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	1	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1	mvninstall	334	master passed
+1	compile	53	master passed
+1	checkstyle	77	master passed
+1	shadedjars	271	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	36	master passed
0	spotbugs	242	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	240	master passed
		_ Patch Compile Tests _
+1	mvninstall	297	the patch passed
+1	compile	51	the patch passed
+1	javac	51	the patch passed
+1	checkstyle	72	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	260	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	911	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	32	the patch passed
+1	findbugs	241	the patch passed
		_ Other Tests _
-1	unit	8605	hbase-server in the patch failed.
+1	asflicense	31	The patch does not generate ASF License warnings.
		11931

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestAsyncRegionAdminApi
	hadoop.hbase.regionserver.TestSplitTransactionOnCluster

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/1/artifact/out/Dockerfile
GITHUB PR	#468
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 2458f12033d8 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revision	master / `9250977`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/1/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/1/testReport/
Max. process+thread count	4578 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/1/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-09T03:54:18Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	40	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1	mvninstall	312	master passed
+1	compile	51	master passed
+1	checkstyle	73	master passed
+1	shadedjars	260	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	37	master passed
0	spotbugs	235	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	234	master passed
		_ Patch Compile Tests _
+1	mvninstall	281	the patch passed
+1	compile	52	the patch passed
+1	javac	52	the patch passed
+1	checkstyle	71	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	255	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	894	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	33	the patch passed
+1	findbugs	250	the patch passed
		_ Other Tests _
-1	unit	8435	hbase-server in the patch failed.
+1	asflicense	32	The patch does not generate ASF License warnings.
		11663

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestAsyncRegionAdminApi
	hadoop.hbase.regionserver.TestSplitTransactionOnCluster

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/2/artifact/out/Dockerfile
GITHUB PR	#468
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 04ddbc6ee3dc 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revision	master / `eb92b25`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/2/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/2/testReport/
Max. process+thread count	4793 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/2/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-09T11:37:05Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	86	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1	mvninstall	377	master passed
+1	compile	53	master passed
+1	checkstyle	76	master passed
+1	shadedjars	293	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	35	master passed
0	spotbugs	252	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	249	master passed
		_ Patch Compile Tests _
+1	mvninstall	333	the patch passed
+1	compile	55	the patch passed
+1	javac	55	the patch passed
+1	checkstyle	75	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	261	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	949	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	30	the patch passed
+1	findbugs	254	the patch passed
		_ Other Tests _
-1	unit	19085	hbase-server in the patch failed.
+1	asflicense	47	The patch does not generate ASF License warnings.
		22619

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestFromClientSide
	hadoop.hbase.client.TestCloneSnapshotFromClientNormal
	hadoop.hbase.client.TestAsyncTableAdminApi
	hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController
	hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated
	hadoop.hbase.client.TestSnapshotTemporaryDirectory
	hadoop.hbase.client.TestAsyncRegionAdminApi
	hadoop.hbase.regionserver.TestSplitTransactionOnCluster

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/3/artifact/out/Dockerfile
GITHUB PR	#468
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 029f356db98b 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revision	master / `c05ee7c`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/3/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/3/testReport/
Max. process+thread count	4946 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/3/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-09T11:48:12Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	48	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	458	master passed
+1	compile	75	master passed
+1	checkstyle	113	master passed
+1	shadedjars	359	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	55	master passed
0	spotbugs	338	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	335	master passed
		_ Patch Compile Tests _
+1	mvninstall	393	the patch passed
+1	compile	68	the patch passed
+1	javac	68	the patch passed
+1	checkstyle	107	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	355	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1194	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	46	the patch passed
+1	findbugs	312	the patch passed
		_ Other Tests _
-1	unit	9513	hbase-server in the patch failed.
+1	asflicense	25	The patch does not generate ASF License warnings.
		13945

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestAsyncRegionAdminApi

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/5/artifact/out/Dockerfile
GITHUB PR	#468
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 36502798b251 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revision	master / `989e09a`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/5/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/5/testReport/
Max. process+thread count	4869 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/5/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-09T19:24:53Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	146	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	499	master passed
+1	compile	73	master passed
+1	checkstyle	100	master passed
+1	shadedjars	383	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	45	master passed
0	spotbugs	319	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	317	master passed
		_ Patch Compile Tests _
+1	mvninstall	414	the patch passed
+1	compile	99	the patch passed
+1	javac	99	the patch passed
+1	checkstyle	100	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	350	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1286	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	41	the patch passed
+1	findbugs	316	the patch passed
		_ Other Tests _
-1	unit	18963	hbase-server in the patch failed.
+1	asflicense	50	The patch does not generate ASF License warnings.
		23681

Reason	Tests
Failed junit tests	hadoop.hbase.tool.TestSecureBulkLoadHFiles
	hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated
	hadoop.hbase.tool.TestBulkLoadHFiles
	hadoop.hbase.replication.TestReplicationDisableInactivePeer
	hadoop.hbase.regionserver.TestSplitTransactionOnCluster
	hadoop.hbase.master.TestAssignmentManagerMetrics
	hadoop.hbase.client.TestSnapshotTemporaryDirectory
	hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory
	hadoop.hbase.client.TestFromClientSide
	hadoop.hbase.client.TestCloneSnapshotFromClientNormal

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/6/artifact/out/Dockerfile
GITHUB PR	#468
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 4361ab7bddcf 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revision	master / `989e09a`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/6/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/6/testReport/
Max. process+thread count	4895 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/6/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-10T00:49:06Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	37	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	370	master passed
+1	compile	63	master passed
+1	checkstyle	88	master passed
+1	shadedjars	293	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	38	master passed
0	spotbugs	278	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	276	master passed
		_ Patch Compile Tests _
+1	mvninstall	309	the patch passed
+1	compile	58	the patch passed
+1	javac	58	the patch passed
+1	checkstyle	75	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	275	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	943	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	34	the patch passed
+1	findbugs	253	the patch passed
		_ Other Tests _
-1	unit	8446	hbase-server in the patch failed.
+1	asflicense	27	The patch does not generate ASF License warnings.
		11947

Reason	Tests
Failed junit tests	hadoop.hbase.master.replication.TestRegisterPeerWorkerWhenRestarting

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/8/artifact/out/Dockerfile
GITHUB PR	#468
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 27ea32ed267c 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revision	master / `c8f57bf`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/8/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/8/testReport/
Max. process+thread count	4832 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/8/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

virajjasani · 2019-08-11T16:14:30Z

Please review @apurtell @Reidddddd @anoopsjohn

saintstack

Just a nit in the below. Not important. LGTM.

saintstack · 2019-08-11T17:00:25Z

hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java

+   *
+   * @param on boolean value indicates whether to turn the balancer on
+   */
+  void turnBalancer(boolean on) {


s/turnBalancer/switchBalancer/ ?

Apache-HBase · 2019-08-11T23:02:24Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	210	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	337	master passed
+1	compile	52	master passed
+1	checkstyle	76	master passed
+1	shadedjars	306	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	39	master passed
0	spotbugs	247	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	244	master passed
		_ Patch Compile Tests _
+1	mvninstall	346	the patch passed
+1	compile	60	the patch passed
+1	javac	60	the patch passed
+1	checkstyle	76	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	272	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	942	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	37	the patch passed
+1	findbugs	252	the patch passed
		_ Other Tests _
-1	unit	16227	hbase-server in the patch failed.
+1	asflicense	40	The patch does not generate ASF License warnings.
		19943

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestFromClientSide
	hadoop.hbase.master.TestAssignmentManagerMetrics
	hadoop.hbase.client.TestAdmin1

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/9/artifact/out/Dockerfile
GITHUB PR	#468
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 252369174a0e 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revision	master / `c8f57bf`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/9/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/9/testReport/
Max. process+thread count	5064 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/9/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-12T01:59:37Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	64	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	431	master passed
+1	compile	70	master passed
+1	checkstyle	98	master passed
+1	shadedjars	373	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	47	master passed
0	spotbugs	329	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	325	master passed
		_ Patch Compile Tests _
+1	mvninstall	397	the patch passed
+1	compile	70	the patch passed
+1	javac	70	the patch passed
+1	checkstyle	89	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	343	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1229	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	43	the patch passed
+1	findbugs	343	the patch passed
		_ Other Tests _
-1	unit	17703	hbase-server in the patch failed.
+1	asflicense	33	The patch does not generate ASF License warnings.
		22161

Reason	Tests
Failed junit tests	hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated
	hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController
	hadoop.hbase.replication.TestReplicationKillSlaveRS
	hadoop.hbase.client.TestAdmin1

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/10/artifact/out/Dockerfile
GITHUB PR	#468
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux f93d590517b9 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revision	master / `15c903b`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/10/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/10/testReport/
Max. process+thread count	4853 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/10/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-12T02:37:51Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	90	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	340	master passed
+1	compile	55	master passed
+1	checkstyle	78	master passed
+1	shadedjars	274	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	37	master passed
0	spotbugs	267	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	265	master passed
		_ Patch Compile Tests _
+1	mvninstall	296	the patch passed
+1	compile	55	the patch passed
+1	javac	55	the patch passed
+1	checkstyle	75	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	271	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	931	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	39	the patch passed
+1	findbugs	259	the patch passed
		_ Other Tests _
+1	unit	8990	hbase-server in the patch passed.
+1	asflicense	23	The patch does not generate ASF License warnings.
		12452

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/11/artifact/out/Dockerfile
GITHUB PR	#468
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 72d2c3357bee 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revision	master / `e938215`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/11/testReport/
Max. process+thread count	4731 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/11/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Reidddddd · 2019-08-12T03:37:51Z

IIRC, gracefully_stop.sh will turn balancer off, move regions, stop/restart RS, then turn balancer on.

And there's one script rolling_restart.sh relying on gracefully_stop.sh, will repeat the mentioned process. If the RS number in rolling restart is large which is often the case in production env---hundreds at least, the master inside will cancel and remove task then construct a new task back and forth, at JVM level.

One step back, current impl brings no harm to master nor good, but the new impl looks like may bring a new uncertainty.

I incline to keep it still, and so, leave my -0.

virajjasani · 2019-08-12T05:55:05Z

IIRC, gracefully_stop.sh will turn balancer off, move regions, stop/restart RS, then turn balancer on.

And there's one script rolling_restart.sh relying on gracefully_stop.sh, will repeat the mentioned process. If the RS number in rolling restart is large which is often the case in production env---hundreds at least, the master inside will cancel and remove task then construct a new task back and forth, at JVM level.

One step back, current impl brings no harm to master nor good, but the new impl looks like may bring a new uncertainty.

I incline to keep it still, and so, leave my -0.

graceful_stop.sh turns on balancer at the end conditionally. If -nob arg is provided, it won't: here
rolling_restart.sh provides that arg here
rolling_restart itself taking care of turning the balancer on/off makes sense rather than gracefu_stop taking care of it for rolling_restart. Even if it didn't, it could still run into the possibility of running balancer in between rolling restart of RegionServers, which should not happen provided we move regions back and forth anyways here.

virajjasani · 2019-08-12T09:03:58Z

@Reidddddd
Hence, balancer will be turned off before starting with rolling restart and turned on after all n servers are restarted (not in-between restarts of individual servers).
However, I am just wondering if there are any other such scenarios where we keep turning on/off balancer quite frequently as part of some workflow?

Reidddddd · 2019-08-12T09:47:33Z

Hence, balancer will be turned off before starting with rolling restart and turned on after all n servers are restarted (not in-between restarts of individual servers).

Hmm, right. But it only works for master and branch-2.
But even it only targets to a single RS where balance off is only a temporary move, do you really think it is a good practice or worthy of destructing then constructing a task, just within few minutes?

However, I am just wondering if there are any other such scenarios where we keep turning on/off balancer quite frequently as part of some workflow?

Just rolling restart, maybe. One place I'm not sure is RSGroup's move_regions op.

Apache-HBase · 2019-08-12T14:51:10Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	167	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	364	master passed
+1	compile	58	master passed
+1	checkstyle	79	master passed
+1	shadedjars	264	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	37	master passed
0	spotbugs	250	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	248	master passed
		_ Patch Compile Tests _
+1	mvninstall	334	the patch passed
+1	compile	57	the patch passed
+1	javac	57	the patch passed
+1	checkstyle	76	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	298	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1018	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	31	the patch passed
+1	findbugs	256	the patch passed
		_ Other Tests _
-1	unit	20948	hbase-server in the patch failed.
+1	asflicense	50	The patch does not generate ASF License warnings.
		24654

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestTableSnapshotScanner
	hadoop.hbase.snapshot.TestRestoreFlushSnapshotFromClient
	hadoop.hbase.master.assignment.TestSplitTableRegionProcedure
	hadoop.hbase.client.TestFromClientSide
	hadoop.hbase.master.TestSplitRegionWhileRSCrash
	hadoop.hbase.regionserver.wal.TestAsyncWALReplayCompressed
	hadoop.hbase.regionserver.wal.TestWALReplayBoundedLogWriterCreation
	hadoop.hbase.regionserver.wal.TestSecureAsyncWALReplay
	hadoop.hbase.client.TestRestoreSnapshotFromClientClone
	hadoop.hbase.client.TestAsyncTableAdminApi
	hadoop.hbase.regionserver.wal.TestLogRolling
	hadoop.hbase.client.TestAsyncSnapshotAdminApi
	hadoop.hbase.tool.TestSecureBulkLoadHFilesSplitRecovery
	hadoop.hbase.client.TestSeparateClientZKCluster
	hadoop.hbase.replication.TestSerialReplication
	hadoop.hbase.client.TestRestoreSnapshotFromClientAfterSplittingRegions
	hadoop.hbase.client.TestAsyncSingleRequestRpcRetryingCaller
	hadoop.hbase.coprocessor.TestOpenTableInCoprocessor
	hadoop.hbase.client.TestMetaWithReplicas
	hadoop.hbase.client.TestAsyncNonMetaRegionLocator
	hadoop.hbase.quotas.TestFileArchiverNotifierImpl
	hadoop.hbase.client.TestRestoreSnapshotFromClientSchemaChange
	hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory
	hadoop.hbase.client.TestAsyncTableBatch
	hadoop.hbase.client.TestRestoreSnapshotFromClientAfterTruncate
	hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController
	hadoop.hbase.client.TestAsyncMetaRegionLocator
	hadoop.hbase.client.TestMobRestoreSnapshotFromClientSchemaChange
	hadoop.hbase.regionserver.TestRegionMergeTransactionOnCluster
	hadoop.hbase.client.TestAdmin2
	hadoop.hbase.client.TestMvccConsistentScanner
	hadoop.hbase.regionserver.TestEndToEndSplitTransaction
	hadoop.hbase.client.TestAdmin
	hadoop.hbase.regionserver.TestCompactSplitThread
	hadoop.hbase.regionserver.wal.TestWALReplayCompressed
	hadoop.hbase.regionserver.wal.TestWALReplay
	hadoop.hbase.client.TestAsyncTableGetMultiThreaded
	hadoop.hbase.client.TestAsyncTableLocateRegionForDeletedTable
	hadoop.hbase.TestRegionRebalancing
	hadoop.hbase.master.TestMergeTableRegionsWhileRSCrash
	hadoop.hbase.TestPartialResultsFromClientSide
	hadoop.hbase.client.TestSizeFailures
	hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures
	hadoop.hbase.regionserver.wal.TestAsyncWALReplay
	hadoop.hbase.util.TestRegionMover
	hadoop.hbase.tool.TestBulkLoadHFilesSplitRecovery
	hadoop.hbase.client.TestMobRestoreSnapshotFromClientAfterSplittingRegions
	hadoop.hbase.client.TestRestoreSnapshotFromClientSimple
	hadoop.hbase.client.TestMultiRespectsLimits
	hadoop.hbase.regionserver.wal.TestAsyncLogRolling
	hadoop.hbase.quotas.TestQuotaAdmin
	hadoop.hbase.client.TestMultiParallel
	hadoop.hbase.regionserver.TestHRegionOnCluster
	hadoop.hbase.client.TestSmallReversedScanner
	hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient
	hadoop.hbase.regionserver.wal.TestSecureWALReplay
	hadoop.hbase.snapshot.TestFlushSnapshotFromClient

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/13/artifact/out/Dockerfile
GITHUB PR	#468
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 9f9870354bcf 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revision	master / `009851d`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/13/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/13/testReport/
Max. process+thread count	5172 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/13/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

xcangCRM · 2019-08-12T22:48:17Z

Notice there are lots tests failed. Have you already confirmed that they are all irrelevant to this change? thanks @virajjasani

virajjasani · 2019-08-13T06:27:18Z

@xcangCRM yes, these test failures are irrelevant, second last build has +1 overall including unit tests.
However, I am just worried about the concern raised by @Reidddddd
Any recommendation/thought you would like to add?
Thanks

Apache-HBase · 2019-08-13T11:19:04Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	41	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	329	master passed
+1	compile	55	master passed
+1	checkstyle	81	master passed
+1	shadedjars	274	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	37	master passed
0	spotbugs	240	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	238	master passed
		_ Patch Compile Tests _
+1	mvninstall	298	the patch passed
+1	compile	51	the patch passed
+1	javac	51	the patch passed
+1	checkstyle	76	the patch passed
+1	whitespace	1	The patch has no whitespace issues.
+1	shadedjars	259	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	920	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	33	the patch passed
+1	findbugs	242	the patch passed
		_ Other Tests _
-1	unit	13238	hbase-server in the patch failed.
+1	asflicense	25	The patch does not generate ASF License warnings.
		16733

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestMultiRespectsLimits
	hadoop.hbase.regionserver.TestEndToEndSplitTransaction
	hadoop.hbase.client.TestMobRestoreSnapshotFromClientAfterSplittingRegions
	hadoop.hbase.TestPartialResultsFromClientSide
	hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures
	hadoop.hbase.client.TestSmallReversedScanner
	hadoop.hbase.snapshot.TestFlushSnapshotFromClient
	hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory
	hadoop.hbase.regionserver.TestRegionMergeTransactionOnCluster
	hadoop.hbase.regionserver.wal.TestAsyncWALReplay
	hadoop.hbase.client.TestRestoreSnapshotFromClientAfterTruncate
	hadoop.hbase.client.TestSnapshotTemporaryDirectory
	hadoop.hbase.client.TestAdmin
	hadoop.hbase.util.TestRegionMover
	hadoop.hbase.regionserver.wal.TestWALReplayBoundedLogWriterCreation
	hadoop.hbase.master.assignment.TestSplitTableRegionProcedure
	hadoop.hbase.client.TestFromClientSide
	hadoop.hbase.TestRegionRebalancing
	hadoop.hbase.master.assignment.TestMergeTableRegionsProcedure
	hadoop.hbase.client.TestAsyncSingleRequestRpcRetryingCaller
	hadoop.hbase.client.TestAsyncTableGetMultiThreaded
	hadoop.hbase.tool.TestSecureBulkLoadHFilesSplitRecovery
	hadoop.hbase.regionserver.wal.TestLogRolling
	hadoop.hbase.client.TestMobRestoreSnapshotFromClientSchemaChange
	hadoop.hbase.regionserver.wal.TestAsyncWALReplayCompressed
	hadoop.hbase.quotas.TestQuotaAdmin
	hadoop.hbase.master.TestSplitRegionWhileRSCrash
	hadoop.hbase.coprocessor.TestOpenTableInCoprocessor
	hadoop.hbase.regionserver.TestHRegionOnCluster
	hadoop.hbase.regionserver.wal.TestWALReplayCompressed
	hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController
	hadoop.hbase.regionserver.TestCompactSplitThread
	hadoop.hbase.regionserver.wal.TestWALReplay
	hadoop.hbase.regionserver.wal.TestAsyncLogRolling
	hadoop.hbase.client.TestRestoreSnapshotFromClientClone
	hadoop.hbase.client.TestRestoreSnapshotFromClientSimple
	hadoop.hbase.client.TestAsyncTableAdminApi
	hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient
	hadoop.hbase.client.TestAsyncSnapshotAdminApi
	hadoop.hbase.master.TestMergeTableRegionsWhileRSCrash
	hadoop.hbase.client.TestAsyncMetaRegionLocator
	hadoop.hbase.client.TestSeparateClientZKCluster
	hadoop.hbase.replication.TestAddToSerialReplicationPeer
	hadoop.hbase.client.TestAsyncDecommissionAdminApi
	hadoop.hbase.client.TestMultiParallel
	hadoop.hbase.client.TestSizeFailures
	hadoop.hbase.tool.TestBulkLoadHFilesSplitRecovery
	hadoop.hbase.client.TestRestoreSnapshotFromClientSchemaChange
	hadoop.hbase.client.TestTableSnapshotScanner
	hadoop.hbase.client.TestAsyncTableBatch
	hadoop.hbase.client.TestRestoreSnapshotFromClientAfterSplittingRegions
	hadoop.hbase.regionserver.wal.TestSecureAsyncWALReplay
	hadoop.hbase.regionserver.wal.TestSecureWALReplay
	hadoop.hbase.client.TestAsyncTableLocateRegionForDeletedTable
	hadoop.hbase.snapshot.TestRestoreFlushSnapshotFromClient
	hadoop.hbase.client.TestAsyncNonMetaRegionLocator
	hadoop.hbase.quotas.TestFileArchiverNotifierImpl
	hadoop.hbase.client.TestMvccConsistentScanner

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/14/artifact/out/Dockerfile
GITHUB PR	#468
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 9975d86e558d 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revision	master / `9d6a653`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/14/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/14/testReport/
Max. process+thread count	4700 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/14/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-13T14:13:34Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	245	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	379	master passed
+1	compile	65	master passed
+1	checkstyle	80	master passed
+1	shadedjars	325	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	36	master passed
0	spotbugs	261	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	260	master passed
		_ Patch Compile Tests _
+1	mvninstall	312	the patch passed
+1	compile	60	the patch passed
+1	javac	60	the patch passed
+1	checkstyle	76	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	276	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1104	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	51	the patch passed
+1	findbugs	241	the patch passed
		_ Other Tests _
-1	unit	14418	hbase-server in the patch failed.
+1	asflicense	114	The patch does not generate ASF License warnings.
		18594

Reason	Tests
Failed junit tests	hadoop.hbase.util.TestFromClientSide3WoUnsafe
	hadoop.hbase.client.TestFromClientSide3
	hadoop.hbase.replication.TestMasterReplication
	hadoop.hbase.master.procedure.TestProcedurePriority

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/15/artifact/out/Dockerfile
GITHUB PR	#468
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux fa4d55f4a3ac 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revision	master / `07ab9ed`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/15/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/15/testReport/
Max. process+thread count	4836 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/15/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-13T15:31:50Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	218	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	416	master passed
+1	compile	71	master passed
+1	checkstyle	97	master passed
+1	shadedjars	349	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	47	master passed
0	spotbugs	328	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	325	master passed
		_ Patch Compile Tests _
+1	mvninstall	416	the patch passed
+1	compile	74	the patch passed
+1	javac	74	the patch passed
+1	checkstyle	101	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	347	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1207	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	44	the patch passed
+1	findbugs	330	the patch passed
		_ Other Tests _
-1	unit	14379	hbase-server in the patch failed.
+1	asflicense	40	The patch does not generate ASF License warnings.
		18921

Reason	Tests
Failed junit tests	hadoop.hbase.replication.TestReplicationEndpoint
	hadoop.hbase.util.TestFromClientSide3WoUnsafe
	hadoop.hbase.client.TestCloneSnapshotFromClientNormal
	hadoop.hbase.client.TestFromClientSide3
	hadoop.hbase.replication.multiwal.TestReplicationEndpointWithMultipleWAL

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/16/artifact/out/Dockerfile
GITHUB PR	#468
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 6ac26b840362 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 05:29:03 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revision	master / `8c1edb3`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/16/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/16/testReport/
Max. process+thread count	5058 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/16/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-13T23:30:29Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	99	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	464	master passed
+1	compile	79	master passed
+1	checkstyle	103	master passed
+1	shadedjars	374	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	47	master passed
0	spotbugs	328	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	323	master passed
		_ Patch Compile Tests _
+1	mvninstall	412	the patch passed
+1	compile	71	the patch passed
+1	javac	71	the patch passed
+1	checkstyle	96	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	372	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1274	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	40	the patch passed
+1	findbugs	288	the patch passed
		_ Other Tests _
-1	unit	13431	hbase-server in the patch failed.
+1	asflicense	29	The patch does not generate ASF License warnings.
		17999

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestFromClientSide3
	hadoop.hbase.util.TestFromClientSide3WoUnsafe

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/17/artifact/out/Dockerfile
GITHUB PR	#468
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux e62cc2fe9175 4.4.0-143-generic #169-Ubuntu SMP Thu Feb 7 07:56:38 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revision	master / `e69af5a`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/17/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/17/testReport/
Max. process+thread count	5102 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/17/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-14T03:14:09Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	132	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	374	master passed
+1	compile	62	master passed
+1	checkstyle	97	master passed
+1	shadedjars	301	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	37	master passed
0	spotbugs	307	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	304	master passed
		_ Patch Compile Tests _
+1	mvninstall	353	the patch passed
+1	compile	59	the patch passed
+1	javac	59	the patch passed
+1	checkstyle	91	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	308	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1037	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	37	the patch passed
+1	findbugs	294	the patch passed
		_ Other Tests _
-1	unit	11894	hbase-server in the patch failed.
+1	asflicense	32	The patch does not generate ASF License warnings.
		15819

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/18/artifact/out/Dockerfile
GITHUB PR	#468
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux c42c0f8312f5 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revision	master / `27ed2ac`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/18/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/18/testReport/
Max. process+thread count	5146 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/18/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-14T20:07:20Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	44	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	351	master passed
+1	compile	57	master passed
+1	checkstyle	75	master passed
+1	shadedjars	264	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	35	master passed
0	spotbugs	252	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	249	master passed
		_ Patch Compile Tests _
+1	mvninstall	295	the patch passed
+1	compile	52	the patch passed
+1	javac	52	the patch passed
+1	checkstyle	71	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	264	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	910	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	32	the patch passed
+1	findbugs	244	the patch passed
		_ Other Tests _
+1	unit	7281	hbase-server in the patch passed.
+1	asflicense	23	The patch does not generate ASF License warnings.
		10614

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/19/artifact/out/Dockerfile
GITHUB PR	#468
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux bd2a9d4b1f7a 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revision	master / `53db390`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/19/testReport/
Max. process+thread count	4679 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/19/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-15T05:47:36Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	36	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	326	master passed
+1	compile	55	master passed
+1	checkstyle	76	master passed
+1	shadedjars	268	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	37	master passed
0	spotbugs	254	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	253	master passed
		_ Patch Compile Tests _
+1	mvninstall	298	the patch passed
+1	compile	58	the patch passed
+1	javac	58	the patch passed
+1	checkstyle	76	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	272	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	917	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	34	the patch passed
+1	findbugs	244	the patch passed
		_ Other Tests _
+1	unit	9053	hbase-server in the patch passed.
+1	asflicense	41	The patch does not generate ASF License warnings.
		12432

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/20/artifact/out/Dockerfile
GITHUB PR	#468
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 7121330dd884 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revision	master / `d9d5f69`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/20/testReport/
Max. process+thread count	4676 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/20/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-16T03:10:50Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	99	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	348	master passed
+1	compile	62	master passed
+1	checkstyle	91	master passed
+1	shadedjars	288	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	37	master passed
0	spotbugs	300	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	298	master passed
		_ Patch Compile Tests _
+1	mvninstall	330	the patch passed
+1	compile	58	the patch passed
+1	javac	58	the patch passed
+1	checkstyle	84	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	290	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	965	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	36	the patch passed
+1	findbugs	290	the patch passed
		_ Other Tests _
-1	unit	17933	hbase-server in the patch failed.
+1	asflicense	30	The patch does not generate ASF License warnings.
		21627

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestFromClientSide3
	hadoop.hbase.client.TestAsyncTableAdminApi3
	hadoop.hbase.master.TestAssignmentManagerMetrics
	hadoop.hbase.client.TestFromClientSide

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/22/artifact/out/Dockerfile
GITHUB PR	#468
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 5b8aa48532ab 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revision	master / `edf6f68`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/22/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/22/testReport/
Max. process+thread count	4692 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/22/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-16T05:08:41Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	99	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	381	master passed
+1	compile	52	master passed
+1	checkstyle	75	master passed
+1	shadedjars	276	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	35	master passed
0	spotbugs	245	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	243	master passed
		_ Patch Compile Tests _
+1	mvninstall	299	the patch passed
+1	compile	54	the patch passed
+1	javac	54	the patch passed
+1	checkstyle	77	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	279	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	940	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	33	the patch passed
+1	findbugs	257	the patch passed
		_ Other Tests _
+1	unit	8679	hbase-server in the patch passed.
+1	asflicense	33	The patch does not generate ASF License warnings.
		12192

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/23/artifact/out/Dockerfile
GITHUB PR	#468
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 2b312e233019 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revision	master / `60971be`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/23/testReport/
Max. process+thread count	4693 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/23/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-16T05:34:29Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	39	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	363	master passed
+1	compile	52	master passed
+1	checkstyle	73	master passed
+1	shadedjars	271	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	34	master passed
0	spotbugs	258	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	257	master passed
		_ Patch Compile Tests _
+1	mvninstall	291	the patch passed
+1	compile	54	the patch passed
+1	javac	54	the patch passed
+1	checkstyle	75	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	274	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	912	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	33	the patch passed
+1	findbugs	252	the patch passed
		_ Other Tests _
-1	unit	8496	hbase-server in the patch failed.
+1	asflicense	24	The patch does not generate ASF License warnings.
		11857

Reason	Tests
Failed junit tests	hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/24/artifact/out/Dockerfile
GITHUB PR	#468
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 7e9ca1ba72b2 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revision	master / `78f5d8e`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/24/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/24/testReport/
Max. process+thread count	4621 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/24/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-16T10:28:24Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	40	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	320	master passed
+1	compile	51	master passed
+1	checkstyle	72	master passed
+1	shadedjars	262	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	34	master passed
0	spotbugs	254	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	253	master passed
		_ Patch Compile Tests _
+1	mvninstall	355	the patch passed
+1	compile	53	the patch passed
+1	javac	53	the patch passed
+1	checkstyle	74	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	316	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	896	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	32	the patch passed
+1	findbugs	246	the patch passed
		_ Other Tests _
+1	unit	8989	hbase-server in the patch passed.
+1	asflicense	24	The patch does not generate ASF License warnings.
		12370

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/25/artifact/out/Dockerfile
GITHUB PR	#468
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 3301e6471d94 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revision	master / `94af651`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/25/testReport/
Max. process+thread count	4786 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/25/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-16T16:37:40Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	71	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	332	master passed
+1	compile	53	master passed
+1	checkstyle	74	master passed
+1	shadedjars	272	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	38	master passed
0	spotbugs	276	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	275	master passed
		_ Patch Compile Tests _
+1	mvninstall	313	the patch passed
+1	compile	58	the patch passed
+1	javac	58	the patch passed
+1	checkstyle	81	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	283	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	970	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	33	the patch passed
+1	findbugs	278	the patch passed
		_ Other Tests _
-1	unit	20048	hbase-server in the patch failed.
+1	asflicense	29	The patch does not generate ASF License warnings.
		23585

Reason	Tests
Failed junit tests	hadoop.hbase.master.assignment.TestMergeTableRegionsProcedure
	hadoop.hbase.replication.TestReplicationDisableInactivePeer
	hadoop.hbase.tool.TestSecureBulkLoadHFiles
	hadoop.hbase.client.TestFromClientSide
	hadoop.hbase.tool.TestBulkLoadHFiles
	hadoop.hbase.client.TestAdmin2
	hadoop.hbase.replication.TestReplicationSmallTests
	hadoop.hbase.client.TestSnapshotTemporaryDirectory
	hadoop.hbase.replication.TestReplicationSmallTestsSync
	hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint
	hadoop.hbase.util.TestFromClientSide3WoUnsafe
	hadoop.hbase.client.TestAsyncTableAdminApi
	hadoop.hbase.client.TestCloneSnapshotFromClientNormal

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/26/artifact/out/Dockerfile
GITHUB PR	#468
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 350b882e9c6c 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revision	master / `3eb602c`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/26/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/26/testReport/
Max. process+thread count	4973 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/26/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-17T08:03:51Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	64	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	458	master passed
+1	compile	72	master passed
+1	checkstyle	106	master passed
+1	shadedjars	381	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	45	master passed
0	spotbugs	339	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	335	master passed
		_ Patch Compile Tests _
+1	mvninstall	423	the patch passed
+1	compile	72	the patch passed
+1	javac	72	the patch passed
+1	checkstyle	106	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	388	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1303	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	45	the patch passed
+1	findbugs	347	the patch passed
		_ Other Tests _
-1	unit	17750	hbase-server in the patch failed.
+1	asflicense	41	The patch does not generate ASF License warnings.
		22437

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestSnapshotTemporaryDirectory
	hadoop.hbase.master.TestMasterShutdown
	hadoop.hbase.replication.multiwal.TestReplicationEndpointWithMultipleAsyncWAL
	hadoop.hbase.client.TestFromClientSide

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/27/artifact/out/Dockerfile
GITHUB PR	#468
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 3f660bd444a7 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revision	master / `43a0ec8`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/27/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/27/testReport/
Max. process+thread count	5037 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/27/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-17T17:18:58Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	71	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	459	master passed
+1	compile	70	master passed
+1	checkstyle	108	master passed
+1	shadedjars	360	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	44	master passed
0	spotbugs	308	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	305	master passed
		_ Patch Compile Tests _
+1	mvninstall	415	the patch passed
+1	compile	74	the patch passed
+1	javac	74	the patch passed
+1	checkstyle	125	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	361	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1267	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	41	the patch passed
+1	findbugs	325	the patch passed
		_ Other Tests _
-1	unit	17273	hbase-server in the patch failed.
+1	asflicense	34	The patch does not generate ASF License warnings.
		21806

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestSnapshotTemporaryDirectory
	hadoop.hbase.replication.TestReplicationSmallTests
	hadoop.hbase.util.TestFromClientSide3WoUnsafe
	hadoop.hbase.client.TestFromClientSide
	hadoop.hbase.replication.TestReplicationSmallTestsSync

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/28/artifact/out/Dockerfile
GITHUB PR	#468
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux b3df9d8d9dad 4.4.0-143-generic #169-Ubuntu SMP Thu Feb 7 07:56:38 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revision	master / `7903f55`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/28/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/28/testReport/
Max. process+thread count	5095 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/28/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-18T00:01:45Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	57	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	434	master passed
+1	compile	77	master passed
+1	checkstyle	107	master passed
+1	shadedjars	381	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	45	master passed
0	spotbugs	340	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	336	master passed
		_ Patch Compile Tests _
+1	mvninstall	415	the patch passed
+1	compile	67	the patch passed
+1	javac	67	the patch passed
+1	checkstyle	97	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	353	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1190	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	42	the patch passed
+1	findbugs	337	the patch passed
		_ Other Tests _
-1	unit	15149	hbase-server in the patch failed.
+1	asflicense	33	The patch does not generate ASF License warnings.
		19578

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestAsyncTableAdminApi3
	hadoop.hbase.client.TestMobSnapshotCloneIndependence

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/30/artifact/out/Dockerfile
GITHUB PR	#468
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 03170b6897ec 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revision	master / `836f269`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/30/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/30/testReport/
Max. process+thread count	4915 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/30/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-18T07:36:04Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	65	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	329	master passed
+1	compile	53	master passed
+1	checkstyle	79	master passed
+1	shadedjars	304	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	37	master passed
0	spotbugs	247	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	245	master passed
		_ Patch Compile Tests _
+1	mvninstall	352	the patch passed
+1	compile	52	the patch passed
+1	javac	52	the patch passed
+1	checkstyle	75	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	268	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1003	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	34	the patch passed
+1	findbugs	251	the patch passed
		_ Other Tests _
-1	unit	16854	hbase-server in the patch failed.
+1	asflicense	32	The patch does not generate ASF License warnings.
		20441

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestFromClientSide
	hadoop.hbase.client.TestCloneSnapshotFromClientNormal
	hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController
	hadoop.hbase.client.TestSnapshotTemporaryDirectory
	hadoop.hbase.replication.TestReplicationDisableInactivePeer
	hadoop.hbase.util.TestFromClientSide3WoUnsafe
	hadoop.hbase.master.assignment.TestMergeTableRegionsProcedure
	hadoop.hbase.client.TestSnapshotCloneIndependence

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/31/artifact/out/Dockerfile
GITHUB PR	#468
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 73b74aeec0a6 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revision	master / `7697d48`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/31/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/31/testReport/
Max. process+thread count	4781 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/31/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

virajjasani · 2019-08-19T17:03:42Z

But even it only targets to a single RS where balance off is only a temporary move, do you really think it is a good practice or worthy of destructing then constructing a task, just within few minutes?

I agree that it should not keep doing this in shorter time.

@Reidddddd would you like me to close this PR?

Apache-HBase · 2019-08-19T22:58:49Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	61	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	407	master passed
+1	compile	73	master passed
+1	checkstyle	93	master passed
+1	shadedjars	356	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	45	master passed
0	spotbugs	317	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	313	master passed
		_ Patch Compile Tests _
+1	mvninstall	406	the patch passed
+1	compile	77	the patch passed
+1	javac	77	the patch passed
+1	checkstyle	104	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	345	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1270	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	41	the patch passed
+1	findbugs	312	the patch passed
		_ Other Tests _
-1	unit	18859	hbase-server in the patch failed.
+1	asflicense	33	The patch does not generate ASF License warnings.
		23292

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestFromClientSide3
	hadoop.hbase.tool.TestSecureBulkLoadHFiles
	hadoop.hbase.client.TestSnapshotTemporaryDirectory
	hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
	hadoop.hbase.replication.TestReplicationDisableInactivePeer
	hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory
	hadoop.hbase.tool.TestBulkLoadHFiles
	hadoop.hbase.replication.TestReplicationSmallTestsSync

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/32/artifact/out/Dockerfile
GITHUB PR	#468
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 28b518d9d2e0 4.4.0-143-generic #169-Ubuntu SMP Thu Feb 7 07:56:38 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revision	master / `46abaef`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/32/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/32/testReport/
Max. process+thread count	5018 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/32/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-20T00:58:28Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	93	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	373	master passed
+1	compile	60	master passed
+1	checkstyle	97	master passed
+1	shadedjars	304	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	39	master passed
0	spotbugs	273	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	270	master passed
		_ Patch Compile Tests _
+1	mvninstall	339	the patch passed
+1	compile	60	the patch passed
+1	javac	60	the patch passed
+1	checkstyle	89	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	307	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1096	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	39	the patch passed
+1	findbugs	290	the patch passed
		_ Other Tests _
-1	unit	13909	hbase-server in the patch failed.
+1	asflicense	26	The patch does not generate ASF License warnings.
		17823

Reason	Tests
Failed junit tests	hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush
	hadoop.hbase.regionserver.TestHRegion

Subsystem	Report/Notes
Docker	Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/33/artifact/out/Dockerfile
GITHUB PR	#468
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux ccccda2e8b75 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revision	master / `8e488ce`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/33/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/33/testReport/
Max. process+thread count	4755 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/33/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Reidddddd · 2019-08-20T02:53:17Z

would you like me to close this PR?

Thanks!

virajjasani · 2019-08-20T03:21:12Z

Closing the PR as per suggestion by @Reidddddd
If there is any change of thought, please let me know and I will reopen it.

Thanks for the review @Reidddddd @saintstack

Apache-HBase · 2019-08-20T04:47:32Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	103	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	419	master passed
+1	compile	62	master passed
+1	checkstyle	97	master passed
+1	shadedjars	332	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	43	master passed
0	spotbugs	258	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	255	master passed
		_ Patch Compile Tests _
+1	mvninstall	420	the patch passed
+1	compile	66	the patch passed
+1	javac	66	the patch passed
+1	checkstyle	88	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	331	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1210	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	46	the patch passed
+1	findbugs	312	the patch passed
		_ Other Tests _
-1	unit	19031	hbase-server in the patch failed.
+1	asflicense	27	The patch does not generate ASF License warnings.
		23303

Reason	Tests
Failed junit tests	hadoop.hbase.tool.TestSecureBulkLoadHFiles
	hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
	hadoop.hbase.regionserver.TestHRegion
	hadoop.hbase.client.TestFromClientSide3
	hadoop.hbase.client.TestAdmin1
	hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush
	hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated
	hadoop.hbase.tool.TestBulkLoadHFiles
	hadoop.hbase.util.TestFromClientSide3WoUnsafe
	hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/34/artifact/out/Dockerfile
GITHUB PR	#468
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux b1805f342f30 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh
git revision	master / `6738280`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/34/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/34/testReport/
Max. process+thread count	4969 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/34/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

HBASE-22822 : Un/Re-schedule balancer chore with balance_switch

cdaa133

active master to schedule balancer chore conditionally

472ab75

do not trigger balancer immediately

0ee0213

saintstack approved these changes Aug 11, 2019

View reviewed changes

s/turnBalancer/switchBalancer/

e94ab72

virajjasani closed this Aug 20, 2019

HBASE-22822 : Un/Re-schedule balancer chore with balance_switch #468

HBASE-22822 : Un/Re-schedule balancer chore with balance_switch #468

Uh oh!

Conversation

virajjasani commented Aug 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Apache-HBase commented Aug 8, 2019

Uh oh!

Apache-HBase commented Aug 9, 2019

Uh oh!

Apache-HBase commented Aug 9, 2019

Uh oh!

Apache-HBase commented Aug 9, 2019

Uh oh!

Apache-HBase commented Aug 9, 2019

Uh oh!

Apache-HBase commented Aug 10, 2019

Uh oh!

virajjasani commented Aug 11, 2019

Uh oh!

saintstack left a comment

Choose a reason for hiding this comment

Uh oh!

saintstack Aug 11, 2019

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Aug 11, 2019

Uh oh!

Apache-HBase commented Aug 12, 2019

Uh oh!

Apache-HBase commented Aug 12, 2019

Uh oh!

Reidddddd commented Aug 12, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

virajjasani commented Aug 12, 2019

Uh oh!

virajjasani commented Aug 12, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reidddddd commented Aug 12, 2019

Uh oh!

Apache-HBase commented Aug 12, 2019

Uh oh!

xcangCRM commented Aug 12, 2019

Uh oh!

virajjasani commented Aug 13, 2019

Uh oh!

Apache-HBase commented Aug 13, 2019

Uh oh!

Apache-HBase commented Aug 13, 2019

Uh oh!

Apache-HBase commented Aug 13, 2019

Uh oh!

Apache-HBase commented Aug 13, 2019

Uh oh!

Apache-HBase commented Aug 14, 2019

Uh oh!

Apache-HBase commented Aug 14, 2019

Uh oh!

Apache-HBase commented Aug 15, 2019

Uh oh!

Apache-HBase commented Aug 16, 2019

Uh oh!

Apache-HBase commented Aug 16, 2019

Uh oh!

Apache-HBase commented Aug 16, 2019

Uh oh!

Apache-HBase commented Aug 16, 2019

Uh oh!

Apache-HBase commented Aug 16, 2019

Uh oh!

Apache-HBase commented Aug 17, 2019

Uh oh!

Apache-HBase commented Aug 17, 2019

Uh oh!

Apache-HBase commented Aug 18, 2019

Uh oh!

Apache-HBase commented Aug 18, 2019

virajjasani commented Aug 8, 2019 •

edited

Loading

Reidddddd commented Aug 12, 2019 •

edited

Loading

virajjasani commented Aug 12, 2019 •

edited

Loading