HBASE-27066 The Region Visualizer display failed #4472

tomscut · 2022-05-27T06:26:18Z

The Region Visualizer display failed. Because the active master hostname is localhost.

Before the change:

After the change:

tomscut · 2022-05-27T06:26:58Z

Hi @ndimiduk , could you please take a look. Thanks.

Apache-HBase · 2022-05-27T06:48:29Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 37s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 39s	master passed
+1 💚	spotless	0m 45s	branch has no errors when running spotless:check.
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 5s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	spotless	0m 38s	patch has no errors when running spotless:check.
		_ Other Tests _
+1 💚	asflicense	0m 14s	The patch does not generate ASF License warnings.
		8m 13s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4472/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4472
Optional Tests	dupname asflicense javac spotless
uname	Linux 2151a557849b 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `fdf054d`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	64 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4472/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-05-27T10:08:26Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 5s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 52s	master passed
+1 💚	javadoc	0m 28s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 33s	the patch passed
+1 💚	javadoc	0m 26s	the patch passed
		_ Other Tests _
+1 💚	unit	199m 29s	hbase-server in the patch passed.
		208m 17s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4472/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4472
Optional Tests	javac javadoc unit
uname	Linux f3c791540e8e 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `fdf054d`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4472/1/testReport/
Max. process+thread count	2491 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4472/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-05-27T10:12:20Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 41s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 58s	master passed
+1 💚	javadoc	0m 30s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 9s	the patch passed
+1 💚	javadoc	0m 22s	the patch passed
		_ Other Tests _
+1 💚	unit	202m 44s	hbase-server in the patch passed.
		211m 50s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4472/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4472
Optional Tests	javac javadoc unit
uname	Linux 0a16ea9edd2d 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `fdf054d`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4472/1/testReport/
Max. process+thread count	2476 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4472/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

GideonPotok · 2022-05-28T13:23:38Z

LGTM

tomscut · 2022-05-29T01:10:26Z

Thanks @GideonPotok for the review.

Apache-HBase · 2022-05-29T03:59:38Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 42s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 49s	master passed
+1 💚	spotless	0m 44s	branch has no errors when running spotless:check.
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 6s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	spotless	0m 39s	patch has no errors when running spotless:check.
		_ Other Tests _
+1 💚	asflicense	0m 9s	The patch does not generate ASF License warnings.
		9m 23s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4472/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4472
Optional Tests	dupname asflicense javac spotless
uname	Linux e1d12331892f 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `cf0ed2e`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	64 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4472/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-05-29T07:17:31Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 0s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 53s	master passed
+1 💚	javadoc	0m 30s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 32s	the patch passed
+1 💚	javadoc	0m 27s	the patch passed
		_ Other Tests _
+1 💚	unit	198m 18s	hbase-server in the patch passed.
		207m 21s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4472/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4472
Optional Tests	javac javadoc unit
uname	Linux 7bc1eec8b595 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `cf0ed2e`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4472/2/testReport/
Max. process+thread count	2519 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4472/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Signed-off-by: Andrew Purtell <apurtell@apache.org>

tomscut · 2022-05-30T01:24:46Z

Thanks @apurtell for your review.

ndimiduk · 2022-05-31T19:13:29Z

hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/RegionVisualizerTmpl.jamon

@@ -29,7 +44,7 @@ limitations under the License.
          description: 'Total `storefileSize` per Region Server',
          data: {
            name: 'region_info',
-            url: 'http://localhost:16010/api/v1/admin/cluster_metrics/live_servers',


Not using localhost and a hard-coded port is definitely the right thing, good call. Now I'm wondering if we should show the chart at all on the backup masters, or if it should only be on the active one.

ndimiduk · 2022-05-31T19:13:58Z

hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/RegionVisualizerTmpl.jamon

@@ -29,7 +44,7 @@ limitations under the License.
          description: 'Total `storefileSize` per Region Server',
          data: {
            name: 'region_info',
-            url: 'http://localhost:16010/api/v1/admin/cluster_metrics/live_servers',
+            url: 'http://<% activeHostname %>:<% activeInfoPort %>/api/v1/admin/cluster_metrics/live_servers',


We also need to no longer hard-code http and instead decide the protocol based on the cluster configuration.

That's a good idea.

This reverts commit 5c116d2.

This reverts commit 5e54c6d.

This reverts commit 8b9df12.

This reverts commit 5e54c6d.

This reverts commit 8b9df12.

Signed-off-by: Andrew Purtell <apurtell@apache.org>

This reverts commit 5c116d2.

…che#4472)"" This reverts commit 9343f8f.

This reverts commit a400a66.

HBASE-27066 The Region Visualizer display failed

63093ca

replace assert with Preconditions.checkState

404e0ed

apurtell approved these changes May 29, 2022

View reviewed changes

apurtell merged commit 5c116d2 into apache:master May 29, 2022

asfgit pushed a commit that referenced this pull request May 29, 2022

HBASE-27066 The Region Visualizer display failed (#4472)

5e54c6d

Signed-off-by: Andrew Purtell <apurtell@apache.org>

asfgit pushed a commit that referenced this pull request May 29, 2022

HBASE-27066 The Region Visualizer display failed (#4472)

8b9df12

Signed-off-by: Andrew Purtell <apurtell@apache.org>

ndimiduk reviewed May 31, 2022

View reviewed changes

ndimiduk added a commit to ndimiduk/hbase that referenced this pull request Jun 6, 2022

Revert "HBASE-27066 The Region Visualizer display failed (apache#4472)"

00e2e39

This reverts commit 5c116d2.

ndimiduk added a commit to ndimiduk/hbase that referenced this pull request Jun 9, 2022

Revert "HBASE-27066 The Region Visualizer display failed (apache#4472)"

1c70366

This reverts commit 5c116d2.

ndimiduk added a commit that referenced this pull request Jun 9, 2022

Revert "HBASE-27066 The Region Visualizer display failed (#4472)"

02cc63e

This reverts commit 5c116d2.

ndimiduk added a commit to ndimiduk/hbase that referenced this pull request Jun 9, 2022

Revert "HBASE-27066 The Region Visualizer display failed (apache#4472)"

c033496

This reverts commit 5e54c6d.

ndimiduk added a commit to ndimiduk/hbase that referenced this pull request Jun 9, 2022

Revert "HBASE-27066 The Region Visualizer display failed (apache#4472)"

90b90d1

This reverts commit 8b9df12.

ndimiduk added a commit that referenced this pull request Jun 9, 2022

Revert "HBASE-27066 The Region Visualizer display failed (#4472)"

33f633a

This reverts commit 5e54c6d.

ndimiduk added a commit that referenced this pull request Jun 9, 2022

Revert "HBASE-27066 The Region Visualizer display failed (#4472)"

d24f4ce

This reverts commit 8b9df12.

wenwj0 pushed a commit to wenwj0/hbase that referenced this pull request Jun 14, 2022

HBASE-27066 The Region Visualizer display failed (apache#4472)

a400a66

Signed-off-by: Andrew Purtell <apurtell@apache.org>

wenwj0 pushed a commit to wenwj0/hbase that referenced this pull request Jun 14, 2022

Revert "HBASE-27066 The Region Visualizer display failed (apache#4472)"

9343f8f

This reverts commit 5c116d2.

wenwj0 added a commit to wenwj0/hbase that referenced this pull request Jun 14, 2022

Revert "Revert "HBASE-27066 The Region Visualizer display failed (apa…

6ea6a18

…che#4472)"" This reverts commit 9343f8f.

wenwj0 added a commit to wenwj0/hbase that referenced this pull request Jun 14, 2022

Revert "HBASE-27066 The Region Visualizer display failed (apache#4472)"

cca1733

This reverts commit a400a66.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HBASE-27066 The Region Visualizer display failed #4472

HBASE-27066 The Region Visualizer display failed #4472

Uh oh!

tomscut commented May 27, 2022

Uh oh!

tomscut commented May 27, 2022

Uh oh!

Apache-HBase commented May 27, 2022

Uh oh!

Apache-HBase commented May 27, 2022

Uh oh!

Apache-HBase commented May 27, 2022

Uh oh!

GideonPotok commented May 28, 2022

Uh oh!

tomscut commented May 29, 2022

Uh oh!

Apache-HBase commented May 29, 2022

Uh oh!

Apache-HBase commented May 29, 2022

Uh oh!

tomscut commented May 30, 2022

Uh oh!

ndimiduk May 31, 2022

Uh oh!

ndimiduk May 31, 2022

Uh oh!

tomscut Jun 4, 2022

Uh oh!

Uh oh!

HBASE-27066 The Region Visualizer display failed #4472

HBASE-27066 The Region Visualizer display failed #4472

Uh oh!

Conversation

tomscut commented May 27, 2022

Uh oh!

tomscut commented May 27, 2022

Uh oh!

Apache-HBase commented May 27, 2022

Uh oh!

Apache-HBase commented May 27, 2022

Uh oh!

Apache-HBase commented May 27, 2022

Uh oh!

GideonPotok commented May 28, 2022

Uh oh!

tomscut commented May 29, 2022

Uh oh!

Apache-HBase commented May 29, 2022

Uh oh!

Apache-HBase commented May 29, 2022

Uh oh!

tomscut commented May 30, 2022

Uh oh!

ndimiduk May 31, 2022

Choose a reason for hiding this comment

Uh oh!

ndimiduk May 31, 2022

Choose a reason for hiding this comment

Uh oh!

tomscut Jun 4, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!