HBASE-22699 refactor isMetaClearingException #436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Apache9
requested changes
Aug 2, 2019
hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/ClientExceptionsUtil.java
Show resolved
Hide resolved
hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/ClientExceptionsUtil.java
Outdated
Show resolved
Hide resolved
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Apache9
requested changes
Aug 6, 2019
hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/ClientExceptionsUtil.java
Outdated
Show resolved
Hide resolved
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Apache9
requested changes
Aug 9, 2019
| @@ -59,8 +59,7 @@ public static boolean isMetaClearingException(Throwable cur) { | |||
| if (cur == null) { | |||
| return true; | |||
| } | |||
| return !isSpecialException(cur) || (cur instanceof RegionMovedException) | |||
| || cur instanceof NotServingRegionException; | |||
| return !regionDefinitelyOnTheRegionServerException(cur); | |||
| } | |||
|
|
|||
| public static boolean isSpecialException(Throwable cur) { | |||
There was a problem hiding this comment.
Make this private? And can we reuse the regionDefinitelyOnTheRegionServerException so we can write less instance of here? And MultiActionResultTooLarge is not included in regionDefinitelyOnTheRegionServerException? Why?
There was a problem hiding this comment.
MultiActionResultTooLarge is a subclass of RetryImmediatelyException, which is there.
There was a problem hiding this comment.
Make this private? And can we reuse the regionDefinitelyOnTheRegionServerException so we can write less instance of here? And MultiActionResultTooLarge is not included in regionDefinitelyOnTheRegionServerException?
Here the isSpecialException is equivalent with regionDefinitelyOnTheRegionServerException, the two more exceptions in isSpecialException are RegionMovedException and RegionOpeningException. Both of them are subclasses of NotServingRegionException, which is there.
There was a problem hiding this comment.
OK, the problem for using regionDefinitelyOnTheRegionServerException directly in findException is the name of the method... Maybe we could add a other method which is called something like 'the exception we care' and in the method we just call regionDefinitelyOnTheRegionServerException and add comments to say that they are the same for now, as the intention there is that, if we hit these exceptions then we will not trying to get the cause any more.
|
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
reviewed
Aug 9, 2019
| || cur instanceof MultiActionResultTooLarge || cur instanceof RetryImmediatelyException | ||
| || cur instanceof CallQueueTooBigException || cur instanceof CallDroppedException | ||
| || cur instanceof NotServingRegionException || cur instanceof RequestTooBigException); | ||
|
|
|
💔 -1 overall
This message was automatically generated. |
Apache-HBase
reviewed
Aug 9, 2019
| || cur instanceof MultiActionResultTooLarge || cur instanceof RetryImmediatelyException | ||
| || cur instanceof CallQueueTooBigException || cur instanceof CallDroppedException | ||
| || cur instanceof NotServingRegionException || cur instanceof RequestTooBigException); | ||
|
|
|
💔 -1 overall
This message was automatically generated. |
Apache-HBase
reviewed
Aug 9, 2019
| || cur instanceof MultiActionResultTooLarge || cur instanceof RetryImmediatelyException | ||
| || cur instanceof CallQueueTooBigException || cur instanceof CallDroppedException | ||
| || cur instanceof NotServingRegionException || cur instanceof RequestTooBigException); | ||
|
|
|
💔 -1 overall
This message was automatically generated. |
Apache-HBase
reviewed
Aug 9, 2019
| || cur instanceof MultiActionResultTooLarge || cur instanceof RetryImmediatelyException | ||
| || cur instanceof CallQueueTooBigException || cur instanceof CallDroppedException | ||
| || cur instanceof NotServingRegionException || cur instanceof RequestTooBigException); | ||
|
|
|
💔 -1 overall
This message was automatically generated. |
Apache-HBase
reviewed
Aug 9, 2019
| || cur instanceof MultiActionResultTooLarge || cur instanceof RetryImmediatelyException | ||
| || cur instanceof CallQueueTooBigException || cur instanceof CallDroppedException | ||
| || cur instanceof NotServingRegionException || cur instanceof RequestTooBigException); | ||
|
|
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
asfgit
pushed a commit
that referenced
this pull request
Aug 12, 2019
Signed-off-by: Duo Zhang <zhangduo@apache.org>
asfgit
pushed a commit
that referenced
this pull request
Aug 12, 2019
Signed-off-by: Duo Zhang <zhangduo@apache.org>
asfgit
pushed a commit
that referenced
this pull request
Aug 12, 2019
Signed-off-by: Duo Zhang <zhangduo@apache.org>
asfgit
pushed a commit
that referenced
this pull request
Aug 12, 2019
Signed-off-by: Duo Zhang <zhangduo@apache.org>
symat
pushed a commit
to symat/hbase
that referenced
this pull request
Feb 17, 2021
Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit 0a98df3) Change-Id: Idd84702acbea7f6173883953f29082b7a5a4bebf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.