Skip to content

HBASE-22737 Add a new admin method and shell cmd to trigger the hbck … #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2019
Merged

HBASE-22737 Add a new admin method and shell cmd to trigger the hbck … #425

merged 1 commit into from
Aug 1, 2019

Conversation

infraio
Copy link
Contributor

@infraio infraio commented Jul 29, 2019

…chore to run

@Apache9
Copy link
Contributor

Apache9 commented Jul 29, 2019

Should this be in Admin? Or in Hbck?

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 197 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
0 mvndep 26 Maven dependency ordering for branch
+1 mvninstall 335 master passed
+1 compile 191 master passed
+1 checkstyle 186 master passed
+1 shadedjars 300 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 123 master passed
0 spotbugs 101 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 595 master passed
_ Patch Compile Tests _
0 mvndep 14 Maven dependency ordering for patch
+1 mvninstall 342 the patch passed
+1 compile 176 the patch passed
+1 cc 176 the patch passed
+1 javac 176 the patch passed
+1 checkstyle 10 The patch passed checkstyle in hbase-protocol-shaded
-1 checkstyle 34 hbase-client: The patch generated 2 new + 48 unchanged - 0 fixed = 50 total (was 48)
+1 checkstyle 85 hbase-server: The patch generated 0 new + 136 unchanged - 9 fixed = 136 total (was 145)
+1 checkstyle 41 The patch passed checkstyle in hbase-thrift
+1 checkstyle 10 The patch passed checkstyle in hbase-shell
-1 rubocop 12 The patch generated 3 new + 294 unchanged - 0 fixed = 297 total (was 294)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 303 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1091 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 hbaseprotoc 173 the patch passed
+1 javadoc 119 the patch passed
+1 findbugs 660 the patch passed
_ Other Tests _
+1 unit 45 hbase-protocol-shaded in the patch passed.
+1 unit 113 hbase-client in the patch passed.
-1 unit 15172 hbase-server in the patch failed.
+1 unit 277 hbase-thrift in the patch passed.
+1 unit 696 hbase-shell in the patch passed.
+1 asflicense 138 The patch does not generate ASF License warnings.
21982
Reason Tests
Failed junit tests hadoop.hbase.master.TestMasterShutdown
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/1/artifact/out/Dockerfile
GITHUB PR #425
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc rubocop
uname Linux fcbcf8053b91 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-425/out/precommit/personality/provided.sh
git revision master / 41490e7
Default Java 1.8.0_181
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/1/artifact/out/diff-checkstyle-hbase-client.txt
rubocop https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/1/artifact/out/diff-patch-rubocop.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/1/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/1/testReport/
Max. process+thread count 4973 (vs. ulimit of 10000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/1/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 rubocop=0.73.0
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 72 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
0 mvndep 23 Maven dependency ordering for branch
+1 mvninstall 343 master passed
+1 compile 167 master passed
+1 checkstyle 159 master passed
+1 shadedjars 306 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 118 master passed
0 spotbugs 91 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 608 master passed
_ Patch Compile Tests _
0 mvndep 16 Maven dependency ordering for patch
+1 mvninstall 325 the patch passed
+1 compile 169 the patch passed
+1 cc 169 the patch passed
+1 javac 169 the patch passed
+1 checkstyle 9 The patch passed checkstyle in hbase-protocol-shaded
-1 checkstyle 28 hbase-client: The patch generated 2 new + 48 unchanged - 0 fixed = 50 total (was 48)
+1 checkstyle 75 hbase-server: The patch generated 0 new + 136 unchanged - 9 fixed = 136 total (was 145)
+1 checkstyle 35 The patch passed checkstyle in hbase-thrift
+1 checkstyle 10 The patch passed checkstyle in hbase-shell
-1 rubocop 12 The patch generated 3 new + 294 unchanged - 0 fixed = 297 total (was 294)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 284 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1029 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 hbaseprotoc 160 the patch passed
+1 javadoc 112 the patch passed
+1 findbugs 574 the patch passed
_ Other Tests _
+1 unit 37 hbase-protocol-shaded in the patch passed.
+1 unit 106 hbase-client in the patch passed.
-1 unit 16798 hbase-server in the patch failed.
+1 unit 345 hbase-thrift in the patch passed.
+1 unit 737 hbase-shell in the patch passed.
+1 asflicense 140 The patch does not generate ASF License warnings.
23283
Reason Tests
Failed junit tests hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated
hadoop.hbase.client.TestSnapshotTemporaryDirectory
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/2/artifact/out/Dockerfile
GITHUB PR #425
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc rubocop
uname Linux 97dd0f25124f 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-425/out/precommit/personality/provided.sh
git revision master / 11f30de
Default Java 1.8.0_181
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/2/artifact/out/diff-checkstyle-hbase-client.txt
rubocop https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/2/artifact/out/diff-patch-rubocop.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/2/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/2/testReport/
Max. process+thread count 5141 (vs. ulimit of 10000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/2/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 rubocop=0.73.0
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

saintstack
saintstack reviewed Jul 29, 2019
View reviewed changes
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java Outdated
throws ServiceException {
rpcPreCheck("runHbckChore");
HbckChore hbckChore = master.getHbckChore();
if (!hbckChore.isRunning()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If already running, should result of this call be 'false' for did not run?//

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Return false if the HBCK chore already running.

hbase-shell/src/main/ruby/hbase/admin.rb Outdated
#----------------------------------------------------------------------------------------------
# Request HBCK chore to run
def hbck_chore_run
@admin.runHbckChore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, good question by @duo regards whether it should be in hbcksevice or not. It probably should?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

hbase-shell/src/main/ruby/shell/commands/hbck_chore_run.rb
def help
<<-EOF
Request HBCK chore to run at master side.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps say what the chore does? One sentence?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing 'm' on Filesystem. Fix on commit.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 0 Docker mode activated.
-1 patch 10 #425 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.
Subsystem Report/Notes
GITHUB PR #425
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/4/console
versions git=2.7.4
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 38 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
0 mvndep 15 Maven dependency ordering for branch
+1 mvninstall 294 master passed
+1 compile 162 master passed
+1 checkstyle 152 master passed
+1 shadedjars 255 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 107 master passed
0 spotbugs 88 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 523 master passed
_ Patch Compile Tests _
0 mvndep 13 Maven dependency ordering for patch
+1 mvninstall 273 the patch passed
+1 compile 159 the patch passed
+1 cc 159 the patch passed
+1 javac 159 the patch passed
+1 checkstyle 8 The patch passed checkstyle in hbase-protocol-shaded
-1 checkstyle 29 hbase-client: The patch generated 2 new + 48 unchanged - 0 fixed = 50 total (was 48)
+1 checkstyle 73 hbase-server: The patch generated 0 new + 136 unchanged - 9 fixed = 136 total (was 145)
+1 checkstyle 36 The patch passed checkstyle in hbase-thrift
+1 checkstyle 9 The patch passed checkstyle in hbase-shell
-1 rubocop 11 The patch generated 3 new + 294 unchanged - 0 fixed = 297 total (was 294)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 260 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 868 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 hbaseprotoc 149 the patch passed
+1 javadoc 107 the patch passed
+1 findbugs 558 the patch passed
_ Other Tests _
+1 unit 35 hbase-protocol-shaded in the patch passed.
+1 unit 105 hbase-client in the patch passed.
+1 unit 8185 hbase-server in the patch passed.
+1 unit 214 hbase-thrift in the patch passed.
+1 unit 420 hbase-shell in the patch passed.
+1 asflicense 97 The patch does not generate ASF License warnings.
13566
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/3/artifact/out/Dockerfile
GITHUB PR #425
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc rubocop
uname Linux 9913453f4182 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-425/out/precommit/personality/provided.sh
git revision master / f68cda3
Default Java 1.8.0_181
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/3/artifact/out/diff-checkstyle-hbase-client.txt
rubocop https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/3/artifact/out/diff-patch-rubocop.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/3/testReport/
Max. process+thread count 4643 (vs. ulimit of 10000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/3/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 rubocop=0.73.0
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 35 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 4 new or modified test files.
_ master Compile Tests _
0 mvndep 25 Maven dependency ordering for branch
+1 mvninstall 300 master passed
+1 compile 133 master passed
+1 checkstyle 120 master passed
+1 shadedjars 258 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 76 master passed
0 spotbugs 247 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 460 master passed
_ Patch Compile Tests _
0 mvndep 14 Maven dependency ordering for patch
+1 mvninstall 311 the patch passed
+1 compile 130 the patch passed
+1 cc 130 the patch passed
+1 javac 130 the patch passed
+1 checkstyle 9 The patch passed checkstyle in hbase-protocol-shaded
-1 checkstyle 29 hbase-client: The patch generated 1 new + 5 unchanged - 0 fixed = 6 total (was 5)
+1 checkstyle 71 hbase-server: The patch generated 0 new + 136 unchanged - 7 fixed = 136 total (was 143)
+1 checkstyle 9 The patch passed checkstyle in hbase-shell
-1 rubocop 14 The patch generated 4 new + 436 unchanged - 1 fixed = 440 total (was 437)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 260 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 894 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 hbaseprotoc 121 the patch passed
+1 javadoc 74 the patch passed
+1 findbugs 463 the patch passed
_ Other Tests _
+1 unit 35 hbase-protocol-shaded in the patch passed.
+1 unit 103 hbase-client in the patch passed.
+1 unit 8372 hbase-server in the patch passed.
+1 unit 445 hbase-shell in the patch passed.
+1 asflicense 96 The patch does not generate ASF License warnings.
13253
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/5/artifact/out/Dockerfile
GITHUB PR #425
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc rubocop
uname Linux 159bf4aac23a 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-425/out/precommit/personality/provided.sh
git revision master / 0c80d5b
Default Java 1.8.0_181
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/5/artifact/out/diff-checkstyle-hbase-client.txt
rubocop https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/5/artifact/out/diff-patch-rubocop.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/5/testReport/
Max. process+thread count 4513 (vs. ulimit of 10000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-shell U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/5/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 rubocop=0.73.0
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 39 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 4 new or modified test files.
_ master Compile Tests _
0 mvndep 12 Maven dependency ordering for branch
+1 mvninstall 330 master passed
+1 compile 158 master passed
+1 checkstyle 128 master passed
+1 shadedjars 265 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 76 master passed
0 spotbugs 72 Used deprecated FindBugs config; considering switching to SpotBugs.
-1 findbugs 138 hbase-server in master failed.
_ Patch Compile Tests _
0 mvndep 13 Maven dependency ordering for patch
+1 mvninstall 280 the patch passed
+1 compile 130 the patch passed
+1 cc 130 the patch passed
+1 javac 130 the patch passed
+1 checkstyle 9 The patch passed checkstyle in hbase-protocol-shaded
-1 checkstyle 27 hbase-client: The patch generated 1 new + 5 unchanged - 0 fixed = 6 total (was 5)
+1 checkstyle 71 hbase-server: The patch generated 0 new + 136 unchanged - 7 fixed = 136 total (was 143)
+1 checkstyle 9 The patch passed checkstyle in hbase-shell
-1 rubocop 14 The patch generated 4 new + 436 unchanged - 1 fixed = 440 total (was 437)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 258 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 879 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 hbaseprotoc 134 the patch passed
+1 javadoc 83 the patch passed
+1 findbugs 471 the patch passed
_ Other Tests _
+1 unit 36 hbase-protocol-shaded in the patch passed.
+1 unit 106 hbase-client in the patch passed.
-1 unit 1596 hbase-server in the patch failed.
-1 unit 416 hbase-shell in the patch failed.
+1 asflicense 47 The patch does not generate ASF License warnings.
6346
Reason Tests
Failed junit tests hadoop.hbase.master.normalizer.TestSimpleRegionNormalizer
hadoop.hbase.master.TestMasterCoprocessorServices
hadoop.hbase.master.TestMasterQosFunction
hadoop.hbase.client.TestAsyncAccessControlAdminApi
hadoop.hbase.client.TestMultiActionMetricsFromClient
hadoop.hbase.client.TestAdminShell2
hadoop.hbase.client.TestShell
hadoop.hbase.client.TestAdminShell
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/7/artifact/out/Dockerfile
GITHUB PR #425
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc rubocop
uname Linux 50a8a1a22685 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-425/out/precommit/personality/provided.sh
git revision master / 124fa34
Default Java 1.8.0_181
findbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/7/artifact/out/branch-findbugs-hbase-server.txt
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/7/artifact/out/diff-checkstyle-hbase-client.txt
rubocop https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/7/artifact/out/diff-patch-rubocop.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/7/artifact/out/patch-unit-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/7/artifact/out/patch-unit-hbase-shell.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/7/testReport/
Max. process+thread count 2748 (vs. ulimit of 10000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-shell U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/7/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 rubocop=0.73.0
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 73 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 4 new or modified test files.
_ master Compile Tests _
0 mvndep 14 Maven dependency ordering for branch
+1 mvninstall 308 master passed
+1 compile 138 master passed
+1 checkstyle 128 master passed
+1 shadedjars 273 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 84 master passed
0 spotbugs 265 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 494 master passed
_ Patch Compile Tests _
0 mvndep 15 Maven dependency ordering for patch
+1 mvninstall 306 the patch passed
+1 compile 141 the patch passed
+1 cc 141 the patch passed
+1 javac 141 the patch passed
+1 checkstyle 10 The patch passed checkstyle in hbase-protocol-shaded
-1 checkstyle 32 hbase-client: The patch generated 1 new + 5 unchanged - 0 fixed = 6 total (was 5)
+1 checkstyle 86 hbase-server: The patch generated 0 new + 136 unchanged - 7 fixed = 136 total (was 143)
+1 checkstyle 11 The patch passed checkstyle in hbase-shell
-1 rubocop 15 The patch generated 4 new + 436 unchanged - 1 fixed = 440 total (was 437)
+1 whitespace 1 The patch has no whitespace issues.
+1 shadedjars 285 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 944 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 hbaseprotoc 131 the patch passed
+1 javadoc 81 the patch passed
+1 findbugs 422 the patch passed
_ Other Tests _
+1 unit 37 hbase-protocol-shaded in the patch passed.
+1 unit 106 hbase-client in the patch passed.
-1 unit 14756 hbase-server in the patch failed.
+1 unit 737 hbase-shell in the patch passed.
+1 asflicense 118 The patch does not generate ASF License warnings.
20182
Reason Tests
Failed junit tests hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/8/artifact/out/Dockerfile
GITHUB PR #425
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc rubocop
uname Linux 7815e010c6ef 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-425/out/precommit/personality/provided.sh
git revision master / e3a54e7
Default Java 1.8.0_181
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/8/artifact/out/diff-checkstyle-hbase-client.txt
rubocop https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/8/artifact/out/diff-patch-rubocop.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/8/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/8/testReport/
Max. process+thread count 4704 (vs. ulimit of 10000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-shell U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/8/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 rubocop=0.72.0
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 63 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 4 new or modified test files.
_ master Compile Tests _
0 mvndep 12 Maven dependency ordering for branch
+1 mvninstall 289 master passed
+1 compile 131 master passed
+1 checkstyle 120 master passed
+1 shadedjars 262 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 73 master passed
0 spotbugs 241 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 448 master passed
_ Patch Compile Tests _
0 mvndep 13 Maven dependency ordering for patch
+1 mvninstall 292 the patch passed
+1 compile 130 the patch passed
+1 cc 130 the patch passed
+1 javac 130 the patch passed
+1 checkstyle 8 The patch passed checkstyle in hbase-protocol-shaded
-1 checkstyle 27 hbase-client: The patch generated 1 new + 5 unchanged - 0 fixed = 6 total (was 5)
+1 checkstyle 74 hbase-server: The patch generated 0 new + 136 unchanged - 7 fixed = 136 total (was 143)
+1 checkstyle 8 The patch passed checkstyle in hbase-shell
-1 rubocop 15 The patch generated 4 new + 436 unchanged - 1 fixed = 440 total (was 437)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 266 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 910 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 hbaseprotoc 121 the patch passed
+1 javadoc 73 the patch passed
-1 findbugs 19 hbase-client in the patch failed.
-1 findbugs 35 hbase-server in the patch failed.
_ Other Tests _
+1 unit 34 hbase-protocol-shaded in the patch passed.
-1 unit 20 hbase-client in the patch failed.
-1 unit 35 hbase-server in the patch failed.
-1 unit 51 hbase-shell in the patch failed.
+1 asflicense 38 The patch does not generate ASF License warnings.
4119
Reason Tests
Failed junit tests hadoop.hbase.client.TestReplicationShell
hadoop.hbase.client.TestQuotasShell
hadoop.hbase.client.TestShell
hadoop.hbase.client.TestAdminShell
hadoop.hbase.client.rsgroup.TestShellRSGroups
hadoop.hbase.client.TestAdminShell2
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/10/artifact/out/Dockerfile
GITHUB PR #425
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc rubocop
uname Linux 751fb4d5a9b1 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-425/out/precommit/personality/provided.sh
git revision master / 4a61c8b
Default Java 1.8.0_181
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/10/artifact/out/diff-checkstyle-hbase-client.txt
rubocop https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/10/artifact/out/diff-patch-rubocop.txt
findbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/10/artifact/out/patch-findbugs-hbase-client.txt
findbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/10/artifact/out/patch-findbugs-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/10/artifact/out/patch-unit-hbase-client.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/10/artifact/out/patch-unit-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/10/artifact/out/patch-unit-hbase-shell.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/10/testReport/
Max. process+thread count 701 (vs. ulimit of 10000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-shell U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/10/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 rubocop=0.73.0
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 91 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 4 new or modified test files.
_ master Compile Tests _
0 mvndep 13 Maven dependency ordering for branch
+1 mvninstall 310 master passed
+1 compile 158 master passed
+1 checkstyle 138 master passed
+1 shadedjars 280 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 83 master passed
0 spotbugs 73 Used deprecated FindBugs config; considering switching to SpotBugs.
-1 findbugs 39 hbase-server in master failed.
_ Patch Compile Tests _
0 mvndep 15 Maven dependency ordering for patch
+1 mvninstall 305 the patch passed
+1 compile 142 the patch passed
+1 cc 142 the patch passed
+1 javac 142 the patch passed
+1 checkstyle 9 The patch passed checkstyle in hbase-protocol-shaded
-1 checkstyle 33 hbase-client: The patch generated 1 new + 5 unchanged - 0 fixed = 6 total (was 5)
+1 checkstyle 86 hbase-server: The patch generated 0 new + 136 unchanged - 7 fixed = 136 total (was 143)
+1 checkstyle 10 The patch passed checkstyle in hbase-shell
-1 rubocop 14 The patch generated 4 new + 436 unchanged - 1 fixed = 440 total (was 437)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 279 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 953 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 hbaseprotoc 135 the patch passed
+1 javadoc 83 the patch passed
+1 findbugs 519 the patch passed
_ Other Tests _
+1 unit 40 hbase-protocol-shaded in the patch passed.
+1 unit 107 hbase-client in the patch passed.
-1 unit 14902 hbase-server in the patch failed.
+1 unit 575 hbase-shell in the patch passed.
+1 asflicense 80 The patch does not generate ASF License warnings.
20067
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/9/artifact/out/Dockerfile
GITHUB PR #425
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc rubocop
uname Linux e1a5345e71ce 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-425@2/out/precommit/personality/provided.sh
git revision master / e3a54e7
Default Java 1.8.0_181
findbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/9/artifact/out/branch-findbugs-hbase-server.txt
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/9/artifact/out/diff-checkstyle-hbase-client.txt
rubocop https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/9/artifact/out/diff-patch-rubocop.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/9/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/9/testReport/
Max. process+thread count 4582 (vs. ulimit of 10000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-shell U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/9/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 rubocop=0.72.0
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 0 Docker mode activated.
-1 patch 10 #425 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.
Subsystem Report/Notes
GITHUB PR #425
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/13/console
versions git=2.7.4
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 142 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 4 new or modified test files.
_ master Compile Tests _
0 mvndep 25 Maven dependency ordering for branch
+1 mvninstall 456 master passed
+1 compile 182 master passed
+1 checkstyle 163 master passed
+1 shadedjars 357 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 106 master passed
0 spotbugs 296 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 590 master passed
_ Patch Compile Tests _
0 mvndep 17 Maven dependency ordering for patch
+1 mvninstall 427 the patch passed
+1 compile 187 the patch passed
+1 cc 187 the patch passed
+1 javac 187 the patch passed
+1 checkstyle 11 The patch passed checkstyle in hbase-protocol-shaded
+1 checkstyle 38 The patch passed checkstyle in hbase-client
+1 checkstyle 95 hbase-server: The patch generated 0 new + 136 unchanged - 7 fixed = 136 total (was 143)
+1 checkstyle 12 The patch passed checkstyle in hbase-shell
-1 rubocop 16 The patch generated 4 new + 436 unchanged - 1 fixed = 440 total (was 437)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 309 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1045 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 hbaseprotoc 146 the patch passed
+1 javadoc 83 the patch passed
+1 findbugs 523 the patch passed
_ Other Tests _
+1 unit 45 hbase-protocol-shaded in the patch passed.
+1 unit 112 hbase-client in the patch passed.
-1 unit 15383 hbase-server in the patch failed.
+1 unit 431 hbase-shell in the patch passed.
+1 asflicense 98 The patch does not generate ASF License warnings.
21479
Reason Tests
Failed junit tests hadoop.hbase.tool.TestSecureBulkLoadHFiles
Subsystem Report/Notes
Docker Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/14/artifact/out/Dockerfile
GITHUB PR #425
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc rubocop
uname Linux fb3e283d24c8 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-425/out/precommit/personality/provided.sh
git revision master / 373c2dc
Default Java 1.8.0_181
rubocop https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/14/artifact/out/diff-patch-rubocop.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/14/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/14/testReport/
Max. process+thread count 4681 (vs. ulimit of 10000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-shell U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/14/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 rubocop=0.73.0
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 39 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 4 new or modified test files.
_ master Compile Tests _
0 mvndep 25 Maven dependency ordering for branch
+1 mvninstall 291 master passed
+1 compile 132 master passed
+1 checkstyle 117 master passed
+1 shadedjars 259 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 81 master passed
0 spotbugs 235 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 449 master passed
_ Patch Compile Tests _
0 mvndep 14 Maven dependency ordering for patch
+1 mvninstall 279 the patch passed
-1 compile 20 hbase-client in the patch failed.
-1 compile 34 hbase-server in the patch failed.
-1 cc 20 hbase-client in the patch failed.
-1 cc 34 hbase-server in the patch failed.
-1 javac 20 hbase-client in the patch failed.
-1 javac 34 hbase-server in the patch failed.
+1 checkstyle 8 The patch passed checkstyle in hbase-protocol-shaded
+1 checkstyle 27 The patch passed checkstyle in hbase-client
+1 checkstyle 69 hbase-server: The patch generated 0 new + 136 unchanged - 7 fixed = 136 total (was 143)
+1 checkstyle 9 The patch passed checkstyle in hbase-shell
-1 rubocop 14 The patch generated 4 new + 436 unchanged - 1 fixed = 440 total (was 437)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 255 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 897 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 hbaseprotoc 130 the patch passed
+1 javadoc 78 the patch passed
+1 findbugs 476 the patch passed
_ Other Tests _
+1 unit 36 hbase-protocol-shaded in the patch passed.
+1 unit 108 hbase-client in the patch passed.
+1 unit 8148 hbase-server in the patch passed.
+1 unit 424 hbase-shell in the patch passed.
+1 asflicense 93 The patch does not generate ASF License warnings.
13040
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/15/artifact/out/Dockerfile
GITHUB PR #425
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc rubocop
uname Linux 729e6a2c2992 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-425/out/precommit/personality/provided.sh
git revision master / 586e177
Default Java 1.8.0_181
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/15/artifact/out/patch-compile-hbase-client.txt
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/15/artifact/out/patch-compile-hbase-server.txt
cc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/15/artifact/out/patch-compile-hbase-client.txt
cc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/15/artifact/out/patch-compile-hbase-server.txt
javac https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/15/artifact/out/patch-compile-hbase-client.txt
javac https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/15/artifact/out/patch-compile-hbase-server.txt
rubocop https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/15/artifact/out/diff-patch-rubocop.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/15/testReport/
Max. process+thread count 4961 (vs. ulimit of 10000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-shell U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/15/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 rubocop=0.73.0
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 40 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 4 new or modified test files.
_ master Compile Tests _
0 mvndep 14 Maven dependency ordering for branch
+1 mvninstall 290 master passed
+1 compile 132 master passed
+1 checkstyle 128 master passed
+1 shadedjars 274 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 82 master passed
0 spotbugs 246 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 453 master passed
_ Patch Compile Tests _
0 mvndep 14 Maven dependency ordering for patch
+1 mvninstall 295 the patch passed
+1 compile 135 the patch passed
+1 cc 135 the patch passed
+1 javac 135 the patch passed
+1 checkstyle 9 The patch passed checkstyle in hbase-protocol-shaded
+1 checkstyle 30 The patch passed checkstyle in hbase-client
+1 checkstyle 71 hbase-server: The patch generated 0 new + 136 unchanged - 7 fixed = 136 total (was 143)
+1 checkstyle 9 The patch passed checkstyle in hbase-shell
-1 rubocop 14 The patch generated 4 new + 436 unchanged - 1 fixed = 440 total (was 437)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 260 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 884 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 hbaseprotoc 122 the patch passed
+1 javadoc 78 the patch passed
+1 findbugs 465 the patch passed
_ Other Tests _
+1 unit 38 hbase-protocol-shaded in the patch passed.
+1 unit 120 hbase-client in the patch passed.
+1 unit 8305 hbase-server in the patch passed.
+1 unit 88 hbase-shell in the patch passed.
+1 asflicense 100 The patch does not generate ASF License warnings.
12864
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/18/artifact/out/Dockerfile
GITHUB PR #425
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc rubocop
uname Linux 28ddd8c6cff0 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-425/out/precommit/personality/provided.sh
git revision master / 24b970e
Default Java 1.8.0_181
rubocop https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/18/artifact/out/diff-patch-rubocop.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/18/testReport/
Max. process+thread count 4822 (vs. ulimit of 10000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-shell U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/18/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 rubocop=0.73.0
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

saintstack
saintstack approved these changes Jul 31, 2019
View reviewed changes
Copy link
Contributor

@saintstack saintstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor item to fix on commit.

hbase-shell/src/main/ruby/shell/commands/hbck_chore_run.rb
def help
<<-EOF
Request HBCK chore to run at master side.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing 'm' on Filesystem. Fix on commit.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 39 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 4 new or modified test files.
_ master Compile Tests _
0 mvndep 13 Maven dependency ordering for branch
+1 mvninstall 292 master passed
+1 compile 136 master passed
+1 checkstyle 127 master passed
+1 shadedjars 270 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 84 master passed
0 spotbugs 232 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 447 master passed
_ Patch Compile Tests _
0 mvndep 17 Maven dependency ordering for patch
+1 mvninstall 291 the patch passed
+1 compile 134 the patch passed
+1 cc 134 the patch passed
+1 javac 134 the patch passed
+1 checkstyle 11 The patch passed checkstyle in hbase-protocol-shaded
+1 checkstyle 31 The patch passed checkstyle in hbase-client
+1 checkstyle 77 hbase-server: The patch generated 0 new + 136 unchanged - 7 fixed = 136 total (was 143)
+1 checkstyle 12 The patch passed checkstyle in hbase-shell
-1 rubocop 14 The patch generated 4 new + 436 unchanged - 1 fixed = 440 total (was 437)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 270 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 911 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 hbaseprotoc 131 the patch passed
+1 javadoc 84 the patch passed
+1 findbugs 475 the patch passed
_ Other Tests _
+1 unit 33 hbase-protocol-shaded in the patch passed.
+1 unit 97 hbase-client in the patch passed.
+1 unit 8599 hbase-server in the patch passed.
+1 unit 82 hbase-shell in the patch passed.
+1 asflicense 92 The patch does not generate ASF License warnings.
13173
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/19/artifact/out/Dockerfile
GITHUB PR #425
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc rubocop
uname Linux 23ca7d3de008 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-425/out/precommit/personality/provided.sh
git revision master / 4829c18
Default Java 1.8.0_181
rubocop https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/19/artifact/out/diff-patch-rubocop.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/19/testReport/
Max. process+thread count 4446 (vs. ulimit of 10000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-shell U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/19/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 rubocop=0.73.0
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@infraio infraio merged commit 35acf3c into apache:master Aug 1, 2019
@infraio infraio deleted the HBASE-22737 branch August 1, 2019 00:55
asfgit pushed a commit that referenced this pull request Aug 1, 2019
@infraio
HBASE-22737 Add a new admin method and shell cmd to trigger the hbck …
6a20872 
…chore to run (#425)

Signed-off-by: stack <stack@apache.org>
@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 99 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 4 new or modified test files.
_ master Compile Tests _
0 mvndep 24 Maven dependency ordering for branch
-1 mvninstall 81 root in master failed.
-1 compile 19 hbase-client in master failed.
-1 compile 36 hbase-server in master failed.
+1 checkstyle 122 master passed
+1 shadedjars 279 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 78 master passed
0 spotbugs 151 Used deprecated FindBugs config; considering switching to SpotBugs.
-1 findbugs 22 hbase-client in master failed.
-1 findbugs 35 hbase-server in master failed.
_ Patch Compile Tests _
0 mvndep 14 Maven dependency ordering for patch
-1 mvninstall 83 root in the patch failed.
-1 compile 21 hbase-client in the patch failed.
-1 compile 35 hbase-server in the patch failed.
-1 cc 21 hbase-client in the patch failed.
-1 cc 35 hbase-server in the patch failed.
-1 javac 21 hbase-client in the patch failed.
-1 javac 35 hbase-server in the patch failed.
+1 checkstyle 8 The patch passed checkstyle in hbase-protocol-shaded
+1 checkstyle 26 The patch passed checkstyle in hbase-client
+1 checkstyle 75 hbase-server: The patch generated 0 new + 136 unchanged - 7 fixed = 136 total (was 143)
+1 checkstyle 10 The patch passed checkstyle in hbase-shell
-1 rubocop 15 The patch generated 4 new + 436 unchanged - 1 fixed = 440 total (was 437)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 272 patch has no errors when building our shaded downstream artifacts.
-1 hadoopcheck 54 The patch causes 10 errors with Hadoop v2.8.5.
-1 hadoopcheck 113 The patch causes 10 errors with Hadoop v2.9.2.
-1 hadoopcheck 172 The patch causes 10 errors with Hadoop v3.1.2.
-1 hbaseprotoc 19 Patch generated 5 new protoc errors in hbase-client.
-1 hbaseprotoc 39 Patch generated 10 new protoc errors in hbase-server.
-1 hbaseprotoc 24 Patch generated 10 new protoc errors in hbase-shell.
+1 javadoc 82 the patch passed
-1 findbugs 22 hbase-client in the patch failed.
-1 findbugs 38 hbase-server in the patch failed.
_ Other Tests _
+1 unit 38 hbase-protocol-shaded in the patch passed.
-1 unit 20 hbase-client in the patch failed.
-1 unit 38 hbase-server in the patch failed.
-1 unit 72 hbase-shell in the patch failed.
+1 asflicense 36 The patch does not generate ASF License warnings.
2540
Reason Tests
Failed junit tests hadoop.hbase.client.rsgroup.TestShellRSGroups
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/20/artifact/out/Dockerfile
GITHUB PR #425
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc rubocop
uname Linux 6a55ba415733 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-425/out/precommit/personality/provided.sh
git revision master / 4829c18
Default Java 1.8.0_181
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/20/artifact/out/branch-mvninstall-root.txt
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/20/artifact/out/branch-compile-hbase-client.txt
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/20/artifact/out/branch-compile-hbase-server.txt
findbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/20/artifact/out/branch-findbugs-hbase-client.txt
findbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/20/artifact/out/branch-findbugs-hbase-server.txt
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/20/artifact/out/patch-mvninstall-root.txt
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/20/artifact/out/patch-compile-hbase-client.txt
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/20/artifact/out/patch-compile-hbase-server.txt
cc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/20/artifact/out/patch-compile-hbase-client.txt
cc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/20/artifact/out/patch-compile-hbase-server.txt
javac https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/20/artifact/out/patch-compile-hbase-client.txt
javac https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/20/artifact/out/patch-compile-hbase-server.txt
rubocop https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/20/artifact/out/diff-patch-rubocop.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/20/artifact/out/patch-javac-2.8.5.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/20/artifact/out/patch-javac-2.9.2.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/20/artifact/out/patch-javac-3.1.2.txt
hbaseprotoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/20/artifact/out/patch-hbaseprotoc-hbase-client.txt
hbaseprotoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/20/artifact/out/patch-hbaseprotoc-hbase-server.txt
hbaseprotoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/20/artifact/out/patch-hbaseprotoc-hbase-shell.txt
findbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/20/artifact/out/patch-findbugs-hbase-client.txt
findbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/20/artifact/out/patch-findbugs-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/20/artifact/out/patch-unit-hbase-client.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/20/artifact/out/patch-unit-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/20/artifact/out/patch-unit-hbase-shell.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/20/testReport/
Max. process+thread count 771 (vs. ulimit of 10000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-shell U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-425/20/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 rubocop=0.73.0
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

asfgit pushed a commit that referenced this pull request Aug 1, 2019
@infraio
HBASE-22737 Add a new admin method and shell cmd to trigger the hbck …
5ec1fed 
…chore to run (#425)

Signed-off-by: stack <stack@apache.org>
asfgit pushed a commit that referenced this pull request Aug 1, 2019
@infraio
HBASE-22737 Add a new admin method and shell cmd to trigger the hbck …
e68b16a 
…chore to run (#425)

Signed-off-by: stack <stack@apache.org>
asfgit pushed a commit that referenced this pull request Aug 1, 2019
@infraio
HBASE-22737 Add a new admin method and shell cmd to trigger the hbck …
a28aec8 
…chore to run (#425)

Signed-off-by: stack <stack@apache.org>
infraio added a commit to infraio/hbase that referenced this pull request Aug 17, 2020
@infraio
HBASE-22737 Add a new admin method and shell cmd to trigger the hbck …
b3a87c6 
…chore to run (apache#425)

Signed-off-by: stack <stack@apache.org>
symat pushed a commit to symat/hbase that referenced this pull request Feb 17, 2021
@infraio
HBASE-22737 Add a new admin method and shell cmd to trigger the hbck …
6cb2afd 
…chore to run (apache#425)

Signed-off-by: stack <stack@apache.org>
(cherry picked from commit 5ec1fed)

Change-Id: I1d4fa998b1f167bf292b819fc42f935cd2fc3ca0
@igorbernstein2 igorbernstein2 mentioned this pull request Mar 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saintstack saintstack saintstack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@infraio @Apache9 @Apache-HBase @saintstack