HBASE-26691 Replacing log4j with reload4j for branch-2.x #4050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jojochuang
reviewed
Jan 21, 2022
Yes, if you do not want to ban transitive dependency, just add |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
The latest reload4j version is 1.2.18.3 with a few additional vulnerabilities fixed. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
jojochuang
reviewed
Jan 26, 2022
| @@ -426,42 +350,6 @@ | |||
| </dependencies> | |||
|
|
|||
| </profile> | |||
|
|
|||
There was a problem hiding this comment.
I'm not sure about this part, but the rest LGTM
|
Basically in addition to replacing reload4j, the PR also simplifies dependency management. |
|
can you also verify the test failure is unrelated? |
|
I am testing my Hadoop reload4j patch, and then realized there are a lot of gotchas when building downstream applications. |
For HBase we have tried out best to not introduce log4j dependencies to our downstream users, they will only pull in slf4j, so I do not think it will break our users too much. But it is true that hadoop and zookeeper will introduce log4j and slf4j-log4j12 dependencies to downstreamer users, I suggest we do a round of cleanup, to avoid introducing these dependencies. Thanks. |
apurtell
approved these changes
Feb 25, 2022
| @@ -220,6 +220,24 @@ | |||
| <scope>compile</scope> | |||
| <optional>true</optional> | |||
| </dependency> | |||
| <dependency> | |||
| @@ -322,100 +340,6 @@ | |||
| </property> | |||
| </activation> | |||
| <dependencies> | |||
| <dependency> | |||
There was a problem hiding this comment.
Oh, I see, some extra refactoring?
| <type>test-jar</type> | ||
| <scope>compile</scope> | ||
| <exclusions> |
There was a problem hiding this comment.
I don't have a strong opinion about this so will approve the PR but it would be better to stick with just the changes that are implied by the description [HBASE-26691 Replacing log4j with reload4j for branch-2.x]
|
If there are no more concerns or updates, I will merge this tomorrow. |
|
So do we plan to use reload4j for 2.x, or we plan to directly upgrade to log4j2? |
|
how about we get this in place for branches-2 now, so that we can stop shipping hbase 2 releases with an EOL log4j 1, but we plan for the log4j 2 changes to be the preferred path for whatever the next minor 2.x release is after the backport lands. (presuming the testing goes well.) |
Fine by me~ |
|
Merged. Agreed, we can do this now and I will pick it all the way back to branch-2.4, and anytime we can commit log4j2 work when ready to branch-2.5 and branch-2. |
asfgit
pushed a commit
that referenced
this pull request
Mar 4, 2022
Signed-off-by: Andrew Purtell <apurtell@apache.org> Conflicts: pom.xml
asfgit
pushed a commit
that referenced
this pull request
Mar 4, 2022
Signed-off-by: Andrew Purtell <apurtell@apache.org>
|
I also committed an addendum that ups the reload4j version to the latest release at this time, 1.2.19, and fixes a couple of misses in shading and assembly configuration. |
lizhexi
reviewed
Jun 13, 2022
| <groupId>org.apache.hadoop</groupId> | ||
| <artifactId>hadoop-minicluster</artifactId> | ||
| <scope>test</scope> | ||
| </dependency> |
There was a problem hiding this comment.
The child POM does not inherit the exclusion of the dependency introduced by the parent POM. Is the reconstruction safe? What are the considerations for deleting the exclusions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.