-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-24984 WAL corruption due to early DBBs re-use when Durability.A… #3495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to follow up on the suggestion to separate the ref tracking logic to a new class and document that class before committing.
+1 to address the new class (generic) in a followup issue. Would like to get this committed and get this in for 2.3.6 @saintstack pinged for issues in dev@ mail chain. Multiple times this bug been raised. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls add more comments as Duo suggested. Fully agree to Andrew that its hard logic (math) to understand. So even we can give math samples to explain it as much as possible. I also did tests to make sure that the math (negative number) is correct and achieves what we need.
6e425b8
to
af3267d
Compare
Thx all for the reviews, I believe I have addressed all. Will create separate jira for the improvement related to separating out class |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
…SYNC_WAL is used with multi operation
886adda
to
2ed6f3a
Compare
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
…SYNC_WAL is used with multi operation