[HBASE-22591] : RecoverableZooKeeper improvement for getData, getChil… #310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dren, exists and removal of unused reference
|
🎊 +1 overall
This message was automatically generated. |
HorizonNet
reviewed
Jun 16, 2019
|
|
||
| private Stat getStatInstance(String path, Watcher watcher, Boolean watch) | ||
| throws InterruptedException, KeeperException { | ||
| try (TraceScope scope = TraceUtil.createTrace("RecoverableZookeeper.exists")) { |
Contributor
There was a problem hiding this comment.
Why is there a need for the scope variable? It isn't used anywhere.
Contributor
Author
There was a problem hiding this comment.
It’s true that the scope variable isn’t used anywhere. However, that is how it is used with try-with-resources in most of the cases in this project to create htrace and then close it.
|
|
||
| private List<String> getChildrenUtils(String path, Watcher watcher, Boolean watch) | ||
| throws InterruptedException, KeeperException { | ||
| try (TraceScope scope = TraceUtil.createTrace("RecoverableZookeeper.getChildren")) { |
|
|
||
| private byte[] getDataUtils(String path, Watcher watcher, Boolean watch, Stat stat) | ||
| throws InterruptedException, KeeperException { | ||
| try (TraceScope scope = TraceUtil.createTrace("RecoverableZookeeper.getData")) { |
wchevreuil
reviewed
Jun 17, 2019
| return getStatInstance(path, watcher, null); | ||
| } | ||
|
|
||
| private Stat getStatInstance(String path, Watcher watcher, Boolean watch) |
Contributor
There was a problem hiding this comment.
maybe worth rename this method, overloading it as exists, for coherence?
wchevreuil
reviewed
Jun 17, 2019
| return getChildrenUtils(path, watcher, null); | ||
| } | ||
|
|
||
| private List<String> getChildrenUtils(String path, Watcher watcher, Boolean watch) |
Contributor
There was a problem hiding this comment.
Similar to my previous comment, maybe simply overload getChildren?
wchevreuil
reviewed
Jun 17, 2019
| return getDataUtils(path, watcher, null, stat); | ||
| } | ||
|
|
||
| private byte[] getDataUtils(String path, Watcher watcher, Boolean watch, Stat stat) |
Contributor
|
Proposed changes look good. Overall, had suggested some minor neats, but it's more like a personal style, up to you @virajjasani . |
Contributor
Author
|
@wchevreuil Although it is personal style, it's definitely better one. Also, +1 to the removal of getSessionPasswd. Thanks for the suggestion. Incorporated in the latest commit |
|
🎊 +1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…dren, exists and removal of unused reference EnvironmentEdgeManager