HBASE-25657 Fix spotbugs warnings after upgrading spotbugs to 4.x

[Apache9]

No description provided.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 24s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 45s	master passed
+1 💚	compile	3m 53s	master passed
+1 💚	checkstyle	1m 22s	master passed
-1 ❌	spotbugs	0m 43s	hbase-rest in master has 1 extant spotbugs warnings.
-1 ❌	spotbugs	2m 1s	hbase-server in master has 1 extant spotbugs warnings.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 27s	the patch passed
+1 💚	compile	3m 51s	the patch passed
+1 💚	javac	3m 51s	the patch passed
-0 ⚠️	checkstyle	0m 16s	hbase-rest: The patch generated 1 new + 28 unchanged - 0 fixed = 29 total (was 28)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	17m 23s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	2m 14s	hbase-server generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
+1 💚	spotbugs	0m 50s	hbase-rest generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
		_ Other Tests _
+1 💚	asflicense	0m 26s	The patch does not generate ASF License warnings.
		50m 6s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3041/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3041
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux fb7813bdda58 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / d79019b
Default Java	AdoptOpenJDK-1.8.0_282-b08
spotbugs	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3041/1/artifact/yetus-general-check/output/branch-spotbugs-hbase-rest-warnings.html
spotbugs	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3041/1/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3041/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-rest.txt
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-server hbase-rest U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3041/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 31s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 22s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 16s	master passed
+1 💚	compile	1m 32s	master passed
+1 💚	shadedjars	6m 45s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 2s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 4s	the patch passed
+1 💚	compile	1m 32s	the patch passed
+1 💚	javac	1m 32s	the patch passed
+1 💚	shadedjars	6m 42s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 2s	the patch passed
		_ Other Tests _
+1 💚	unit	141m 45s	hbase-server in the patch passed.
+1 💚	unit	3m 56s	hbase-rest in the patch passed.
		176m 5s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3041/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3041
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux e8078772e7b6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / d79019b
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3041/1/testReport/
Max. process+thread count	4195 (vs. ulimit of 30000)
modules	C: hbase-server hbase-rest U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3041/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 28s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 24s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 32s	master passed
+1 💚	compile	1m 43s	master passed
+1 💚	shadedjars	8m 32s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 6s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 25s	the patch passed
+1 💚	compile	1m 30s	the patch passed
+1 💚	javac	1m 30s	the patch passed
+1 💚	shadedjars	8m 53s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 1s	the patch passed
		_ Other Tests _
+1 💚	unit	162m 36s	hbase-server in the patch passed.
+1 💚	unit	3m 33s	hbase-rest in the patch passed.
		202m 35s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3041/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3041
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 610d166f708b 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / d79019b
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3041/1/testReport/
Max. process+thread count	3977 (vs. ulimit of 30000)
modules	C: hbase-server hbase-rest U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3041/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.