Skip to content

HBASE-22198 Fix flakey TestAsyncTableGetMultiThreaded #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2019

Conversation

Apache9
Copy link
Contributor

@Apache9 Apache9 commented Apr 10, 2019

No description provided.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 32 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1 mvninstall 289 master passed
+1 compile 55 master passed
+1 checkstyle 72 master passed
+1 shadedjars 268 branch has no errors when building our shaded downstream artifacts.
-1 findbugs 166 hbase-server in master has 11 extant Findbugs warnings.
+1 javadoc 34 master passed
_ Patch Compile Tests _
+1 mvninstall 250 the patch passed
+1 compile 54 the patch passed
+1 javac 54 the patch passed
+1 checkstyle 67 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 269 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 518 Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1 findbugs 169 the patch passed
+1 javadoc 33 the patch passed
_ Other Tests _
+1 unit 8496 hbase-server in the patch passed.
+1 asflicense 25 The patch does not generate ASF License warnings.
10877
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-135/1/artifact/out/Dockerfile
GITHUB PR #135
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 11c595129294 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / 494a8ef
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
findbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-135/1/artifact/out/branch-findbugs-hbase-server-warnings.html
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-135/1/testReport/
Max. process+thread count 5292 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-135/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache9
Copy link
Contributor Author

Apache9 commented Apr 10, 2019

The findbugs warnings are not introduced by this patch.

break;
}
} catch (IOException e) {
LOG.warn("Failed to query");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the difference is here ? even if the region is not online, we'll retry unti exhaust or fail ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UT aims to test whether we can deal with region moving/splitting, so it is possible that the region is not online at some point, but the admin method will not fail immediately without retrying, which is not like what we do in normal get/put operation, so here we need to catch the exception and use an external RetryCounter to retry. Otherwise it will cause the test to fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants