Skip to content

Commit e5008c8

Browse files
HBASE-22571 changes made according to comments by Jan
1 parent 4003a03 commit e5008c8

File tree

11 files changed

+19
-17
lines changed

11 files changed

+19
-17
lines changed

hbase-client/src/main/java/org/apache/hadoop/hbase/client/SimpleRequestController.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -434,7 +434,7 @@ private void waitForRegion() throws InterruptedIOException {
434434
*
435435
* @param loc
436436
* @param heapSizeOfRow
437-
* @return either Include ReturnCode or Skip ReturnCode
437+
* @return either Include {@link ReturnCode} or Skip {@link ReturnCode}
438438
*/
439439
@Override
440440
public ReturnCode canTakeOperation(HRegionLocation loc, long heapSizeOfRow) {

hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapred/TestTableInputFormat.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,8 @@ public static Table createTable(byte[] tableName, byte[][] families) throws IOEx
147147
* @param key
148148
* @param expectedKey
149149
* @param expectedValue
150-
* @return true if succeed
150+
* @return true if result and key have expected values, false otherwise. Where result is a single
151+
* row result.
151152
*/
152153
static boolean checkResult(Result r, ImmutableBytesWritable key,
153154
byte[] expectedKey, byte[] expectedValue) {

hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableInputFormat.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,8 @@ public static Table createTable(byte[] tableName, byte[][] families) throws IOEx
145145
* @param key
146146
* @param expectedKey
147147
* @param expectedValue
148-
* @return true if succeed
148+
* @return true if result and key have expected values, false otherwise. Where result is a single
149+
* row result.
149150
*/
150151
static boolean checkResult(Result r, ImmutableBytesWritable key,
151152
byte[] expectedKey, byte[] expectedValue) {

hbase-server/src/main/java/org/apache/hadoop/hbase/client/locking/EntityLock.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,7 @@ public LockHeartbeatWorker(final String desc) {
218218
}
219219

220220
/**
221-
* @return Shutdown the thread cleanly, quietly. We done.
221+
* @return Shuts down the thread clean and quietly.
222222
*/
223223
Thread shutdown() {
224224
shutdown = true;

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4090,7 +4090,7 @@ OperationStatus[] batchMutate(BatchOperation<?> batchOp) throws IOException {
40904090
/**
40914091
* Called to do a piece of the batch that came in to {@link #batchMutate(Mutation[], long, long)}
40924092
* In here we also handle replay of edits on region recover. Also gets change in size brought
4093-
* about by applying <code>batchOp</code>
4093+
* about by applying {@code batchOp}.
40944094
*/
40954095
private void doMiniBatchMutate(BatchOperation<?> batchOp) throws IOException {
40964096
boolean success = false;

hbase-server/src/test/java/org/apache/hadoop/hbase/TestServerSideScanMetricsFromClientSide.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -109,12 +109,12 @@ public static void tearDownAfterClass() throws Exception {
109109

110110
/**
111111
* Make puts to put the input value into each combination of row, family, and qualifier
112-
* @param rows
113-
* @param families
114-
* @param qualifiers
115-
* @param value
116-
* @return the putted values added in puts
117-
* @throws IOException
112+
* @param rows the rows to use
113+
* @param families the column families to use
114+
* @param qualifiers the column qualifiers to use
115+
* @param value the value to put
116+
* @return the putted input values added in puts
117+
* @throws IOException If IO problem is encountered
118118
*/
119119
static ArrayList<Put> createPuts(byte[][] rows, byte[][] families, byte[][] qualifiers,
120120
byte[] value) throws IOException {

hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestOpenTableInCoprocessor.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,8 +94,8 @@ public void prePut(final ObserverContext<RegionCoprocessorEnvironment> e, final
9494
public static class CustomThreadPoolCoprocessor implements RegionCoprocessor, RegionObserver {
9595

9696
/**
97-
* @return a pool that has only ever one thread. A second action added to the pool (running
98-
* concurrently), will cause an exception.
97+
* @return a pool that has one thread only at every time. A second action added to the pool (
98+
* running concurrently), will cause an exception.
9999
*/
100100
private ExecutorService getPool() {
101101
int maxThreads = 1;

hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/BalancerTestBase.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -328,7 +328,7 @@ protected String printMock(List<ServerAndLoad> balancedCluster) {
328328
*
329329
* @param list
330330
* @param plans
331-
* @return the result which has all added map ServerAndLoad values
331+
* @return a list of all added {@link ServerAndLoad} values.
332332
*/
333333
protected List<ServerAndLoad> reconcile(List<ServerAndLoad> list,
334334
List<RegionPlan> plans,

hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStore.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -794,7 +794,7 @@ private static void flushStore(HStore store, long id) throws IOException {
794794
* @param numRows
795795
* @param qualifier
796796
* @param family
797-
* @return KeyValues list
797+
* @return row KeyValues list
798798
*/
799799
List<Cell> getKeyValueSet(long[] timestamps, int numRows,
800800
byte[] qualifier, byte[] family) {

hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStoreFile.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -844,7 +844,7 @@ private HStoreFile mockStoreFile(boolean bulkLoad,
844844
* @param numRows
845845
* @param qualifier
846846
* @param family
847-
* @return KeyValues list
847+
* @return row KeyValues list
848848
*/
849849
List<KeyValue> getKeyValueSet(long[] timestamps, int numRows,
850850
byte[] qualifier, byte[] family) {

0 commit comments

Comments
 (0)