Skip to content

Commit e26a7b5

Browse files
committed
PR feedback
Simplify `SpanDataMatchers#hasDuration` to work explicitly with `Duration` instances.
1 parent 03cd42a commit e26a7b5

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

hbase-client/src/test/java/org/apache/hadoop/hbase/client/trace/hamcrest/SpanDataMatchers.java

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -48,14 +48,12 @@ public static Matcher<SpanData> hasAttributes(Matcher<Attributes> matcher) {
4848
};
4949
}
5050

51-
public static <T extends Comparable<T> & TemporalAmount> Matcher<SpanData> hasDuration(
52-
Matcher<T> matcher
53-
) {
54-
return new FeatureMatcher<SpanData, T>(matcher, "SpanData having duration that ", "duration") {
51+
public static Matcher<SpanData> hasDuration(Matcher<Duration> matcher) {
52+
return new FeatureMatcher<SpanData, Duration>(
53+
matcher, "SpanData having duration that ", "duration") {
5554
@Override
56-
@SuppressWarnings("unchecked")
57-
protected T featureValueOf(SpanData item) {
58-
return (T) Duration.ofNanos(item.getEndEpochNanos() - item.getStartEpochNanos());
55+
protected Duration featureValueOf(SpanData item) {
56+
return Duration.ofNanos(item.getEndEpochNanos() - item.getStartEpochNanos());
5957
}
6058
};
6159
}

0 commit comments

Comments
 (0)