HBASE-25016 addendum: should also close the Table which is returned by calling getMetaHTable

nyl3532016 · virajjasani · commit dcba4930d469 · 2020-09-14T12:26:27.000+05:30
Closes #2393 Signed-off-by: Viraj Jasani <vjasani@apache.org>
diff --git a/hbase-balancer/src/main/java/org/apache/hadoop/hbase/MetaTableAccessor.java b/hbase-balancer/src/main/java/org/apache/hadoop/hbase/MetaTableAccessor.java
@@ -249,7 +249,8 @@ public static Result scanByRegionEncodedName(Connection connection, String regio
         new RowFilter(CompareOperator.EQUAL, new SubstringComparator(regionEncodedName));
     Scan scan = getMetaScan(connection, 1);
     scan.setFilter(rowFilter);
-    try (ResultScanner resultScanner = getMetaHTable(connection).getScanner(scan)) {
+    try (Table table = getMetaHTable(connection);
+        ResultScanner resultScanner = table.getScanner(scan)) {
       return resultScanner.next();
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -249,7 +249,8 @@ public static Result scanByRegionEncodedName(Connection connection, String regio`
`249`	`249`	`new RowFilter(CompareOperator.EQUAL, new SubstringComparator(regionEncodedName));`
`250`	`250`	`Scan scan = getMetaScan(connection, 1);`
`251`	`251`	`scan.setFilter(rowFilter);`
`252`		`- try (ResultScanner resultScanner = getMetaHTable(connection).getScanner(scan)) {`
	`252`	`+ try (Table table = getMetaHTable(connection);`
	`253`	`+ ResultScanner resultScanner = table.getScanner(scan)) {`
`253`	`254`	`return resultScanner.next();`
`254`	`255`	`}`
`255`	`256`	`}`