HBASE-26816 Fix CME in ReplicationSourceManager (#4187)

sunhelly · web-flow · commit dbf56819c36f · 2022-03-11T11:06:14.000+08:00
Signed-off-by: Duo Zhang &lt;zhangduo@apache.org&gt;
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java
@@ -906,8 +906,10 @@ public void join() {
     for (ReplicationSourceInterface source : this.sources.values()) {
       source.terminate("Region server is closing");
     }
-    for (ReplicationSourceInterface source : this.oldsources) {
-      source.terminate("Region server is closing");
+    synchronized (oldsources) {
+      for (ReplicationSourceInterface source : this.oldsources) {
+        source.terminate("Region server is closing");
+      }
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -906,8 +906,10 @@ public void join() {`
`906`	`906`	`for (ReplicationSourceInterface source : this.sources.values()) {`
`907`	`907`	`source.terminate("Region server is closing");`
`908`	`908`	`}`
`909`		`- for (ReplicationSourceInterface source : this.oldsources) {`
`910`		`- source.terminate("Region server is closing");`
	`909`	`+ synchronized (oldsources) {`
	`910`	`+ for (ReplicationSourceInterface source : this.oldsources) {`
	`911`	`+ source.terminate("Region server is closing");`
	`912`	`+ }`
`911`	`913`	`}`
`912`	`914`	`}`
`913`	`915`