Skip to content

Commit d20433c

Browse files
committed
Use raw types as appropriate TestMasterHbckServlet
GSON won't deserialize back into HBase native types so don't give the wrong impression by using them.
1 parent ff5face commit d20433c

File tree

1 file changed

+10
-14
lines changed

1 file changed

+10
-14
lines changed

hbase-server/src/test/java/org/apache/hadoop/hbase/master/http/TestMasterHbckServlet.java

Lines changed: 10 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ public void setupMocks() {
158158
doReturn(services).when(master).getMasterRpcServices();
159159
}
160160

161-
@SuppressWarnings("unchecked")
161+
@SuppressWarnings({ "unchecked", "rawtypes" })
162162
@Test
163163
public void testHbckServletWithMocks() throws Exception {
164164
// Set up request and response mocks
@@ -206,33 +206,29 @@ public Void answer(InvocationOnMock invocation) throws Throwable {
206206
assertEquals(FAKE_START_TIMESTAMP, startTimestamp);
207207
long endTimestamp = ((Double) result.get(MasterHbckServlet.END_TIMESTAMP)).longValue();
208208
assertEquals(FAKE_END_TIMESTAMP, endTimestamp);
209-
Map<String, Pair<ServerName, List<ServerName>>> inconsistentRegions = (Map<String,
210-
Pair<ServerName, List<ServerName>>>) result.get(MasterHbckServlet.INCONSISTENT_REGIONS);
209+
Map<String, Object> inconsistentRegions = (Map<String, Object>)
210+
result.get(MasterHbckServlet.INCONSISTENT_REGIONS);
211211
assertNotNull(inconsistentRegions);
212212
assertEquals(1, inconsistentRegions.size());
213213
assertNotNull(inconsistentRegions.get(FAKE_HRI.getEncodedName()));
214214
assertNull(inconsistentRegions.get(FAKE_HRI_3.getEncodedName()));
215-
Map<String, ServerName> orphanRegionsOnRS =
216-
(Map<String, ServerName>) result.get(MasterHbckServlet.ORPHAN_REGIONS_ON_RS);
215+
Map<String, Object> orphanRegionsOnRS = (Map<String, Object>) result.get(MasterHbckServlet.ORPHAN_REGIONS_ON_RS);
217216
assertNull(orphanRegionsOnRS);
218-
Map<String, Path> orphanRegionsOnFS =
219-
(Map<String, Path>) result.get(MasterHbckServlet.ORPHAN_REGIONS_ON_FS);
217+
Map<String, String> orphanRegionsOnFS =
218+
(Map<String, String>) result.get(MasterHbckServlet.ORPHAN_REGIONS_ON_FS);
220219
assertNotNull(orphanRegionsOnFS);
221220
assertEquals(1, orphanRegionsOnFS.size());
222221
assertNull(orphanRegionsOnFS.get(FAKE_HRI.getEncodedName()));
223222
assertNotNull(orphanRegionsOnFS.get(FAKE_HRI_3.getEncodedName()));
224-
List<Pair<RegionInfo, RegionInfo>> holes =
225-
(List<Pair<RegionInfo, RegionInfo>>) result.get(MasterHbckServlet.HOLES);
223+
List holes = (List) result.get(MasterHbckServlet.HOLES);
226224
assertNull(holes);
227-
List<Pair<RegionInfo, RegionInfo>> overlaps =
228-
(List<Pair<RegionInfo, RegionInfo>>) result.get(MasterHbckServlet.OVERLAPS);
225+
List overlaps = (List) result.get(MasterHbckServlet.OVERLAPS);
229226
assertNotNull(overlaps);
230227
assertEquals(1, overlaps.size());
231-
List<Pair<RegionInfo, ServerName>> unknownServers =
232-
(List<Pair<RegionInfo, ServerName>>) result.get(MasterHbckServlet.UNKNOWN_SERVERS);
228+
List unknownServers = (List) result.get(MasterHbckServlet.UNKNOWN_SERVERS);
233229
assertNotNull(unknownServers);
234230
assertEquals(1, unknownServers.size());
235-
List<byte[]> emptyRegionInfo = (List<byte[]>) result.get(MasterHbckServlet.EMPTY_REGIONINFO);
231+
List emptyRegionInfo = (List) result.get(MasterHbckServlet.EMPTY_REGIONINFO);
236232
assertNotNull(emptyRegionInfo);
237233
assertEquals(1, emptyRegionInfo.size());
238234
}

0 commit comments

Comments
 (0)