HBASE-27993 AbstractFSWAL causes ArithmeticException due to improper logRollSize value checking (#5390)

teamconfx · Apache9 · commit c2a41cb2f405 · 2024-03-28T23:54:37.000+08:00
Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Wei-Chiu Chuang <weichiu@apache.org> (cherry picked from commit 8be9e51)
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java
@@ -379,6 +379,9 @@ protected long getFileNumFromFileName(Path fileName) {
   }
 
   private int calculateMaxLogFiles(Configuration conf, long logRollSize) {
+    checkArgument(logRollSize > 0,
+      "The log roll size cannot be zero or negative when calculating max log files, "
+        + "current value is " + logRollSize);
     Pair<Long, MemoryType> globalMemstoreSize = MemorySizeUtil.getGlobalMemStoreSize(conf);
     return (int) ((globalMemstoreSize.getFirst() * 2) / logRollSize);
   }

Original file line number	Diff line number	Diff line change
`@@ -379,6 +379,9 @@ protected long getFileNumFromFileName(Path fileName) {`
`379`	`379`	`}`
`380`	`380`
`381`	`381`	`private int calculateMaxLogFiles(Configuration conf, long logRollSize) {`
	`382`	`+ checkArgument(logRollSize > 0,`
	`383`	`+ "The log roll size cannot be zero or negative when calculating max log files, "`
	`384`	`+ + "current value is " + logRollSize);`
`382`	`385`	`Pair<Long, MemoryType> globalMemstoreSize = MemorySizeUtil.getGlobalMemStoreSize(conf);`
`383`	`386`	`return (int) ((globalMemstoreSize.getFirst() * 2) / logRollSize);`
`384`	`387`	`}`