Skip to content

Commit badf072

Browse files
committed
HBASE-29035: Amount of region cached in the region metrics not updated for a region immediately after it is flushed with cacheOnWrite turned on
1 parent 39d4785 commit badf072

File tree

1 file changed

+12
-11
lines changed

1 file changed

+12
-11
lines changed

hbase-server/src/test/java/org/apache/hadoop/hbase/TestCacheEviction.java

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,8 @@ private void doTestEvictOnClose(String table, boolean evictOnClose,
141141
}
142142
}
143143

144-
private void createTable(TableName tableName, boolean shouldFlushTable) throws IOException, InterruptedException {
144+
private void createTable(TableName tableName, boolean shouldFlushTable)
145+
throws IOException, InterruptedException {
145146
byte[] family = Bytes.toBytes("CF");
146147
TableDescriptor td = TableDescriptorBuilder.newBuilder(tableName)
147148
.setColumnFamily(ColumnFamilyDescriptorBuilder.of(family)).build();
@@ -199,17 +200,17 @@ public void testCacheWithFlush() throws Exception {
199200

200201
private void checkRegionCached(TableName tableName, boolean isCached) throws IOException {
201202
UTIL.getMiniHBaseCluster().getRegions(tableName).forEach(r -> {
202-
try {
203-
UTIL.getMiniHBaseCluster().getClusterMetrics().getLiveServerMetrics().forEach((sn, sm) -> {
204-
for (Map.Entry<byte[], RegionMetrics> rm : sm.getRegionMetrics().entrySet()) {
205-
if (rm.getValue().getNameAsString().equals(r.getRegionInfo().getRegionNameAsString())) {
206-
assertTrue(isCached == (rm.getValue().getCurrentRegionCachedRatio() > 0.0f));
207-
}
203+
try {
204+
UTIL.getMiniHBaseCluster().getClusterMetrics().getLiveServerMetrics().forEach((sn, sm) -> {
205+
for (Map.Entry<byte[], RegionMetrics> rm : sm.getRegionMetrics().entrySet()) {
206+
if (rm.getValue().getNameAsString().equals(r.getRegionInfo().getRegionNameAsString())) {
207+
assertTrue(isCached == (rm.getValue().getCurrentRegionCachedRatio() > 0.0f));
208208
}
209-
});
210-
} catch (IOException e) {
211-
throw new RuntimeException(e);
212-
}
209+
}
210+
});
211+
} catch (IOException e) {
212+
throw new RuntimeException(e);
213+
}
213214
});
214215
}
215216
}

0 commit comments

Comments
 (0)